xfarrow/lasd
1
0
Fork 0
mirror of https://github.com/xfarrow/lasd.git synced 2025-06-05 21:49:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Library 3

Browse Source 
bug fix: when size==0 and a BinaryTree[Lnk/Vec] is casted to BinaryTree, and operator== is called, it crashed
This commit is contained in:
Alessandro Ferro
2021-05-25 15:56:40 +02:00
parent f337ff7543
commit 828a41dd72
2 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
librerie/exercise3/binarytree/binarytree.cpp
View File

@ -61,9 +61,13 @@ const Data& BinaryTree<Data>::Node::Element() const{
/* ----- end of struct Node ----- */ /* ----- end of struct Node ----- */
template <typename Data> template <typename Data>
bool BinaryTree<Data>::operator==(const BinaryTree& toCompare) const noexcept{ bool BinaryTree<Data>::operator==(const BinaryTree& tree) const noexcept{
if(size!=toCompare.size) return false; if(size == tree.size){
return(Root() == toCompare.Root()); if(size == 0) return true;
else return (Root() == tree.Root());
}else{
return false;
}
} }
template <typename Data> template <typename Data>

13
librerie/exercise3/binarytree/lnk/binarytreelnk.cpp
View File

@ -140,14 +140,15 @@ BinaryTreeLnk<Data>& BinaryTreeLnk<Data>::operator=(BinaryTreeLnk<Data>&& tree)
return *this; return *this;
} }
/*
** operator== and operator!= can be removed from BinaryTreeLnk since they are
** inherited from BinaryTree. They're here just for clarity and because they're
** in the template.
** Maybe you can make them more optimized here.
*/
template <typename Data> template <typename Data>
bool BinaryTreeLnk<Data>::operator==(const BinaryTreeLnk<Data>& tree) const noexcept{ bool BinaryTreeLnk<Data>::operator==(const BinaryTreeLnk<Data>& tree) const noexcept{
if(size == tree.size){ return (BinaryTree<Data>::operator==(tree));
if(size == 0) return true;
else return (Root() == tree.Root());
}else{
return false;
}
} }
template <typename Data> template <typename Data>