xfarrow/guify
1
0
Fork 0
mirror of https://github.com/xfarrow/guify.git synced 2025-02-17 12:30:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Some comments

Browse Source
This commit is contained in:
xfarrow 2023-07-27 17:17:05 +02:00
parent a900c94b5a
commit 62f24084d6
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Guify/src/views/Queue.java
View File

@ -86,6 +86,34 @@ public class Queue extends JFrame implements IQueueFrame {
}
}
// This method can receive a transferProgress whose status can be INIT, UPDATING
// or END.
// In all of these cases it is possible that transferProgress is or is not in the HashMap,
// and we'll prove its correctness in all the cases:
//
// 1. Init: This method can receive a transferProgress whose status is INIT and
// a. Not present in the HashMap: this can happen both when QueueController receives
// an update() and when it iterates in the constructor over the previously enqueued
// elements. In both cases, the transfer gets correctly put in the table.
// b. Present in the HashMap: despite it's counterintuitive, this can happen when
// a transfer gets initialized after QueueEventManager.getInstance().addObserver(this);
// and before QueueEventManager.getInstance().getQueue().
// This would lead either update()
// or the QueueController's constructor to call this method over a transferProgress
// already in the HashMap but whose status is INIT. In this case, updateRow() will
// be called, but without any side effects as the percentage would be zero regardless.
//
// 2. Updating:
// a. Not present in the HashMap: This can happen when the Queue UI is opened
// while an element is already being transferred. If it's not present in the HashMap
// it's added.
// b. Present in the HashMap: it will be updated.
//
// 3. End: Same case for Updating
//
// If any update gets triggered after QueueEventManager.getInstance().addObserver(this);
// and before QueueEventManager.getInstance().getQueue(), it is possible that [...]
// but this would not create any problems
@Override
public void manageTransferProgress(TransferProgress transferProgress) {
@ -98,7 +126,7 @@ public class Queue extends JFrame implements IQueueFrame {
addRow(transferProgress.getSource(),
transferProgress.getDestination(),
transferProgress.getOperation() == SftpProgressMonitor.GET? "Download" : "Upload",
controller.computePercentage(transferProgress)));
controller.computePercentage(transferProgress)));
}
else {
updateRow(controller.getTableIndex(transferProgress), controller.computePercentage(transferProgress));