xfarrow/blink
0
0
Fork 0
mirror of https://github.com/xfarrow/blink synced 2025-04-04 15:21:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

update

Browse Source
This commit is contained in:
xfarrow 2024-02-14 10:01:22 +01:00
parent 2d5ff1137d
commit f89e05e508
2 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backend/apis/nodejs/api_controller.js
View File

@ -338,7 +338,7 @@ async function deleteOrganizationPost(req, res){
const organizationPostIdToDelete = req.params.id; const organizationPostIdToDelete = req.params.id;
try{ try{
knex.transaction(async (trx) => { knex.transaction(async (trx) => {
// Check if user is allowed to delete the post // Check if user is allowed to delete the post (they must have created it)
const isOrganizationAdmin = await trx('OrganizationPost') const isOrganizationAdmin = await trx('OrganizationPost')
.join('OrganizationAdministrator', 'OrganizationPost.organization_id', 'OrganizationAdministrator.id_organization') .join('OrganizationAdministrator', 'OrganizationPost.organization_id', 'OrganizationAdministrator.id_organization')
.where('OrganizationPost.id', organizationPostIdToDelete) .where('OrganizationPost.id', organizationPostIdToDelete)
@ -386,6 +386,7 @@ async function addOrganizationAdmin(req, res){
} }
// We suppose that the database has Foreign Key constraints // We suppose that the database has Foreign Key constraints
// otherwise we should've checked whether person_id exists.
await knex('OrganizationAdministrator') await knex('OrganizationAdministrator')
.insert({ .insert({
id_person: req.body.person_id, id_person: req.body.person_id,
@ -409,6 +410,7 @@ async function removeOrganizationAdmin(req, res){
} }
// I can remove only myself from the list of administrators // I can remove only myself from the list of administrators
// TODO: What's the point for having 'body.person_id' then?
if(req.body.person_id != req.jwt.person_id){ if(req.body.person_id != req.jwt.person_id){
return res.status(403).json({ error : "Forbidden"}); return res.status(403).json({ error : "Forbidden"});
} }
@ -420,11 +422,9 @@ async function removeOrganizationAdmin(req, res){
.where('id_organization', req.body.organization_id) .where('id_organization', req.body.organization_id)
.del(); .del();
// Delete Organization if there are no admins left // Delete Organization if there are no admins left.
// Note: If the user instead deletes the entire profile, // TODO: If the user instead deletes their entire profile, the organization will not be deleted. Fix.
// the Organization will not be deleted. Fix. // TODO: Check what level of transaction we are using to avoid inconsistencies
// Note: Check what level of transaction we are using
// to avoid inconsistencies
const count = await trx('OrganizationAdministrator') const count = await trx('OrganizationAdministrator')
.count('id as count') .count('id as count')
.where('id', req.body.organization_id); .where('id', req.body.organization_id);

3
tutorials/3_async-await.js
View File

@ -28,7 +28,8 @@ async function f2() {
// Tutto il codice nella stessa funzione (o nello stesso blocco di codice) // Tutto il codice nella stessa funzione (o nello stesso blocco di codice)
// dopo "await" è da considerarsi nel "then()" di una promessa. Pertanto dopo // dopo "await" è da considerarsi nel "then()" di una promessa. Pertanto dopo
// await, il flusso di esecuzione va fuori a quel blocco di codice. Ad esempio considera // await (ma prima del completamento della Promise),
// il flusso di esecuzione va fuori a quel blocco di codice. Ad esempio considera
// il seguente esempio: // il seguente esempio:
async function exampleAsyncFunction() { async function exampleAsyncFunction() {
console.log('Before await'); console.log('Before await');