xfarrow/blink
0
0
Fork 0
mirror of https://github.com/xfarrow/blink synced 2025-06-27 09:03:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

PersonUpdate update

Browse Source 
It is now a PATCH rather than a PUT
This commit is contained in:
xfarrow
2024-03-07 11:15:33 +01:00
parent cc5dad330d
commit 9004ff47ad
1 changed files with 13 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
backend/apis/nodejs/src/routes/person_routes.js
View File

@@ -166,57 +166,51 @@ async function getMyself(req, res) {
} }
/** /**
* PUT request * PATCH request
* *
* Updates a Person's details. If some details are * Updates a Person's details. If some details are
* not present, they shall be ignored. An user can * not present, they shall be ignored. An user can
* only update themselves * only update themselves
* *
* Required field(s): none. Both old_password and * Required field(s): At least one. Both old_password and
* new_password if updating the password. * new_password if updating the password.
* *
*/ */
async function updatePerson(req, res) { async function updatePerson(req, res) {
const updatePerson = {}; const updatePerson = {};
if (req.body.display_name) { if (req.body.display_name != undefined) {
updatePerson.display_name = req.body.display_name; updatePerson.display_name = req.body.display_name;
} }
if (req.body.date_of_birth) { if (req.body.date_of_birth != undefined) {
if (validator.isPostgresDateFormatValid(req.body.date_of_birth)) {
updatePerson.date_of_birth = req.body.date_of_birth; updatePerson.date_of_birth = req.body.date_of_birth;
} else {
return res.status(400).json({
error: 'Date of birth format not valid. Please specify a YYYY-MM-DD date'
});
}
} }
if (req.body.available) { if (req.body.available != undefined) {
updatePerson.available = req.body.available; updatePerson.available = req.body.available;
} }
if (req.body.place_of_living) { if (req.body.place_of_living != undefined) {
updatePerson.place_of_living = req.body.place_of_living; updatePerson.place_of_living = req.body.place_of_living;
} }
if (req.body.about_me) { if (req.body.about_me != undefined) {
updatePerson.about_me = req.body.about_me; updatePerson.about_me = req.body.about_me;
} }
if (req.body.qualification) { if (req.body.qualification != undefined) {
updatePerson.qualification = req.body.qualification; updatePerson.qualification = req.body.qualification;
} }
// If we are tying to change password, the old password must be provided // If we are tying to change password, the old password must be provided
if (req.body.old_password || req.body.new_password) { if (req.body.old_password != undefined || req.body.new_password != undefined) {
if (!req.body.old_password) { if (req.body.old_password == undefined) {
return res.status(401).json({ return res.status(401).json({
error: 'The old password must be specified' error: 'The old password must be specified'
}); });
} }
if (!req.body.new_password) { if (req.body.new_password == undefined) {
return res.status(401).json({ return res.status(401).json({
error: 'The new password must be specified' error: 'The new password must be specified'
}); });
@@ -312,7 +306,7 @@ publicRoutes.get('/persons/me/activation', confirmActivation);
const protectedRoutes = express.Router(); // Routes requiring token const protectedRoutes = express.Router(); // Routes requiring token
protectedRoutes.use(jwtUtils.verifyToken); protectedRoutes.use(jwtUtils.verifyToken);
protectedRoutes.get('/persons/me', getMyself); protectedRoutes.get('/persons/me', getMyself);
protectedRoutes.put('/persons/me', updatePerson); protectedRoutes.patch('/persons/me', updatePerson);
protectedRoutes.delete('/persons/me', deletePerson); protectedRoutes.delete('/persons/me', deletePerson);
// Exporting a function // Exporting a function