vaultwarden/keyguard-app-Bitwarden-Vaultwarden
1
0
Fork 0
mirror of https://github.com/AChep/keyguard-app.git synced 2025-02-01 14:56:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Do not use Domain match detection for Android and iOS apps URIs

Browse Source
This commit is contained in:
Artem Chepurnoy 2024-12-22 12:04:22 +02:00
parent ed90a65b14
commit 6768a31800
No known key found for this signature in database
GPG Key ID: FAC37D0CF674043E
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/src/commonMain/kotlin/com/artemchep/keyguard/provider/bitwarden/usecase/CipherUrlCheck.kt
View File

@ -23,6 +23,7 @@ class CipherUrlCheckImpl(
) : CipherUrlCheck { ) : CipherUrlCheck {
companion object { companion object {
private const val PROTOCOL_ANDROID_APP = "androidapp://" private const val PROTOCOL_ANDROID_APP = "androidapp://"
private const val PROTOCOL_IOS_APP = "iosapp://"
} }
constructor(directDI: DirectDI) : this( constructor(directDI: DirectDI) : this(
@ -37,9 +38,14 @@ class CipherUrlCheckImpl(
): IO<Boolean> { ): IO<Boolean> {
return when (uri.match ?: defaultMatchDetection) { return when (uri.match ?: defaultMatchDetection) {
DSecret.Uri.MatchType.Domain -> { DSecret.Uri.MatchType.Domain -> {
when { val shouldUseHostMatchInstead = uri.uri.startsWith(PROTOCOL_ANDROID_APP) ||
uri.uri.startsWith(PROTOCOL_ANDROID_APP) -> ::checkUrlMatchByHost url.startsWith(PROTOCOL_ANDROID_APP) ||
else -> ::checkUrlMatchByDomain uri.uri.startsWith(PROTOCOL_IOS_APP) ||
url.startsWith(PROTOCOL_IOS_APP)
if (shouldUseHostMatchInstead) {
::checkUrlMatchByHost
} else {
::checkUrlMatchByDomain
} }
} }