mirror of
https://github.com/bitwarden/browser
synced 2025-01-28 12:09:36 +01:00
4074c2a45f
* [bug] Fully initilize environmentUrls default value We want the full environmentUrls object to be saved to storage with null values as an indicator of using BW cloud. Currently the initilization behavior creates an empty object instead. Setting property values returns the correct behavior. * [bug] Return the correct environmentUrls when scaffloging a new account To allow for setting environmentUrls before an account is created we save that value as a global setting and then apply it to any newly authed accounts. There is a bug that will instead save the urls used by the previous logged in account, making account switching with multiple servers cause errors. This commit resolves this by specifically getting environementUrls from global state when creating a new account
Bitwarden JavaScript Library
Common code referenced across Bitwarden JavaScript projects.
Requirements
- Node.js v16.13.1 or greater
- NPM v8
- Git
- node-gyp
Windows
- Microsoft Build Tools 2015 in Visual Studio Installer
- Windows 10 SDK 17134 either by downloading it seperately or through the Visual Studio Installer.
Prettier
We recently migrated to using Prettier as code formatter. All previous branches will need to updated to avoid large merge conflicts using the following steps:
- Check out your local Branch
- Run
git merge 8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd - Resolve any merge conflicts, commit.
- Run
npm run prettier - Commit
- Run
git merge -Xours 193434461dbd9c48fe5dcbad95693470aec422ac - Push
Git blame
We also recommend that you configure git to ignore the prettier revision using:
git config blame.ignoreRevsFile .git-blame-ignore-revs