mirror of
https://github.com/bitwarden/browser
synced 2024-12-18 12:22:59 +01:00
1fdc6629e3
* PM-3859 - Desktop App Comp - Build lock mechanism for update app menu which doesn't try to update the menu for users who are being logged out which was causing errors (primary scenario was triggered by logging in on desktop with a TDE user w/out a MP, triggering a sync, then hitting the command to lock the vault right after which would trigger a log out while the sync was still in process. Then, while the log out was in process, the sync would try and trigger an update to the app menu but it would error as some of the user's state had already been cleaned up) * PM-3859 - App comp - remove use of promise.all to prevent any race conditions from causing intermittent logout errors with state being cleared and then values trying to be set on the cleared state (I observed setMasterKey get called after state account.keys was cleared - received error when attempting to set value on undefined). * PM-3859 - Desktop Vault Items Component - on log out, if you were on the vault screen, the loss of focus on the vault search text box would trigger a search 200 ms after log out had been triggered. This would eventually attempt to set an undefined master key (VaultItemsComponent.doSearch() --> cipherService.getAllDecrypted() --> cryptoService.getUserKeyWithLegacySupport() --> cryptoService.getMasterKey() --> cryptoService.setMasterKey()). However, at this point, the account had been cleared as part of the log out process and an error would be thrown in the state service for trying to set account.keys.masterKey to undefined when the account and account.keys were undefined. These changes prevent the search from firing until the value changes and also prevents setMasterKey from being called if it is undefined. |
||
|---|---|---|
| .. | ||
| app | ||
| auth | ||
| images | ||
| locales | ||
| main | ||
| models | ||
| platform | ||
| proxy | ||
| scss | ||
| services | ||
| types | ||
| vault/app | ||
| entry.ts | ||
| global.d.ts | ||
| index.html | ||
| main.ts | ||
| package-lock.json | ||
| package.json | ||
| preload.ts | ||
| utils.spec.ts | ||
| utils.ts | ||