mirror of
https://github.com/bitwarden/browser
synced 2024-12-28 10:51:42 +01:00
fff412665f
* Run clippy and rustfmt on CI * Error on warnings and fix a couple of missed lints * Move import inside function * Fix unix lints * Fix windows lints * Missed some async tests * Remove unneeded reference
89 lines
2.3 KiB
YAML
89 lines
2.3 KiB
YAML
name: Lint
|
|
|
|
on:
|
|
push:
|
|
branches-ignore:
|
|
- 'l10n_master'
|
|
- 'cf-pages'
|
|
paths-ignore:
|
|
- '.github/workflows/**'
|
|
workflow_dispatch:
|
|
inputs: {}
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
|
|
jobs:
|
|
lint:
|
|
name: Lint
|
|
runs-on: ubuntu-22.04
|
|
steps:
|
|
- name: Checkout repo
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
|
|
|
- name: Lint filenames (no capital characters)
|
|
run: |
|
|
find . -type f,d -name "*[[:upper:]]*" \
|
|
! -path "./node_modules/*" \
|
|
! -path "./coverage/*" \
|
|
! -path "*/dist/*" \
|
|
! -path "*/build/*" \
|
|
! -path "*/target/*" \
|
|
! -path "./.git/*" \
|
|
! -path "*/.DS_Store" \
|
|
! -path "*/*locales/*" \
|
|
! -path "./.github/*" \
|
|
! -path "*/Cargo.toml" \
|
|
! -path "*/Cargo.lock" \
|
|
! -path "./apps/desktop/macos/*" \
|
|
> tmp.txt
|
|
diff <(sort .github/whitelist-capital-letters.txt) <(sort tmp.txt)
|
|
|
|
- name: Get Node Version
|
|
id: retrieve-node-version
|
|
run: |
|
|
NODE_NVMRC=$(cat .nvmrc)
|
|
NODE_VERSION=${NODE_NVMRC/v/''}
|
|
echo "node_version=$NODE_VERSION" >> $GITHUB_OUTPUT
|
|
|
|
- name: Set up Node
|
|
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
|
|
with:
|
|
cache: 'npm'
|
|
cache-dependency-path: '**/package-lock.json'
|
|
node-version: ${{ steps.retrieve-node-version.outputs.node_version }}
|
|
|
|
- name: Run linter
|
|
run: |
|
|
npm ci
|
|
npm run lint
|
|
|
|
rust:
|
|
name: Run Rust lint on ${{ matrix.os }}
|
|
runs-on: ${{ matrix.os || 'ubuntu-latest' }}
|
|
|
|
strategy:
|
|
matrix:
|
|
os:
|
|
- ubuntu-latest
|
|
- macos-latest
|
|
- windows-latest
|
|
|
|
steps:
|
|
- name: Checkout repo
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
|
|
|
- name: Check Rust version
|
|
run: rustup --version
|
|
|
|
- name: Run cargo fmt
|
|
working-directory: ./apps/desktop/desktop_native
|
|
run: cargo fmt --check
|
|
|
|
- name: Run Clippy
|
|
working-directory: ./apps/desktop/desktop_native
|
|
run: cargo clippy --all-features --tests
|
|
env:
|
|
RUSTFLAGS: "-D warnings"
|