Commit Graph

6297 Commits

Author SHA1 Message Date
Patrick H. Lauke fd434dfed8
Remove underline from focused buttons/controls (#2651) 2022-05-09 10:56:17 +02:00
Daniel James Smith 3db2848cac
Fix lint issues (#2656) 2022-05-07 22:30:57 +02:00
Daniel James Smith a0caa89bf0
Update issues link to our new repos (#2655) 2022-05-07 19:52:17 +02:00
Patrick H. Lauke a4a6f12120
[PS-557] Browser: Accessibility - change send list controls to buttons, make them keyboard-operable, improve screen reader experience (#2540)
* Change send list controls to buttons

make them keyboard focusable/operable

* Fix width/display of sends

* Make `.row-btn.disabled` also apply to natively `disabled` buttons without need for class

* Change accessible name for send group to use the send's name, not generic "Edit item" title
2022-05-07 19:51:37 +02:00
Patrick H. Lauke 5e0f8bd870
Fix vertical alignment of expandable header chevron (#2652) 2022-05-07 19:42:20 +02:00
Patrick H. Lauke 5bd681a6dd
Add `aria-pressed` to URI toggles, remove `appBlurClick` (#2654) 2022-05-07 17:53:45 +02:00
Daniel James Smith 107ba56fbc
Crowdin-Pull: Fix paths in browsers crowdin.yml (#2641) 2022-05-06 23:05:59 +02:00
Micaiah Martin 93d2ab743c
Update provisioning files in desktop build (#2647) 2022-05-06 11:20:10 -05:00
Kyle Spearrin 5e731fb328
add appApiAction to username generation (#2549) 2022-05-06 09:07:30 -04:00
Oscar Hinton c7cd864524
Fix linting on master (#2643) 2022-05-06 13:27:00 +02:00
Vince Grassia db02c2415b
Fix build number base (#2638) 2022-05-05 16:56:45 -04:00
Vince Grassia e6fcdde29c
Fix Desktop Build Workflow (#2637) 2022-05-05 16:20:16 -04:00
Oscar Hinton e08b65f62b
Add instructions on how to migrate desktop PRs (#2636)
* Add instructions on how to migrate desktop PRs

* Fix instructions
2022-05-05 21:59:17 +02:00
Oscar Hinton 55d2a6b503
[EC-184] Desktop cleanup (#2553) 2022-05-05 19:03:56 +02:00
Oscar Hinton b7b7ed808f
Merge pull request #2551 from bitwarden/desktop 2022-05-05 18:25:35 +02:00
Hinton 7712ca6fa5 Merge remote-tracking branch 'desktop/mono-repo-prep' into desktop
# Conflicts:
#	.gitmodules
2022-05-05 17:22:56 +02:00
Hinton 28bc4113b9 Move desktop into apps/desktop 2022-05-05 17:20:34 +02:00
Jake Fink 9852f2ec22
[PS-106] update jslib (#1530) 2022-05-05 17:11:39 +02:00
Oscar Hinton 912f3b0d46
Rename repo to clients (#2548) 2022-05-05 16:54:48 +02:00
Micaiah Martin fec6838f90
Updated publisher to use generic (#1529) 2022-05-05 09:51:17 -05:00
Patrick H. Lauke 55a9403ee3
[PS-540] Accessibility: remove `appBlurClick`, add `aria-expanded` to cog options, links to buttons, fix unsufficient focus indication (#1514) 2022-05-05 16:36:46 +02:00
Oscar Hinton 817856bc82
Rust improvements (#1495) 2022-05-05 16:01:09 +02:00
Micaiah Martin 508292ae39
Patched build workflow (#1527) 2022-05-04 13:59:36 -05:00
Micaiah Martin 00fd2ec03f
Update publish settings to use S3 (#1521)
* Update publish settings to use S3

* Fix formatting

* Added endpoint with new domain

* Updated S3 publisher config

* added npm CD commands for workflow later.

* Updated release workflow to publish to S3

* testing release

* Reduce aws cli output

* Remove test

* Finalize release workflow
- Reverted back testing logic
- Removed dry run check for GH release since it creates it as a draf anyways
- Removed artifact_url env as it's no longer needed.

* Remove testing values

* Merge Master

* Added endpoint in config
2022-05-04 11:19:04 -04:00
Vince Grassia 186c16b577
Update Browser Build Workflow (#2544) 2022-05-04 10:59:05 -04:00
Daniel James Smith eb4b9bc7b0
Fix Crowdin pull action (#2542)
* Rename crowdin-pull.yml to crowdin-pull-browser.yml

* Fix path to crowdin config for pull action
2022-05-04 14:37:45 +02:00
Daniel James Smith 63c606d463
Fix directory for browser's Crowdin pull config (#2541) 2022-05-04 14:37:24 +02:00
Patrick H. Lauke 5434d7cbbd
Minor: correct markdown for image/alt (#2539) 2022-05-04 13:45:09 +02:00
Vince Grassia 7d25bf6904
Remove lint job from build workflows (#2538) 2022-05-03 16:35:35 -04:00
Oscar Hinton c1cc5a0814
[EC-183] Move eslint and prettier to project root (#2536) 2022-05-03 21:45:37 +02:00
Oscar Hinton 06f72b90d7
[EC-183] Fix the readme badge (#2535) 2022-05-03 20:46:25 +02:00
Oscar Hinton 04ab35f69b
[EC-183] Bump jslib to match the expected version (#2534) 2022-05-03 20:25:18 +02:00
Oscar Hinton e639f3c40c
[EC-183] Mono Repository - Browser pipelines (#2533)
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2022-05-03 20:01:37 +02:00
Oscar Hinton 3aa7570020
[EC-183] Mono Repository - Readme (#2532)
* Update GH issue templates, contributing and readme
2022-05-03 19:47:56 +02:00
Oscar Hinton 7fe51f83da
[EC-183] Mono Repository - Browser (#2531) 2022-05-03 19:38:55 +02:00
Patrick H. Lauke 11ef07fbce
[PS-517] Normalise/fix button focus outlines (#2529) 2022-05-03 11:31:04 +02:00
Oscar Hinton 9a954710d9
Add keytar to externals (#1520) 2022-05-03 11:03:21 +02:00
Oscar Hinton a81c3c95a4
[CP-30] Add credit card pipe (#1517) 2022-05-02 19:45:24 +02:00
Kyle Spearrin 289ef6a13f
Forwarded email providers to username generator (#2528)
* Forwarded email providers to username generator

* update jslib
2022-05-02 13:23:19 -04:00
Oscar Hinton 99f6afbf5f
[CP-30] Use the CreditCardNumberPipe (#2527) 2022-05-02 17:02:09 +02:00
Kyle Spearrin 75470dc169
Forwarded email providers to username generator (#1511)
* forward email username generation

* update jslib
2022-05-02 10:57:01 -04:00
Oscar Hinton 18b5e4adfd
[EC-163] Undo move to rust implementation (#1509) 2022-05-02 12:39:38 +02:00
Thomas Rittson 6bd5d579af
[PS-74] Fix user authentication state checks (#2481)
* Replace vaultTimeoutService.isLocked
2022-05-02 07:57:40 +10:00
Patrick H. Lauke 0396d682b1
Change links to buttons, expose `aria-pressed` for toggles, add `aria-expanded` to send view's "Options" (#1437)
* Change links to buttons, expose `aria-pressed` for toggles

- also make existing `<a routerLink...>` type controls keyboard focusable with the addition of `tabindex="0"`

* Correctly set aria-pressed

now that I have a working build environment, could verify correct way to set this with my limited Angular knowledge

* Change more links to buttons, initial style changes

* Fix layout of <button> elements with .box-content-row

* Update jslib submodule

* Add `aria-expanded` to the send view's "Show options" expand/collapse control

* Fix position of "Edit" pencil when hovering over folders

* Update jslib

* Change sends list links to buttons

* Add `aria-pressed` to vault and send list buttons

Programmatically denote which of the buttons is currently active/shown in the right-most panel

* Fix incorrect "Options" expand/collapse button in add-edit view

Currently, that buttons lacks an accName because the "Options" text is outside of it.

* Add `aria-pressed` to the send left-hand column filters

* Simplify base, list, and vault styles

Since links are now buttons, no need to double up selectors for both types of elements. No need to double-up theming in base, as this also causes incorrect "x" in toasts.

* Remove unnecessary `position:relative`

Fixes issue with cut-off focus outlines, has no other adverse effect

* Fix styling for last child of action buttons

Old approach of making right padding smaller results in unsightly, off-center icon (noticeable when focus outline is visible). This visually remains the same, but reduces right-hand margin instead.
2022-04-30 16:09:41 +02:00
Thomas Rittson ef60112855
[PS-74] Fix user authentication state checks (#1464)
* Use new authStatus method, clean up account switcher

* Update naming

* update jslib
2022-04-30 09:16:46 +10:00
Thomas Rittson b467206448
[EC-156] [BEEEP] Remove factory providers in Angular DI (#1496)
* Use tokens

* Use initService

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-04-29 17:48:44 +10:00
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Patrick H. Lauke 9df22d3601
[PS-329] A11y: make view, copy, etc controls for ciphers/items keyboard focusable/operable, add screen reader improvements (#2507) 2022-04-28 18:24:13 +02:00
Nils Fahldieck 55b301c267
Widen the sidebar to 600px max (#1503)
This implements the suggestion by MrBlack of the community forums in: https://community.bitwarden.com/t/manually-resizable-sidebar-columns-in-bitwarden-desktop-app/31909/3
2022-04-27 22:10:11 +02:00
Thomas Rittson 17c3fdd68b
[EC-157] [BEEEP] Remove factory providers in Angular DI (#2516)
* Use initService

* Use InjectionTokens

* Update to use new locked and logout callbacks
2022-04-27 09:11:39 +10:00