The DI refactor created a bad initlizer for SystemService that left out the reload callback.
This callback is null in prod, so I just set up a factory initlizer that used null for the callback value.
This fixes a bug causing clipboard clearing to not function, as platformUtilsService was not correctly injected.
* Create testing framework for CLI
- Need to add tsconfig for specs to convert module format and add spec
dir to output
- Use jasmine-ts to test
expected dev cycle would be to have two watchers, one for jslib
and one for CLI tests. We could add jslib tests to this jasmine config,
but it feels wrong to test a submodule
* Run prettier
* Add tests to build pipeline
* Include required package
* Add placeholder test
* Run prettier
* Add nodemon and fix watch
* Design changes to settings menu
* Remove black border on settings headers
* Pull in jslib
* Only load account related settings when authed
* Hide account related settings when not authed
* Change settings titles
* Changes discussed with Danielle
* Move Key Connector check to subclass
* Move authService.logout call to main program
* Move Key Connector migration check to unlock command
* Use get/setConvertAccountRequired flag
* Move Key Connector convert to own command, set usesKeyConnector after conversion
* Remove KC conversion check from syncCommand, fix callback
* Make class service private
* Fix naming convention
* Update jslib and deps
With the account switching work a header was added to the desktop app that new acts as a home for the mac window controls.
Previously we needed a special home for these controls, but since moving them we are not just creating empty space.
Removing this class and the divs that use it corrects the behavior.
* [dep] Implement new StateService factory parameter from jslib
* [bug] Ensure setLastActive uses the correct userId
Sometimes, because of how often it fires, setLastActive can cause accounts to override each other. To make sure the correct userId is always used we now subscribe to activeUser in the appComponent and pass that value into any setLastActive calls.
* [bug] Show loader when logging out
When logging out of a large vault the application can appear to hang. This commit turns on the app component loader while logout is doing work.
* [bug] Stop tracking activity without an active user
* [style] Ran prettier
* [chore] Update jslib
* [Bug] VaultTimeout incorrectly defaults to "Never"
The default desktop vault timeout value is "On Restart", but there is no default set for this in the state service and account model.
This commit extends the StateService and Account model to consider the special vault timeout default requirements needed for desktop.
* [style] Lint fixes
* [chore] Update jslib
* [bug] Pull serverUrl directly from stateService for the account switcher
Create a small extended Account model for handling the switchers server url, and pull environment urls from disk where they actually live
* [refactor] Add a message handler for switching accounts
* This allows for logic reuse between manually switching accounts and automatically switching accounts on login
* This commit also adds a loading spinner to app root while syncing after a switch
* [bug] Remove vertical scrollbar
* An old styling fix to add extra height and padding seems to be now creating an unecassary scroll bar. It is likely that since making more use of flexbox for our containers that this issue has been resolved without the manually added extra hight & padding
* [refactor] Turn down activity monitoring
Saving last activity is a disk call, and we currently do this a lot more than is necassary. For example:
* We track mousedown & click, which is redundant
* We track every mouse movement regardless of if an action is taken. This seems inappropriate for use in locking behavior.
* [bug] Address potential race condition when locking
Sometimes when swapping between an unlocked account and a locked account a race condition occurs that swaps the user but doesn't redirect to the lock screen
This commit just adds some awaits and restructures lock order of operations to be more in line with other message handlers
* [refactor] Change click event to mousedown event for the account switcher
This is simply a little snappier, and ensures we stay ahead of change detection and don't get stuck not properly interpreting the action
* [chore] Update jslib
* [chore] Linter fixes
* [chore] Linter fixes
* [chore] Update jslib
* [chore] Update jslib
* aligned dark theme variables to the new WV dark theme
* Update plugins.scss
updated toast close button color
* Run prettier on plugins.scss
Co-authored-by: Daniel James Smith <djsmith@web.de>
Addison Beck
Oscar Hinton
Robyn MacCallum
Matt Gibson
Robyn MacCallum
Daniel James Smith
github-actions[bot]
Thomas Rittson
Kyle Spearrin
Vince Grassia
Andrew Marquez
Ivan Kovnatsky
Danielle Flinn