1
0
mirror of https://github.com/bitwarden/browser synced 2024-12-26 09:54:35 +01:00
Commit Graph

80 Commits

Author SHA1 Message Date
Oscar Hinton
193434461d
Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
Addison Beck
f90b3456d5
[Account Switching] [Feature] Allow clients to store data for more than one user (#491)
* [refactor] Extract, rename, and expand StorageServiceOptions

* Pulled StorageServiceOptions into its own file
* Renamed StorageServiceOptions to StorageOptions
* Pulled KeySuffixOpptions into its own file
* Converted KeySuffixOptions into an enum from a union type

* [refactor] Expand StateService into a full coverage storage proxy

* Expand StateService to allow it to manage all data points of the application state regardless of memory.
* Expand StateService to allow for storing and managing multiple accounts

* [refactor] Create helper services for managing organization and provider state data

* [refactor] Implement StateService across service layer

* Remove service level variables used for in memory data storage and replaced with calls to StateService
* Remove direct calls to StorageService in favor of using StateService as a proxy

* [feature] Implement account switching capable services across components and processes

* Replace calls to StorageService and deprecated services with calls to a StateService

* [chore] Remove unused services

Several services are no longer in use because of the expanded state service. These have simply been removed.

* [bug] Add loginRedirect to the account model

* [bug] Add awaits to newly async calls in TokenService

* [bug] Add several missing awaits

* [bug] Add state service handlers for AutoConfirmFingerprint

* [bug] Move TwoFactorToken to global state

* Update unauth-guard.service.ts

Add back return true

* [refactor] Slim down the boilerplate needed to manage options on StateService calls

* [bug] Allow the lock message handler to manipulate a specific acount

* [bug] Add missing await to auth guard

* [bug] Adjust state scope of several biometric data points

* [bug] Ensure vault locking logic can operate over non-active accounts

* [style] Fix lint complaints

* [bug] Move disableFavicon to global state

* [refactor] Remove an unecassary parameter from a StorageOptions instance

* [bug] Ensure HtmlStorageService paths are accounted for in StateService

* [feature] Add a server url helper to the account model for the account switcher

* [refactor] Remove some unused getters from the account model

* [bug] Ensure locking and logging out can function over any user

* Fix account getting set to null in getAccountFromDisk

* [bug] Ensure lock component is always working with the latest active account in state

* [chore] Update recent KeyConnector changes to use stateService

* [style] Fix lint complaints

* [chore] Resolve TokenService merge issues from KeyConnector

* [bug] Add missing service arguement

* [bug] Correct several default storage option types

* [bug] Check for the right key in hasEncKey

* [bug] Add enableFullWidth to the account model

* [style] Fix lint complaints

* [review] Revist remember email

* [refactor] Remove RememberEmail from state

* setDisableFavicon to correct storage location

* [bug] Convert vault lock loop returns into continues to not skip secondary accounts

* [review] Sorted state service methods

* [bug] Correct neverDomains type on the account model

* [review] Rename stateService.purge to stateService.clean

* [review] [refactor] Extract lock refresh logic to a load function

* [review] [refactor] Extract some timeout logic to dedicated functions

* [review] [refactor] Move AuthenticationStatus to a dedicated file

* [review] [refactor] Rename Globals to GlobalState

* [style] Fix lint complaints

* [review] Remove unused global state property for decodedToken

* [review] [bug] Adjust state scope for OrganizationInvitation

* [review] [bug] Put back the homepage variable in lock guard

* [review] Un-try-catch the window creation function

* Revert "[review] [bug] Adjust state scope for OrganizationInvitation"

This reverts commit caa4574a65d9d0c3573a7529ed2221764fd55497.

* [bug] Change || to && in recent vault timeout refactor

* [bug] Keep up with entire state in storage instead of just accounts and globals

Not having access to the last active user was creating issues across clients when restarting the process.
For example: when refreshing the page on web we no longer maintain an understanding of who is logged in.

To resolve this I converted all storage save operations to get and save an entire state object, instead of specifying accounts and globals.
This allows for more flexible saving, like saving activeUserId as a top level storage item.

* [style] Fix lint complaints

* Revert "[bug] Keep up with entire state in storage instead of just accounts and globals"

This reverts commit e8970725be472386358c1e2f06f53663c4979e0e.

* [bug] Initialize GlobalState by default

* [bug] Only get key hash from storage

* [bug] Remove settings storage location overrides

* [bug] Only save accessToken to storage

* [refactor] Remove unecassary argements from electron crypto state calls

* [bug] Ensure keys and tokens load and save to the right locations for web

* [style] Fix lint complaints

* [bug] Remove keySuffix storage option and split uses into unique methods

The keySuffix options don't work with saving serialized json as a storage object - use cases simply overwrite each other in state.
This commit breaks Auto and Biometric keys into distinct storage items and adjusts logic accordingly.

* [bug] Add default vault timeouts to new accounts

* [bug] Save appId as a top level storage item

* [bug] Add missing await to timeout logic

* [bug] Adjust state scope for everBeenUnlocked

* [bug] Clear access tokens when loading account state from disk

* [bug] Adjust theme to be a global state item

* [bug] Adjust null checking for window in state

* [bug] Correct getGlobals not pulling from the stored state item

* [bug] Null check in memory account before claiming it has a userId

* [bug] Scaffold secure storage service when building storage objects on init

* [bug] Adjusted state scope of event collection

* [bug] Adjusted state scope of vault timeout and action

* [bug] Grab account from normal storage if secure storage is requested but does not exist

* [bug] Create a State if one is requested from memory before it exists

* [bug] Ensure all storage locations are cleared on state clean

* [style] Fix lint complaints

* [bug] Remove uneeded clearing of access token

* [bug] Reset tokens when toggling

* [refactor] Split up the Account model

Until this point the account model has been very flat, holding many kinds of data.

In order to be able to prune data at appropriate times, for example clearing keys at logout without clearing QoL settings like locale,
the Account model has been divided into logical chunks.

* [bug] Correct the serverUrl helpers return

* Fix sends always coming back as empty in browser

* Get settings properly (I think)

* [bug] Fix lint error

* [bug] Add missing await to identity token refresh

This was causing weird behavior in web that was creating a lot of 429s

* [bug] Scaffold memory storage for web

Not properly creating storage objects on signin was creating weird behavior when logging out, locking, and logging back in.
Namely, encrypted data that was recently synced had nowhere to save to and was lost.

* [bug] Implement better null handling in a few places for retrieving state

* [bug] Update correct storage locations on account removal

* [bug] Added missing awaits to lock component

* [bug] Reload lock component on account switching vs. account update

* [bug] Store master keys correctly

* [bug] Move some biometrics storage items to global state

* [feature] Add platform helper isMac()

* [refactor] Comment emphasis and call order refresh

* [refactor] Remove unecassary using

* [bug] Relocate authenticationStatus check logic to component

* [bug] Stop not clearing everything on state clean

* [style] Fix lint complaints

* [bug] Correct mismatched uses of encrypted and decrypted pin states

* Add browser specific state classes and methods

* lint fixes

* [bug] Migrate existing persistant data to new schema

* [style] Fix lint complaints

* [bug] Dont clear settings on state clean

* [bug] Maintain the right storage items on logout

* [chore] resolve issues from merge

* [bug] Resolve settings clearing on lock

* [chore] Added a comment

* [review] fromatting for code review

* Revert browser state items

Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
2021-12-13 11:15:16 -05:00
Oscar Hinton
6a179ab2df
Bump angular to 12. (#571) 2021-12-09 15:00:26 +01:00
Oscar Hinton
a6b95b15e3
Add toastr component (#568) 2021-12-07 19:15:56 +01:00
Oscar Hinton
5db94cc9d0
BEEEP: Move DI logic to jslib (#565) 2021-12-02 18:40:34 +00:00
Thomas Rittson
78429aa720
Change ngZone from private to protected (#567)
* Change ngZone from private to protected

* Remove unneeded file
2021-11-29 09:52:23 +10:00
Yuan Chao
920ec05fbb
Fix cursor location changing issue on toggle password (#561) 2021-11-29 07:30:32 +10:00
Jake Fink
340a79bfe6
reset ownershipOptions on init (#563) 2021-11-24 09:01:38 -05:00
Oscar Hinton
f4c66b2c8c
Add support for hiding input on lock screen if using key connector (#560) 2021-11-19 16:48:42 +01:00
Oscar Hinton
9b7aaa272d
Add confirm identity helper text to password in verify component (#554) 2021-11-18 16:24:15 +01:00
Thomas Rittson
fc0d624621
[Key Connector] Hide "Master Pass On Restart" prompt when setting pin (#556)
* Disable Master Pass on Restart for Key Connector

* Fix linting
2021-11-18 21:20:55 +10:00
Oscar Hinton
ea9a8b979d
Update verify master password component (#553) 2021-11-17 11:57:05 +01:00
Thomas Rittson
720967475b
Update base export component for userVerificationService changes (#552)
* Use new try/catch pattern in export.component

* Set initial value in VerifyMasterPass component
2021-11-16 19:43:37 +10:00
Thomas Rittson
386903f5a9
[Key Connector] QA fixes for CLI and Desktop (#544)
* Make UserVerificationService compatible with CLI

* Refactor error handling

* Fix i18n key name

* Add apiUseKeyConnector flag to TokenResponse

* Always require keyConnectorUrl to be passed in

* Throw errors in userVerificationService

* Use requestOTP in UserVerificationService

* Remove unused deps

* Fix linting
2021-11-16 07:53:57 +10:00
Thomas Rittson
e02e663ce1
[Linked Fields] Fix QA feedback (#542)
* Fix bug overwriting custom field types

* Add linkedId to export model for CLI
2021-11-12 05:59:01 +10:00
Oscar Hinton
8f177e2d3a
Add support for requesting and using otp for verifying some requests (#527)
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2021-11-09 17:01:22 +01:00
Thomas Rittson
99ff3feb53
[Linked fields] Fix change detection on cipherType (#536)
* Fix bug that clears linkedId values when editing

* Add null check

* Fix linting
2021-11-09 21:57:33 +10:00
Thomas Rittson
2db9e1ce0d
[Linked fields] Reset linkedIds if cipher type changes (#535)
* Reset linkedIds if cipher type changes

* Only reset linkedId if !editmode
2021-11-04 07:24:45 +10:00
Thomas Rittson
dbda39e10f
Add Linked Field as custom field type (#431)
* Basic proof of concept of Linked custom fields

* Linked Fields for all cipher types, use dropdown

* Move linkedFieldOptions to view models

* Move add-edit custom fields to own component

* Fix change handling if cipherType changes

* Use Field.LinkedId to store linked field info

* Refactor accessors in cipherView for type safety

* Use map for linkedFieldOptions

* Refactor: use decorators to record linkable info

* Add ItemView

* Use enums for linked field ids

* Add union type for linkedId enums, add jsdoc comment

* Use parameter properties for linkedFieldOption

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>

* Fix type casting

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2021-11-03 08:03:37 +10:00
Robyn MacCallum
031cbff556
Add role="alert" to callouts only when enforceAlert is passed (#528)
* Add role="alert" to callouts when enforceAlert is passed

* Remove ElementRef and do a different way

* Rename input variable
2021-10-26 11:41:46 -04:00
Oscar Hinton
71f8ef601f
Add support for crypto agent (#520) 2021-10-25 18:21:40 +02:00
Thomas Rittson
24fe836032
Fixes for dynamic modal a11y (#518)
* Do not close modal if click finishes on background

* Trap tab focus in modals, use ESC to close modal

* Fix Angular change detection errors in modals

* Reset focus on next modal after closing modal

* Minor fixes and linting

* Attach focusTrap to modal-dialog element

* Change mousedown event back to click

* Make topModal private

* Add new div for dismissing modal by clicking bg

* Focus element in modal if no autoFocus directive

* Use backdrop for dismissal

* Fix typo
2021-10-21 08:13:37 +10:00
Oscar Hinton
f09fb69882
Remove empty catch blocks, and update tslint rule (#513) 2021-10-19 10:32:14 +02:00
Thomas Rittson
a20e935268
Use rxjs first instead of unsubscribe (#516) 2021-10-14 10:27:52 +10:00
Oscar Hinton
56233e4002
Move Avatar component to jslib (#496) 2021-10-13 09:55:19 +02:00
Vincent Salucci
542852a3be
[Reset Password] BUG - Update local policies for enforcement (#510) 2021-10-08 11:18:25 -05:00
Addison Beck
e69425cb41
[bug] Set a default value for custom send deletion times in the safari extension (#511)
* [bug] Set a default value for custom send deletion times in the safari extension

* [review] tomorrow -> nextWeek for default custom send deletion time values
2021-10-08 10:42:22 -04:00
Thomas Rittson
64bc115109
Set default ownership if Personal Ownership policy applies (#509) 2021-10-08 07:15:02 +10:00
Oscar Hinton
bfa9a1e1bc
Remove Business Portal, add SSO configuration models (#506) 2021-10-06 19:36:20 +02:00
Oscar Hinton
91b73fa777
Resolve biometric error dissapearing before being read (#501) 2021-09-28 16:23:25 +02:00
Oscar Hinton
206ef610d0
Bump signalr to 5.0.10 (#502) 2021-09-28 15:47:19 +02:00
Oscar Hinton
2c892eb3a2
Add webfonts (#500) 2021-09-24 15:36:51 +02:00
Thomas Rittson
b7429b0c0c
Fix import statements (#494) 2021-09-20 17:49:59 +10:00
Thomas Rittson
25afe79714
Fix import statements (#493) 2021-09-20 17:23:00 +10:00
Thomas Rittson
0f984efd61
Move custom fields to separate components (#489)
* Move add-edit custom fields to own component

* Fix linting

* Fix change handling if cipherType changes

* Removed linked fields work

* Move view custom fields to own component

* Remove unnecessary imports

* Remove old logic from component
2021-09-20 10:36:40 +10:00
Vincent Salucci
16e998e664
[Reset Password v1] Refactor ForcePasswordReset into AuthResult (#481) 2021-09-17 10:53:50 -05:00
Oscar Hinton
83548a6753
Remove deprecated index.ts (#490)
* Remove deprecated index.ts

* Update tests
2021-09-17 14:57:31 +02:00
Vincent Salucci
da132217da
[SSO Auto Enroll] Auto Enroll status retrieval (#486)
* [SSO Auto Enroll] Auto Enroll status retrieval

* Fixed import order

* Updated object property
2021-09-15 12:54:44 -05:00
Oscar Hinton
ee1ea922a9
Disable Private Vault Export Policy (#482) 2021-09-14 16:32:06 +02:00
Thomas Rittson
a85c45a34e
Use a modal to set the unlock pin (#477)
* Move set pin logic to its own modal

* Fix method name and default value
2021-09-10 08:57:32 +10:00
Oscar Hinton
32774561f3
Add MaximumVaultTimeout policy type (#480) 2021-09-09 17:05:40 +02:00
Oscar Hinton
bbe8d3df48
Revert "Vault Timeout Policy (#474)" (#479)
This reverts commit bba2812fdd.
2021-09-08 23:06:42 +02:00
Oscar Hinton
bba2812fdd
Vault Timeout Policy (#474) 2021-09-08 22:02:19 +02:00
Vincent Salucci
ef743ea8ca
[SSO] Set password auto enroll update (#472)
* [SSO/Auto Enroll] Set Password enrolls new user

* Fixed typo

* Linter updates

* Cleanup // Constructor for SetPasswordRequest
2021-09-03 14:49:03 -05:00
Thomas Rittson
1c1f080acf
Fix undefined variable error in desktop (#470) 2021-09-01 07:19:16 +10:00
Matt Gibson
d3ee08abb6
Log full error for better debugging support (#473) 2021-08-31 14:59:54 -05:00
Oscar Hinton
d50531886b
Add support for setting up component factory resolvers in modal service (#471) 2021-08-31 16:35:20 +02:00
Thomas Rittson
30419a625f
Move policy checks within policyService (#466)
* Move policy logic within policyService

* Remove unneeded import

* Clean up unused code

* Fix linting

* Enforce policies from accepting org invite

* Only exempt owner or admin from policies

* Use canManagePolicies as exemption criteria

* Make orgUser status check more semantic

Co-authored-by: Addison Beck <abeck@bitwarden.com>

Co-authored-by: Addison Beck <abeck@bitwarden.com>
2021-08-31 06:52:57 +10:00
Vincent Salucci
f02720a1c6
[Callout] Added pstyling class (#468) 2021-08-27 17:05:02 -05:00
Oscar Hinton
daa4f6f9a6
Dynamic Modals (#417)
* Move backdrop and click handler to modal service since they should not be used in web

* Add support for opening modals using ViewContainerRef
2021-08-26 10:04:29 +02:00