Commit Graph

15676 Commits

Author SHA1 Message Date
Nick Krantz cf34f66156
[PM-9922] Custom Fields - Focus Management (#10187)
* use zip to ensure both query changes and new items have been added

* query for the label directly rather than the associated one

there is only one label and the checkbox is wrapped in the label
2024-07-22 12:42:31 -05:00
renovate[bot] 730142f612
[deps] Autofill: Update tldts to v6.1.33 (#10203)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-22 12:21:24 -04:00
renovate[bot] 98b03e48c6
[deps] Autofill: Update rimraf to v5.0.9 (#10202)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-22 11:24:12 -04:00
Nick Krantz 8a86a699ff
[PM-9952][PM-9954] Minor assign collection fixes (#10190)
* disable organization selector when only one org is selected

* break long org names in assign collections copy

- applicable more in the browser implementation

* add `title` to each select option so a mouse over presents the name

- more applicable to the browser extension where names can overflow

* truncate options that overflow a select

* set max width of form fields to 100%
2024-07-22 09:26:38 -05:00
Nick Krantz 0e51695078
swap boolean label for checked (#10168) 2024-07-22 09:15:16 -05:00
Nick Krantz 019c5d6677
use linked types from the cipher prototype (#10167)
- When adding a new cipher the cipher view isn't defined yet
2024-07-22 09:12:36 -05:00
Bernd Schoolmann 457c0795be
Remove old biometrics masterkey logic (#9943) 2024-07-22 13:40:19 +00:00
Bernd Schoolmann 7d5df0209c
Adust CODEOWNERS to move biometrics native IPC to auth ownership (#10182) 2024-07-22 09:29:06 -04:00
aj-rosado fdbb1a903d
Swapped hardcoded string with the localization ones on MemberAccessReportComponent (#10186) 2024-07-22 12:31:59 +02:00
Jordan Aasen b2d4d1bec2
[PM-4963] Migrate breach report components (#10045)
* WIP - migrate exposed passwords report components

* lint fix

* migrate components in reports

* migrate breach and unsecured websites reports

* undo change routing

* revert changes to reports

* revert changes

* migrate breach report component

* update form

* revert back to text input

* revert change to logic

* layout fixes

* add spec

* fix typo

* undo changes to exposed passowords report

* fix test

---------

Co-authored-by: jordan-bite <jordan@bite-interactive.com>
2024-07-19 17:23:02 -07:00
✨ Audrey ✨ e22568f05a
[PM-9422] generator engines (#10032)
* introduce email-randomizer
* introduce email-calculator
* introduce password-randomizer
* introduce username-randomizer
* move randomizer abstraction
2024-07-19 16:34:39 -04:00
Matt Gibson 5b5c165e10
[PM-8847] Delay browser local storage operations during reseed (#9536)
* Define matchers to test promise fulfillment

These are useful for validating that promises depend on other events prior to fulfilling.

* Expose custom matchers to jest projects

Team-specific projects are not touched here to try and reduce review burden.

* Block browser local operations awaiting reseed

This should closes a narrow race condition resulting from storage operations during a reseed event.

* Import from barrel file

This might fix the failing test, but I'm not sure _why_

* Document helper methods

* Validate as few properties as possible per test

* Simplify expected value representation

* Allow waiting in promise matchers

* Specify resolution times in promise orchestration tests.

* Test behavior triggering multiple reseeds.

* Fix typo

* Avoid testing implementation details

* Clear reseed on startup

in case a previous process was aborted in the middle of a reseed.

* Correct formatting
2024-07-19 16:12:29 -04:00
Daniel James Smith 1320d96cb4
[PM-9869] Create SendFormContainer (#10147)
* Move SendV2component into send-v2 subFolder

* Create SendFormContainer and related services

* Add initial SendFormComponent which uses the SendFormContainer

* Remove AdditionalOptionsSectionComponent which will be added with a future PR

* Add libs/tools/send to root tsconfig

* Register libs/tools/send/send-ui with root jest.config.js

* Register libs/tools/send/send-ui with root tailwind.config.js

* Fix service injection on DefaultSendFormService

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-19 21:17:52 +02:00
Jonathan Prusik beeb0354fd
[PM-7174] New Notifications Settings and Excluded Domains components (#10059)
* add v2 notification settings component

* adjust filenames for future deprecation

* drop popup tab navigation for the notification settings view

* add refreshed excluded domains component

* do not allow edits of pre-existing excluded domains

* fix buttonType on bit-link button
2024-07-19 12:36:09 -04:00
Nick Krantz 11669da911
add testids for automation testing (#10170) 2024-07-19 11:31:33 -05:00
Tom 087440989e
Fixing the test for unsecured reports (#10185) 2024-07-19 11:27:23 -04:00
Bernd Schoolmann 05e8b45edb
[PM-7084] 6/6: Introduce shared duo two-factor component (#9772)
* Add shared duo component

* Fix duo import

* Fix wrong i18n service DI in duo desktop component

* Remove duo v2

* Add override to functions

* Remove web duo implementation

* Update apps/browser/src/auth/popup/two-factor-auth-duo.component.ts

Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>

* Update apps/desktop/src/auth/two-factor-auth-duo.component.ts

Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>

* Update libs/angular/src/auth/components/two-factor-auth/two-factor-auth-duo.component.ts

Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>

* Fix missing service on duo components

* Fix missing service on base duo auth component

* Fix constructor super calls in duo auth component

* Fix duo auth components incorrectly extending base class

---------

Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>
2024-07-19 16:29:24 +02:00
Tom bc1ee0a169
Modifying the unsecured reports to check for proper permissions (#10038) 2024-07-19 09:18:30 -04:00
github-actions[bot] 1cdc701328
Autosync the updated translations (#10177)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-19 11:14:22 +00:00
renovate[bot] 88f383ba7f
[PM-9938][deps] Tools: Update electron to v31.2.1 (#10173)
* [deps] Tools: Update electron to v31.2.1

* Update version in electrron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-19 13:13:50 +02:00
github-actions[bot] 147bf03b96
Autosync the updated translations (#10176)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-19 11:06:53 +00:00
aj-rosado 94d6cc3ef1
[PM-8780] Added validation to only display organizations with managed collections (#10065)
* Added validation to only display organizations with managed collections on the export org selector

* using the decryptedCollection$ directly instead of creating a new observable from the encryptedCollections array
2024-07-19 10:45:35 +01:00
github-actions[bot] b5447f326c
Autosync the updated translations (#10175)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-19 08:53:06 +00:00
Jason Ng 150b9ef29c
[PM-9629] Custom Fields V2 View Section Defects (#10103)
* Updates to Custom Fields V2 View
2024-07-18 18:56:02 -04:00
SmithThe4th c27657eb82
[PM-8050] Deleting one folder deletes all other folders (#10165)
* removed the use of deletepromise from folder edit dialog on web

* resolved fix me

* return folders if folder is not found with folder id
2024-07-18 18:28:25 -04:00
Jared Snider 56f5dba444
Auth/PM-6198 - Registration with Email Verification - Call email clicked endpoint (#10139)
* PM-6198 - Majority of client work done; WIP on registration finish comp

* PM-6198 - Registration Finish - Add registerVerificationEmailClicked logic

* PM-6198 - RegistrationLinkExpired component; added translations on other clients just in case we use the component on other clients in the future.

* PM-6198 - Clean up comment
2024-07-18 17:37:22 -04:00
Jared Snider 158da35008
Auth/PM-9873 - Registration with Email Verification - Start Component clean up (#10157)
* RegistrationStart - sanitize name input

* PM-9873 - Registration Start - per discussion with design, remove autofocus to solve issue w/ email required error showing immediately due to login component mousedown events.

* PM-9873 - Restore autofocus for accessibility
2024-07-18 17:18:49 -04:00
Jared Snider 8be11b174c
Registration start - update copy per product request. (#10169) 2024-07-18 17:10:32 -04:00
Jordan Aasen 9dd80c92c8
[PM-4968] Migrate unsecured websites report components (#10046)
* WIP - migrate exposed passwords report components

* lint fix

* migrate components in reports

* migrate breach and unsecured websites reports

* undo change routing

* revert changes to reports

* revert changes

* migrate unsecured websites report component

* fix icon and padding in unsecured websites report

* undo changes to exposed passwords report

---------

Co-authored-by: jordan-bite <jordan@bite-interactive.com>
2024-07-18 23:04:50 +02:00
Shane Melton 517967d4fe
Use static date for storybook data (#10172) 2024-07-18 13:47:49 -07:00
Nick Krantz bf66cd1550
filter out linked option for notes (#10162) 2024-07-18 13:57:10 -05:00
Shane Melton f75c1ab02d
[PM-8524] Cipher Form - Edit Login Details Section (#10081)
* [PM-8524] Introduce login details section component

* [PM-8524] Add ability to remove passkey

* [PM-8524] Introduce TotpCaptureService and the Browser implementation

* [PM-8524] Tweak storybook

* [PM-8524] Add note regarding existing login view references

* [PM-8524] Fix clone mode so that a new cipher is created

* [PM-8524] Add support for generating usernames/passwords and auditing passwords

* [PM-8524] Migrate password/username generation to CipherFormGenerationService

* [PM-8524] Add optional passwordInput to BitPasswordInputToggle to support conditionally rendered password toggle buttons

* [PM-8524] Add LoginDetailsSection tests

* [PM-8524] Add BrowserTotpCaptureService tests

* Revert "[PM-8524] Add optional passwordInput to BitPasswordInputToggle to support conditionally rendered password toggle buttons"

This reverts commit e76a0ccfe8.

* [PM-8524] Add null check to password input toggle
2024-07-18 09:38:55 -07:00
Addison Beck 3bfa024b87
Output user-specific associations for collections in the CLI (#10154)
Collection management permissions can be set for a group or a specific
user. Currently the CLI only outputs group associations when it displays
collection configuration information. This can cause bugs when piping
commands together.

This commit ensures that `user` associations also get output. In all
cases this data was already available and just needed to be added to a
response model.
2024-07-18 11:31:54 -04:00
Bernd Schoolmann 577a3a720a
Fix icon size (#10160) 2024-07-18 10:22:55 -04:00
Nick Krantz 9bfd838da6
[PM-8381] Assign collections (#9854)
* initial add of assign collections component

* grab cipherId from query params

* add organization selection for moving a cipher

* add multi-select for collections

* add transfer of cipher to an organization

* temp: do not show assign collections while a cipher already has an organization

* account for initial collections for a cipher

* block assign-collections route with feature flag

* replace hardcoded string with i18n

* separate out async calls to switchMap to avoid async subscribe

* use local cipher rather than decrypting again

* use anchor for better semantics

* migrate form submission to bitSubmit directive

* swap to "assign" rather than "save"

* integrate with base AssignCollections component

* clean up messages file

* remove unneeded takeUntilDestroyed

* remove unneeded bitFormButton

* remove unused translations

* lint fix

* refactor assign-collections component to take in a button reference

- This allows consuming components to not have to worry about loading/disabled states
- The base AssignCollections component will change the submit button when supplied
2024-07-18 08:53:53 -05:00
Daniel James Smith cebbb9486e
[PM-9855] Add premium badge to new file send item dropdown (#10137)
* Create browsers SendV2 component

* Add premium badge to new file send item dropdown

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-18 14:41:09 +01:00
Bernd Schoolmann 84b719d797
[PM-4154] Introduce Bulk Encrypt Service for Faster Unlock Times (#6465)
* Implement multi-worker encryption service

* Fix feature flag being flipped and check for empty input earlier

* Add tests

* Small cleanup

* Remove restricted import

* Rename feature flag

* Refactor to BulkEncryptService

* Rename feature flag

* Fix cipher service spec

* Implement browser bulk encryption service

* Un-deprecate browserbulkencryptservice

* Load browser bulk encrypt service on feature flag asynchronously

* Fix bulk encryption service factories

* Deprecate BrowserMultithreadEncryptServiceImplementation

* Copy tests for browser-bulk-encrypt-service-implementation from browser-multithread-encrypt-service-implementation

* Make sure desktop uses non-bulk fallback during feature rollout

* Rename FallbackBulkEncryptService and fix service dependency issue

* Disable bulk encrypt service on mv3

* Change condition order to avoid expensive api call

* Set default hardware concurrency to 1 if not available

* Make getdecrypteditemfromworker private

* Fix cli build

* Add check for key being null
2024-07-18 08:56:22 -04:00
Addison Beck 9b50e5c496
Disable a button during page load (#10148)
The people screen has a button that can be clicked to open a modal for
inviting new users to an organization. This modal depends on data from
the people list for conditional logic, like whether or not the seat count
cor the organization has been reached. If the modal is opened before the
people list loads these conditions can not process correctly, causing
bugs.

This commit disabled the button until the people list loads to prevent
this kind of behavior.
2024-07-18 10:17:53 +01:00
Todd Martin 3706eb995a
Remove labeling of PRs with needs-qa (#9880) 2024-07-17 15:48:55 -04:00
Bernd Schoolmann fd93c76c0d
Fix key rotation being broken due to org ciphers being included (#10140) 2024-07-17 10:31:35 -04:00
Alex Morask e27d698d4b
[AC-2860] Revise unassigned and purchased seat warning for CB (#10077)
* Rework create-client-dialog seat warning

* Rework manage-client-subscription-dialog seat warning

* Fix create client purchased seats label

* Fix manage client subscription purchased seats label logic

* Another manage subscription purchased seats fix
2024-07-17 10:12:40 -04:00
Nick Krantz 83d141c914
[PM-8803] Edit Custom Fields (#10054)
* initial add of custom fields

* add fields for custom field

* integrate custom field into cipher form service for text fields

* add hidden field type

* add boolean custom field

* add linked option type

* add testids for automated testing

* add edit option for each custom field

* update dialog component name to match add/edit nature

* add delete button for fields

* initial add of drag and drop

* collect tailwind styles from vault components

* add drag and drop functionality with announcement

* add reorder via keyboard

* update tests to match functionality

* account for partial edit of custom fields

* fix change detection for new fields

* add label's to the edit/reorder translations

* update dynamic heading to be inline

* add validation/required for field label

* disable toggle button on hidden fields when the user cannot view passwords

* remove the need for passing `updatedCipherView` by only using a single instance of `CustomFieldsComponent`

* lint fix

* use bitLink styles rather than manually defining tailwind classes

* use submit action, no duplicated button and allows for form submission via enter

* add documentation for `newField`
2024-07-17 09:11:42 -05:00
Bernd Schoolmann a1c5cc6dbf
Fix key rotation being broken due to master key validation (#10135) 2024-07-17 14:13:03 +02:00
renovate[bot] 7dc41c0c34
[deps] AC: Update webpack to v5.93.0 (#9799)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-17 14:10:30 +10:00
Daniel James Smith 90de9dd07a
Create browsers SendV2 component (#10136)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-16 22:12:46 +01:00
Anders Åberg dbc9b9c90b
PM-4877: Only allow replacing passkeys for the same userhandle (#9804)
* Initial draft

* small cleanup

* show vaul items without passkeys

* Refactored a bit

* tests run for me?

* Fixed platform test

* null and undefined

* lint
2024-07-16 13:39:41 -04:00
rr-bw aa8c5b1516
make minimumLength msg update if mp policy is enforced (#10105) 2024-07-16 09:36:05 -07:00
rr-bw e2c99c2cdf
use new tools-password-strength component (#10125) 2024-07-16 09:14:39 -07:00
Bernd Schoolmann 69a37a884f
Add shared webauthn component (#9771) 2024-07-16 10:46:37 -04:00
renovate[bot] 96538a68fd
[deps] SM: Update typescript-eslint monorepo to v7.16.1 (#10068)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-16 16:16:31 +02:00