Commit Graph

202 Commits

Author SHA1 Message Date
Thomas Rittson 4550b7ddf8
Add canManageBilling permission to permission checks (#798) 2022-05-10 16:37:35 +10:00
Oscar Hinton 694de6ffdb
[EC-192] Use ts-jest instead of deprecated ts-jest/utils (#792) 2022-05-09 18:25:17 +02:00
Addison Beck 141ade3c38
[feat] End User Vault Refresh (#790)
* Move access logic to org model (#713)

* [feature] Allow for top level groupings to be collapsed (#712)

* [End User Vault Refresh] Refactor route permission checking (#727)

* Update admin access logic

* Centralize route permission handling

* Add permission check for disabled orgs

* [EndUserVaultRefresh] Add base routing guard (#732)

* Add a base class for Angular routing guards

* Update Guard naming convention

* Bump node-forge to 1.2.1 (#722)

* Remove Internet Explorer logic (#723)

* Username generator (#734)

* add support for username generation

* remove unused Router

* pr feedback

* Bump electron and related dependencies (#736)

* PS-91 make isMacAppStore return true/false (#735)

* return false if undefined from isMacAppStore

* PS-91 use strict equality instead of null coalescing

Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>

Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>

* [bug] Fix Safari CSV importer for URL and Notes (#730)

* Fix import path for safari importer (#740)

* Force updates to be silent (#739)

* support for username gen website setting (#738)

* Fix jslibModule forms (#742)

* Add DatePipe provider to JslibModule (#741)

* Feature/move to jest (#744)

* Switch to jest

* Fix jslib-angular package name

* Make angular test project

* Split up tests by jslib project

* Remove obsolete node test script

* Use legacy deps with jest-preset-angular

* Move web tests to common

* Remove build from pipeline

This was only being used because we were not using ts runners.
We are now, so build is unnecessary

* Remove the VerifyMasterPasswordComponent from jslib module (#747)

* Add ellipsis pipe to jslib module (#746)

* add ellipsis pipe to jslib module

* Add ellipsis pipe to exports

* Add ColorPasswordCountPipe to JslibModule (#751)

* Generator cleanup (#753)

* type is null by default

* rename generator component

* remove showWebsiteOption

* shorthand if check

* EC-134 Fix api token refresh (#749)

* Fix apikey token refresh

* Refactor: use class for TokenRequestTwoFactor

* Remove keytar and biometric logic (#706)

* [bug] CL - fix default button display and callout header class (#756)

* [EC-142] Fix error during import of 1pux containing new email field format (#758)

* Add support for complex email field type

* Ensure complex email field type gets imported on identities

* [euvr] Separate Billing Payment/History APIs (#750)

* [euvr] Separate Billing Payment/History APIs

* Updated to new accounts billing API

* Removed getUserBilling as it will become obsolete once merged

* [end user vault refresh] Base Changes For Vault Filters (#737)

* [dependency] Update icons

* Avoid duplicate fullSync api calls (#716)

* Tweak component library slightly (#715)

* Check runtime name vs mangled name (#724)

* Add Chromatic (#719)

* Update SECURITY.md (#725)

* Update SECURITY.md

Add link to our HackerOne program for submitting potential security issues.

* Revise language on SECURITY.md

* Remove error Response type check (#731)

* Remove error Response type check

Minimization is impacting type checking in a non-consistent way.
The previous type check works locally,
but not from build artifacts 🤷. We only set `captchaRequired` on
our errors when we want a resubmit with captcha included, so we're safe
keying off that

* linter

* [JslibModule] Add JslibModule (#733)

* Add ellipsis pipe (#728)

* add ellipsis pipe

* run prettier

* Account for ellipsis length in returned string

* Fix complete words case

* Fix another complete words issue

* fix for if there are not spaces in long value

* extract length check to beginning of method

* condense if statements

* remove log

* [refactor] Add optional folders param to folderService.getAllNested()

This will be used later for use cases where the vault filters service needs to build a list of nested folders that have been filtered by organization

* [feature] Add organization filters

This is an MVP implementation of the changes needed for the vault refresh. This includes collapsable top level groupings, and organization based filters that dynamically adjust folders and collections.

* [refactor] Break down vault filter into several components

These changes rename and rewrite the GroupingsComponent into a VaultFiltersModule. The module follows typical angular patterns for structure and purpose, and contain components for each filter type. The mostly communicate via Input and Output, and depend on a VaultFilterService for sending and recieving data from other parts of the product.

* [bug] Add missing events for folder add/edit

* [refactor] Dont directly change activeFilter in VaultFilterComponent

* [refactor] Move DisplayMode to a dedicated file

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>

* [CL-16 Component Library] Menu Dropdown (#761)

* [bug] Add missing null check in vault filters (#769)

* [bug] Add @Injectable to VaultFilterService (#781)

* [fix] Ran prettier

* [fix] Fix merge issue

I used createUrlTree when merging guards because I knew that was the angular standard, didn't notice that redirect was a helper method from us

* Remove BaseGuard (#791)

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
Co-authored-by: Jake Fink <jfink@bitwarden.com>
Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>
Co-authored-by: David Frankel <42774874+frankeld@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Co-authored-by: Vincent Salucci <26154748+vincentsalucci@users.noreply.github.com>
Co-authored-by: Vincent Salucci <vincesalucci21@gmail.com>
2022-05-09 08:09:46 -04:00
Thomas Rittson 52321c51cc
[EC-151] Hide Subscription/Billing information for Provider-managed organizations (#777)
* add canManageBilling permission and hasProvider helper method
2022-05-06 06:24:40 +10:00
Kyle Spearrin 9d411fd37d
fix default forwardedService property name (#788) 2022-05-02 11:26:32 -04:00
Thomas Rittson 2e2849b4de
[PS-74] Fix user authentication state checks (#721)
* Create authService.authStatus, refactor isLocked checks

* Rename authStatus -> getAuthStatus
2022-04-29 21:33:38 +10:00
Federico Maccaroni e4687b4cc6
PS-302 Added DeviceId to the 2FA email request and set it when calling the endpoint that's needed to see if it's a 2FA email because of a new device (#782) 2022-04-28 13:18:26 -03:00
Kyle Spearrin fe65a337c8
Forwarded email alias generation (#772)
* generate forwarded alias with SL and AD

* added forwarded email to type list

* add ApiService dep

* ApiServiceAbstraction

* use proper status codes

* only generate on button press

* reset username to `-`

* reset username when forwarded

* Authorization header for anonaddy

* use proper anonaddy json path

* firefox relay support

* update description for firefox

* log username generation errors
2022-04-27 10:08:46 -04:00
Thomas Rittson e40e7de808
[EC-159] [BEEEP] Remove factory providers in Angular DI (#775) 2022-04-26 07:28:43 +10:00
Oscar Hinton 366d9b3c63
Remove userId from data models (#771) 2022-04-20 15:59:51 +02:00
Oscar Hinton f6e3481fe9
[BEEEP] Allow linking to ciphers (#760) 2022-04-20 11:15:58 +02:00
Oscar Hinton ad37de9373
Rename Export DTOs (#763) 2022-04-19 13:03:04 +02:00
Oscar Hinton fee2f78aa8
Fix language always defaulting to english (#765) 2022-04-19 09:53:51 +02:00
Oscar Hinton 6bcadc4f40
Add tests for domain models (#768) 2022-04-16 11:18:12 -04:00
Oscar Hinton f8ac1ed12b
Remove support for alreadyEncrypted (#762) 2022-04-16 17:00:48 +02:00
Oscar Hinton 3f56834716
Update jest configs to remove roots (#766) 2022-04-12 16:55:59 +02:00
Kyle Spearrin 017fb5146f
copy default options (#764) 2022-04-11 22:39:05 -04:00
Thomas Rittson 0f0adc9bd9
Add jsdoc comments for user verification, password reprompt, and appApiAction (#754)
* Rename and add comments to clarify password reprompt classes

* Add comment for appApiAction
2022-04-12 11:48:33 +10:00
Daniel James Smith 3b9ef68f4b
[EC-142] Fix error during import of 1pux containing new email field format (#758)
* Add support for complex email field type

* Ensure complex email field type gets imported on identities
2022-04-06 17:33:43 +02:00
Oscar Hinton f3a4fde513
Remove keytar and biometric logic (#706) 2022-04-04 21:00:49 +02:00
Thomas Rittson e595c0548e
EC-134 Fix api token refresh (#749)
* Fix apikey token refresh

* Refactor: use class for TokenRequestTwoFactor
2022-04-01 11:28:23 +10:00
Matt Gibson a4fba0e1c5
Feature/move to jest (#744)
* Switch to jest

* Fix jslib-angular package name

* Make angular test project

* Split up tests by jslib project

* Remove obsolete node test script

* Use legacy deps with jest-preset-angular

* Move web tests to common

* Remove build from pipeline

This was only being used because we were not using ts runners.
We are now, so build is unnecessary
2022-03-28 16:00:42 +02:00
David Frankel 7fc0ab97f3
[bug] Fix Safari CSV importer for URL and Notes (#730) 2022-03-24 22:33:28 +01:00
Kyle Spearrin bfdd3561da
Username generator (#734)
* add support for username generation

* remove unused Router

* pr feedback
2022-03-24 12:19:19 -04:00
Oscar Hinton 5b7b2a03dd
Remove Internet Explorer logic (#723) 2022-03-24 10:42:11 +01:00
Oscar Hinton 554dc8d873
Bump node-forge to 1.2.1 (#722) 2022-03-22 14:05:55 +01:00
Matt Gibson 3ec0f6977a
Check runtime name vs mangled name (#724) 2022-03-14 20:12:31 -05:00
Thomas Rittson 3f20122e5b
Avoid duplicate fullSync api calls (#716) 2022-03-11 07:16:50 +10:00
Daniel James Smith 744649573a
Fixes for format change of 1pux files (#714)
* Remove unneeded ItemCollection type

* Mark item.trashed as optional property

* Adjust format of test files to be identical to current exports
2022-03-08 13:42:35 +01:00
Daniel James Smith fa3a95fed0
Fixes and improvements to MykiCsvImporter (#707)
* Add test suite for existing importer

* Fix 2fa-seed not copied on login records

* Fix secure note title not being set

* Add support for importing 2FA file

* Fixed casing on import of MykiCsvImporter

* Import all unmapped fields as customFields

* WIP: Add import of UserIdCard

* Add support for IdCards
2022-03-07 17:20:50 -05:00
Daniel James Smith 18b954614c
Remove Dashlane json importer from the featured list (#711) 2022-03-08 08:11:23 +10:00
Daniel James Smith 6e345bc4cc
Dashlane Csv-Importer (#708)
* Move existing dashlane importer into dashlaneImporters

* Add testData for Dashlane CSV importer

* Add dashlane Csv importer and unit tests

* Fixed linting issues

* Moved dashlaneCsv types to own file

* Register DashlaneCsv importer

* Removed temp private method and use base impl

* rename spec imports

* Move scope of mapped columns

* Migrate folders into collection if imported via org
2022-03-07 19:21:23 +01:00
Addison Beck 6aae3beb76
[bug] Set proper default for autoConfirmFingerprint (#704) 2022-03-03 19:57:50 +01:00
Addison Beck 4d94f7a631
[bug] Delete stored keys if the value is null (#705) 2022-03-03 19:57:08 +01:00
Daniel James Smith 8e112a1c33
Add importer for 1Password's new export format (.1pux) (#594)
* Initial commit

* Refactor the 1pux types

* Add test data

* 1Pux importer and tests

* Fixed a typo in the 1Pux types

* Make the linter happy

* Register and instantiate importer

* Fix adding secure notes

* Add missing placeholder property to types

* Test for existance of TOTP seed

* Add more test data

* Move processFullName into BaseImporter

* Add categoryEnum for easier mapping

* Refactoring of the importer and add support for different item types

* Make linter happy

* Modified some test data

* Fix linting issues

* Remove fieldvalue references comment

* Remove commented mapping use during tests
2022-03-03 15:22:05 +01:00
Vincent Salucci 48a4c27fe7
[Captcha] Failed login attempts (#698)
* [Captcha] Failed login attempts

* Fix logIn.strategy test

* Updated with the stark majority of requested changes

* Fix typo

* Unused import
2022-03-02 19:47:57 -06:00
Thomas Rittson adfc2f234d
Remove unused SSO Form code (#701)
* Remove unused SAML Artifact Binding properties

* Remove unused validators
2022-03-03 07:52:11 +10:00
Robyn MacCallum 8f5f694a1e
Roll back organizationId and collectionId's if ciphers fail to be moved (#699) 2022-03-02 08:11:34 -05:00
Thomas Rittson e47eb5e74f
Fix linting (#700) 2022-03-01 23:11:12 +01:00
Thomas Rittson c1a37eab13
Fix storage keys in v1 migration (#696) 2022-03-02 07:44:14 +10:00
Thomas Rittson d81eb7ddae
Improve SSO Config validation (#572)
* Extract SsoConfig enums to own file

* Add ChangeStripSpaces directive

* Move custom validators to jslib

* Add a11y-invalid directive

* Add and implement dirtyValidators

* Create ssoConfigView model and factory methods

* Add interface for select options

* Don't build SsoConfigData if null

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-03-02 07:31:00 +10:00
Thomas Rittson d919346517
Fix autoFillOnPageLoadDefault default value (#697) 2022-03-01 13:13:19 +10:00
Daniel James Smith a69135ce06
Add missing localeNames (#695) 2022-02-25 18:54:27 +01:00
Addison Beck 65219f5705
[bug] Store collapsedGroupings in accountSettings (#694) 2022-02-25 13:03:13 +01:00
Thomas Rittson 1cbc119ad8
[AuthService refactor] Don't clear state if 2FA is invalid (#690)
* Don't clear state if 2FA is invalid

* Add session timeout to 2FA

* Clear internal authService state if unhandled error
2022-02-23 21:08:43 -06:00
Melanie Kanavakatini 2779cd0966
feat: add hidden char count toggle (#341)
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-02-24 07:18:46 +10:00
Addison Beck 78b5f15042
[feature] Implement scope warning for exports (#688)
* [feature] Add a hasOrganizations() service method

* [feature] Add a component to warn users about export scope
2022-02-23 13:56:46 +10:00
Matt Gibson 1fb3d54014
Feature/password protected export (#689)
* Simplify password protected file format

* no items to import is not an error

* Await inner importer

* Add export format type

* Error if import file is password protected

* Update tests

* Test password protected with normat json importer

* Simplify imports

* Ignore code coverage directory

* Expand importer options  without changing display options

* Import password require import error handling

* Use interface

* Fix curlies

* linter fixes

* Add null of empty util

* Lint fixes

* run prettier

* Move import options to separate enum file

* Fix imports
2022-02-23 13:02:07 +10:00
Oscar Hinton 60878cd4ed
Add eslint (#610) 2022-02-22 15:39:11 +01:00
Kyle Spearrin fc0638a7d9
fix infite recursion on getEncKey (#687) 2022-02-17 11:36:00 -05:00