Commit Graph

13207 Commits

Author SHA1 Message Date
Will Martin 743f4f8c69
[SM-529] fix directive typo (#4894) 2023-03-01 11:48:39 -05:00
Colton Hurst 667d3fccc2
SM-528: Fix SM Import / Export Error Messaging (#4833)
* SM-528: Remove try catch to use default error handling

* SM-528: Add admin check on import / export

* SM-528: Hide settings nav section unless admin

* SM-528: Refactor observable in navigation component

* SM-528: Hide SM Trash from nav menu if not admin

* SM-528: clean up navigation.component.ts
2023-03-01 09:39:32 -05:00
cd-bitwarden abbfb0696f
removing Write only (#4884) 2023-02-28 18:15:39 -05:00
Todd Martin 1e7d83c0c8
Fixed syntax on types (#4886) 2023-02-28 10:55:16 -05:00
Oscar Hinton 6348269a1a
[SM-352] Projects tab for service accounts (#4858)
* Init service layer changes

* refactor service to inherit abstract

* refactor access-selector component

* update access selector in projects

* add service accounts access selector

* update i18n

* fix delete action; use useExisting in providers

* update static permissions

* service account people should be readwrite on creation

* use setter instead of observable input

* remove warning callout

* remove abstract service

* truncate name in table

* remove extra comments

* Add projects access policy page

* Add locale

* use map instead of forEach

* refactor view factories

* update SA people copy

* map list responses

* Swap to using granted policies endpoints

* Remove text-xl from icon

---------

Co-authored-by: Thomas Avery <tavery@bitwarden.com>
Co-authored-by: William Martin <contact@willmartian.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2023-02-28 09:31:19 -06:00
Will Martin 4e112573f5
[SM-520] add secret copy actions (#4887) 2023-02-28 09:29:04 -05:00
Brandon Maharaj 6adcb35dd7
fix: missing changes (#4832) 2023-02-28 02:04:41 -05:00
Jake Fink c160827272
[EC-859] update billing routes for owners of Managed orgs (#4611)
* [EC-859] update billing routes for owners of Managed orgs

* [EC-859] fix observable in billing tab

* [EC-859] update observable name

* [EC-859] update reporting and settings observables

* [EC-859] add startsWith to reporting observable

* [EC-859] async pipe once in settings

* [EC-859] create get$ in org service

* [EC-859] transition remaining components

* [EC-859] add as org to template

* [EC-859] add shareReplay to observable to prevent multicasting
- future proof get$ on org service

* [AC-859] fix missed org
2023-02-27 16:31:55 -05:00
Will Martin ff89d86d40
[SM-571] reenable route reuse on destroy (#4883) 2023-02-27 14:46:05 -05:00
Robyn MacCallum 3e03c95a10
Add a11y check to PR template (#4882) 2023-02-27 14:21:28 -05:00
Todd Martin 06a3237729
Add workflow to apply needs-qa label (#4727)
* Added new workflow

* Fixed quotes.

* Added step to job.

* Added check for PR destination branch.

* Changed criteria.

* Added fork check for community PRs.

* Removed space

* Changed name.

* Updated with more filters.

* Changed to target approval for adding the label.

* Lint

* Refactored to use pull_request_target instead.

* Fixed comment

* pull_request_target isn't supported, so pull_request instead

* Added comment about target branch.
2023-02-27 13:19:24 -05:00
Thomas Avery 84aa7fffd7
[SM-474] Service Account - People Tab (#4689)
* Init service layer changes

* refactor service to inherit abstract

* refactor access-selector component

* update access selector in projects

* add service accounts access selector

* update i18n

* fix delete action; use useExisting in providers

* update static permissions

* service account people should be readwrite on creation

* use setter instead of observable input

* remove warning callout

* remove abstract service

* truncate name in table

* remove extra comments

* use map instead of forEach

* refactor view factories

* update SA people copy

* map list responses

---------

Co-authored-by: William Martin <contact@willmartian.com>
2023-02-27 09:43:06 -06:00
Jared Snider fabc15fa45
PM-187 - Allow autofill to work on web vault two step login page by rendering the password form in a hidden state and preventing the continue button from wiping out the autofilled password (#4844) 2023-02-27 10:33:06 -05:00
Daniel James Smith 4d25afe873
[PS-2322] Extend browser's help and feedback page (#4532)
* extend browser held and feedback

* Remove headers and add i18n
2023-02-27 16:26:47 +01:00
Oscar Hinton 8b5a223ad4
[SM-402] Truncate dialog headers (#4854) 2023-02-24 17:29:49 +01:00
Jake Fink 84d211fb56
Fix broken Storybook: Change ng-template to ng-container for ngIf and rename icon directive (#4816)
* remove added template for ngIf and rename icon directive

* fix regression in product switcher

* fix text color of bulk delete in org vault

* use ng-container for *ngIf
2023-02-24 11:19:09 -05:00
Oscar Hinton 7317661457
Require typography module for header stories. (#4861) 2023-02-24 11:14:58 -05:00
Oscar Hinton 6df106ca47
Add cache to lint-staged for prettier (#4862) 2023-02-24 17:09:23 +01:00
Oscar Hinton a643074709
[SM-389] Event log for service account (#4679) 2023-02-24 16:44:24 +01:00
Oscar Hinton 76d6586ff8
Enable caching for prettier (#4837) 2023-02-24 16:44:01 +01:00
github-actions[bot] 7268d272f0
Autosync the updated translations (#4852)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-24 15:11:14 +01:00
dwbit 47a08e0bc8
Creating a template for community discussions (#4855) 2023-02-24 15:06:36 +01:00
Will Martin da9f4e1fb3
[SM-554] hide admin onboarding items from non-admin (#4843)
* hide onboarding items if not admin

* fix inconsistent padding
2023-02-24 08:58:00 -05:00
github-actions[bot] b7f465e552
Autosync the updated translations (#4857)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-24 14:46:56 +01:00
github-actions[bot] 5d25b648d0
Autosync the updated translations (#4853)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-24 14:46:13 +01:00
github-actions[bot] e68c150f1e
Autosync the updated translations (#4851)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-24 13:37:27 +01:00
Oscar Hinton 4d38c7a92a
[SM-557] Use bitTypography for headers (#4839)
* Use bitTypography

* Remove tw-text-xl from menu items
2023-02-23 23:50:38 +01:00
Will Martin d67257218e
[SM-538] truncate project badge (#4842)
* truncate project badge

* use ellipsis pipe
2023-02-23 12:45:08 -05:00
Oscar Hinton c184ff73cf
[SM-553] Fix header sometimes taking up to much space (#4840) 2023-02-23 18:06:07 +01:00
Will Martin a7e0be1014
[SM-539] hide HTML Details marker on Safari (#4828) 2023-02-23 11:26:07 -05:00
Carlos Gonçalves 30a66a9f65
Master password security checks - web (#4799)
* [SG-571][SG-572][SG-573][SG-574] Master password change (web vault) (#4635)

* SG-571 Add option to check master password breach

* SG-571 Fix lint errors

* SG-572 SG-573 SG-574 Add logic for leaked password

* SG-571 Show error when new password equals hint

* SG-571 Minor changes

* SG-571 Undo changes

* [SG-457][SG-553][SG-554][SG-555][SG-761] Master password security update - account creation (web) (#4672)

* SG-571 Add option to check master password breach

* SG-571 Fix lint errors

* SG-572 SG-573 SG-574 Add logic for leaked password

* SG-571 Show error when new password equals hint

* SG-571 Minor changes

* SG-761 Improve copy on master password

* SG-571 Undo changes

* SG-457 Add option to check for password leak

* SG-457 Updated master password hint copy

* SG-457 Hide minimum char message when joining org

* SG-457 Added missing changes from last commit

* SG-457 Fixed minimum length

* SG-457 Updated message with dynamic minimum length

* SG-457 Set checkForBreaches to true by default
2023-02-23 15:15:45 +00:00
Robyn MacCallum 80c2f20f58
Move autofillConstants to autofill folder (#4830)
* Move autofillConstants to autofill folder

* Remove autofillConstants from whitelist capital

* Add vault team as code owners for autofill folder

* Update codeowners for web
2023-02-22 16:03:05 -05:00
Robyn MacCallum c594f23121
[SG-998] Move vault folder into app folder for web (#4824)
* Move vault folder into app folder for web

* Remove extra line is oss module
2023-02-22 11:21:32 -05:00
Colton Hurst 6f58d44833
Fix spacing in the projects and secrets lists (#4807) 2023-02-21 19:06:04 -05:00
Brandon Maharaj 16fcc22677
work: added support for new props (#4567)
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
2023-02-21 15:59:38 -05:00
Oscar Hinton 72283d0a35
[SM-525] Fix projects not being active when on subroute (#4815)
* Move overview to separate route. Change nav-item to use subset instead of exact

* Add support for setting exactMatch in nav-item and nav-group

* Change default to subset
2023-02-21 19:04:35 +01:00
Oscar Hinton 3305c808d1
[SM-396] Self-enroll Secrets Manager (#4666) 2023-02-21 18:24:55 +01:00
Will Martin 581f69256d
[SM-453] user onboarding component (#4707)
* wip onboarding component

* fix button type

* remove dismiss button

* add completion logic

* update styles; add download cli section; add click logic; add loading spinner

* update i18n

* update icons; rearrange items; fix import item logic

* add complete i18n

* fix reactivity

* move visibility logic into presentational component

* add button type

* apply code reviews

* add loading spinner to page

* onboarding dismissal should persist when switching orgs

* add workaround for inconsistent icon size

* fix full storybook

* apply code review; update stories
2023-02-21 11:25:41 -05:00
Oscar Hinton 7ce4579214
[SM-519] Remove ServiceAccounts tab from secret dialog (#4813) 2023-02-21 16:31:52 +01:00
Colton Hurst d11f03cb78
SM-281: Secrets Manager Trash (#4730)
* SM-281: Initial commit with trash component setup

* SM-281: Customize secrets list component, add ability to hard delete secrets

* SM-281: Add support for restoring secrets in SM

* SM-281: restoreSecret emit values as an array

* SM-281: Fix bug caused by mistake when doing merge conflict resolution

* SM-281: Clean up TrashService and move more functionality to TrashApiService

* Cleanup responses

* Merge TrashService and SecretService

* Remove tw-text-sm from dialogs

* Split delete into two components

* Change secrets table to have a single boolean for trash

* SM-281: Rename component to secret-hard-delete

* Remove unused organizationId

* Remove duplicate buttons

---------

Co-authored-by: Hinton <hinton@users.noreply.github.com>
2023-02-21 10:03:37 -05:00
Rafael Kraut 208be8dfbf
[PS-1918] Make autofill doc-scanner traverse into ShadowRoot (#4119)
* This commit implements the following main changes:

- Query elements by using a TreeWalker instead of `document.querySelector[All]`. The reason for this is that `querySelector[All]` doesn't traverse into elements with ShadowRoot.
- Recursively traverse into elements with `openOrClosedShadowRoot` or `Element.shadowRoot` (depending on browser support) inside TreeWalker loop.
- Use new query logic everywhere inside `autofill.js`. This also means we need to use filter functions to find elements with specific nodeNames and/or attributes instead of CSS selector strings.
- Add two new `instanceof Element` checks to prevent `Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'." errors`.

This change is fully backward compatible. If `openOrClosedShadowRoot` is not available it will always return undefined and we will never traverse into ShadowRoots just as the behavior was before this change.

* refactor: outsource recursive logic to accumulatingQueryDocAll

We don't want the `els` argument on the `queryDocAll` function because it's never used from outside the function itself. Thus the recursive logic is moved to `accumulatingQueryDocAll`.
Now `queryDocAll` creates an empty array and passes it to `accumulatingQueryDocAll` which recursively walks the document and all ShadowRoots and pushes all found nodes directly to the referenced array.

The decision to use a directly mutated array instead of `Array.concat(els)` or `Array.push(...els)` is for performance reasons. Pushing to the referenced array was 74% faster than using `Array.push` with spread operator and even 90% faster than using `Array.concat`.

Co-authored-by: Chad Miller <64046472+chadm-sq@users.noreply.github.com>

* refactor: extract input field relevance check into own function

Addresses CodeScene analysis violation "Bumpy Road Ahead" where conditional logic is checked for a nesting of 2 or deeper.

* refactor: use proper element attribute handling

- use el.type attribute instead of el.attribute.type on input elements. This makes sure we also get 'text' when type attribute is not explicitly specified
- use el.htmlFor attribute instead of el.attribute.for on label elements
- use `hasAttribute` and `getAttribute` methods instead of `attributes[]` which is discouraged by https://quirksmode.org/dom/core/#attributes
- improve readability of `isRelevantInputField`

---------

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Chad Miller <64046472+chadm-sq@users.noreply.github.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2023-02-20 08:43:18 +10:00
Jared Snider a348c78a79
Defect/SG-1083 - Fix SSO Form Validation (#4791)
* SG-1083 - Refactor SSO form validation to work per EC requirements

* Move SSO component into its own folder for better folder management for future components in auth.

* Defect SG-1086 - Domain verification table: Change domain name from anchor tag to button + add title

* SG-1083 - Send null instead of empty string for sso identifier to avoid duplicate key in database issues.

* SG-1086 - Add button type to domain verification button to pass lint rules.
2023-02-17 16:55:57 -05:00
github-actions[bot] 450df353a4
Bumped desktop version to 2023.2.1 (#4801)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-17 20:44:54 +00:00
Daniel James Smith 2b9bc08c71
Fix subfolders not being created (#4653)
In Bitwarden, subfolders are separated/indicated using forward-slashes
The Keeper CSV export separates folders uses backslashes
Replace backslashes with forwardslashes in processFolder
Added tests to verfiy folder/collection creation
2023-02-17 21:01:21 +01:00
Robyn MacCallum 999a40e755
[SG-900] Autofill callout updates (#4738)
* Updated messages

* Implement method in platformUtils to get autofill command

* Updates to callout in current tab component

* Add autofill keyboard shortcut to autofill settings

* style updates

* Add routing animation for autofill settings

* Remove extra function

* Remove unnecessary safari logic

* Remove autofill settings transition added in another PR

* Fix callout still present after clicking 'Got it' (#4797)

---------

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2023-02-17 14:38:22 -05:00
Joseph Flinn 4780a9ce18
Add temporary QA ACR (#4790)
* Remove cloud web container build. Add QA ACR back in temporarily

* Move selfhost build job into the matrix

* bypassing correct image generation

* fixing linting issues

* Fix output name

* Patch DockerHub upload from server to clients
2023-02-17 09:36:53 -06:00
Patrick H. Lauke 6c048d18f3
[PS-2266][SG-1067] Desktop: restyle generator panel to be panel-like and avoid overflowing (#4480)
* Port browser styles for generated password from browser to desktop

* Tweak styles

as the overall styles seem to diverge quite a bit from those of the browser extension, so things like the border color etc aren't as nicely defined, and there's already padding happening on the outer container, making the extra padding superfluous

* Wrap generator up as a `.box` / `.box-content` construct

adds the nice consistent box styles, same as the following blocks of content

* Wrap `.box` around both password AND username generated blocks

* Remove panel-like style, add browser extension border style
2023-02-17 10:16:40 -05:00
tangowithfoxtrot e206b6b457
enable SM in QA environment (#4789) 2023-02-17 03:41:57 -08:00
André Bispo 5a9733dfb3
[SG-1066] Add animation to autofill settings navs (#4778) 2023-02-17 11:20:27 +00:00
github-actions[bot] c0b1fe11e7
Autosync the updated translations (#4794)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-02-17 01:19:00 +01:00