Commit Graph

688 Commits

Author SHA1 Message Date
aj-rosado 8174095a20
[PS-1162] Preventing escape from closing popup when vault selector is open (#3195)
* PS-1162 Preventing escape from closing popup when vault selector is open

* PS-1162 attached escape target to HostListener
2022-08-05 15:24:02 +01:00
github-actions[bot] 3b47edddb2
Autosync the updated translations (#3247)
Co-authored-by: github-actions <>
2022-08-05 02:04:10 +02:00
Thomas Rittson 8626e1d4e6
[EC-281] Add de/serialization methods to CipherView objects (#2970) 2022-08-05 08:07:24 +10:00
github-actions[bot] 6cd1291ea7
Bumped browser version to 2022.8.0 (#3226)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-08-04 16:39:05 +02:00
aj-rosado 1e1a0b1481
PS-1161 Added isLoading bool to verify if load() is still running. Keeping Loaded for the ngIf verification (#3198) 2022-08-04 12:09:32 +01:00
Gbubemi Smith 257fb0c0af
[SG-414] Refactor password strength component (#3186)
* moved password strength to libs

* refactored password strength component

* made changes on desktop and browser to reuse component

* resolved suggestions from PR review

* shared module restructure

* shared module restructure
2022-08-01 23:26:50 +01:00
github-actions[bot] 9594c4f1f8
Autosync the updated translations (#3201)
Co-authored-by: github-actions <>
2022-07-29 11:05:50 +02:00
Oscar Hinton 2011131bb2
[PS-182] Upgrade Angular to V14 (#2948) 2022-07-26 14:48:11 +02:00
Brandon Maharaj 515ca3f0fe
[SG-451] [Defect] - Safari Extension Does Not Display Icon for Long Named Orgs (#3145)
* chore: added strings for disabled org messages

* chore: added icon display

* chore: added prevent filter check

* chore: code changes for desktop

* chore: browser

* fix: float icon

* fix: float right icon

* fix: vary elipsis size
2022-07-25 17:15:44 -04:00
Daniel James Smith 296fb6deb9
Fix missing settings button (#3175)
* With changes made on https://github.com/bitwarden/clients/pull/2662 the button disappeared

* Remove redundant and no longer used css for env settings button on desktop
2022-07-25 13:15:14 -05:00
Patrick 16de33fc1e
[PS-1164] 2022-07-25 13:26:42 -04:00
Patrick H. Lauke 05f6a30672
[PS-1182] Desktop / Browser: Accessibility - remove appBlurClick, change remaining links to buttons (#2662)
* Remove `appBlurClick` from browser extension controls

* Remove last remaining `appBlurClick` from desktop app controls

* Change any straggler `<a>` links to buttons where appropriate (where they don't open a browser window)

* Add missing `type="button"` to some of the desktop buttons

* Update and run prettier, linter

* Remove orphaned jslibs
2022-07-25 12:43:10 +02:00
cyprain-okeke bf291c4e64
Ps 693/fix localhost exclude domain bug 2 (#3140)
* modify the submit function to validate only the newly/modified domains

* changes after running prettier

Co-authored-by: dynwee <onwudiweokeke@gmail.com>
2022-07-25 10:05:41 +01:00
Matt Gibson 528af15eb0
Do not use deprecated method (#3155) 2022-07-22 11:41:02 -05:00
github-actions[bot] 90c91e0a7d
Autosync the updated translations (#3156)
Co-authored-by: github-actions <>
2022-07-22 09:06:45 +02:00
Shane Melton 9eefb4ad16
[PS-94] Ensure autofill always uses the same tab (#3066)
* Require specifying a tab in doAutoFill options to ensure only the desired tab is filled

* Specify well defined type for added tab properties

* Replace new tabToAutoFill property with parameter
2022-07-21 10:56:09 -07:00
Andreas Coroiu acbd789c2b
[PS-683] Fix missed defaults and sentence cases (#3095)
* chore: remove superfluous default

* fix: translations

* feat: dont update auto biometric but hide the option

* feat: hide auto biometrics if biometrics are disabled

* refactor: make updateBiometric easier to read and add bug note

* chore: add comment about bug getting resolved

* refactor: merge two if-cases
2022-07-19 14:51:08 +02:00
Vitaly Baev 0a4b8b15bc
[PS-1122] Adds Mir payment system (#3079)
* Adds Mir payment system

* Fixes Mir regex pattern and formatting

* Changes Mir logos to Russian ones

* Localize Mir in select
2022-07-19 12:20:37 +02:00
Oscar Hinton fbff2e5f00
[PS-1134] Folder fixes, including revamped auth logic (#3118) 2022-07-18 14:39:12 +02:00
Addison Beck eb1cd9ff2a
[fix] File downloads in Safari (#3121) 2022-07-15 13:54:11 -04:00
github-actions[bot] b73dc687b8
Autosync the updated translations (#3115)
Co-authored-by: github-actions <>
2022-07-15 14:43:02 +02:00
Addison Beck 4be301f125
[fix] System theming in the Safari extension (#3107) 2022-07-14 14:47:45 -04:00
Brandon Maharaj 3093c32f76
[SG-329] Disabled Org display (#3050)
* chore: added strings for disabled org messages

* chore: added icon display

* chore: added prevent filter check

* chore: code changes for desktop

* chore: browser
2022-07-14 09:35:22 -04:00
Oscar Hinton 23253b3882
[PS-1078] Refactor FolderService to use Observables (#3022) 2022-07-12 20:25:18 +02:00
Gbubemi Smith 543c84d0fa
renamed minlength error key (#3077) 2022-07-11 19:58:38 +01:00
Oscar Hinton f79c4f0c65
Extract API logic from FolderService to FolderApiService (#3011) 2022-07-08 15:40:31 +02:00
github-actions[bot] 75cf617a50
Autosync the updated translations (#3067)
Co-authored-by: github-actions <>
2022-07-08 08:30:38 +02:00
github-actions[bot] a65964cd97
Bumped browser version to 2022.6.1 (#3060)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-07 07:27:49 -07:00
Robyn MacCallum fb70d8a2d3
Merge Feature/trial initiation (#3036)
* [SG-74] Trial Initiation Component with Vertical Stepper (#2913)

* Vertical stepper PoC

* Convert stepper css to tailwind

* trial component start

* trial component params

* tailwind-ify header

* Support teams, enterprise, and families layout param and more layout ui work

* Some more theming fixes

* Rename TrialModule to TrialInitiationModule

* Stepper fixes, plus more functionality demo

* Cleanup

* layout params and placeholders

* Only allow trial route to be hit if not logged in

* fix typo

* Use background-alt2 color for header

* Move vertical stepper out of trial-initiation

* Create components for the different plan types

* Remove width on steps

* Remove content projection for label

* Tailwind style fixes

* Extract step content into a component

* Remove layout param for now

* Remove step tags

* remove pointer classes from step button

* Remove most tailwind important designations

* Update apps/web/src/app/modules/vertical-stepper/vertical-step.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Tailwind and layout fixes

* Remove container

* lint & prettier fixes

* Remove extra CdkStep declaration

* Styles fixes

* Style logo directly

* Remove 0 margin on image

* Fix tiling and responsiveness

* Minor padding fixes for org pages

* Update apps/web/src/app/modules/trial-initiation/trial-initiation.component.html

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* prettier fix

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* [SG-65] Reusable Registration Form (#2946)

* created reusable registration form

* fixed conflicts

* replicated reactive form changes in other clients

* removed comments

* client template cleanup

* client template cleanup

* removed comments in template file

* changed to component suffix

* switched show password to use component

* comments resolution

* comments resolution

* added toast disable functionality

* removed unused locale

* mode custom input validator generic

* fixed button

* fixed linter

* removed horizontal rule

* switched to button component

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
2022-07-05 15:25:14 -04:00
github-actions[bot] a2360aebd2
Autosync the updated translations (#3021)
Co-authored-by: github-actions <>
2022-07-01 08:06:15 +02:00
Addison Beck bb7dce031c
[fix] Force send attachment to always download and never open (#2908)
* [refactor] Introduce a file download service

* [refactor] Point platformUtilsService.saveFile() callers to fileDownloadService.download() instead

* [refactor] Remove platformUtilsService.saveFile()

* [fix] Force send attachments to always download and never open

* [fix] Remove the window property from FileDownloadRequest

* [fix] Move FileDownloadRequest to /abstractions/fileDownload

* [fix] Simplify FileDownloadRequest to a type

* [fix] Move BrowserApi.saveFile logic into BrowserFileDownloadService

* [fix] Use proper blob types for file downloads

* [fix] forceDownload -> downloadMethod on FileDownloadRequest

* [fix] Remove fileType from FileDownloadRequest

* [fix] Make fileType private
2022-06-29 17:15:29 -04:00
Patrick H. Lauke 3bf1aa5053
[PS-1029] Browser: suppress `user-select` for most interface elements (#2674)
* Browser: suppress `user-select` for most interface elements

* Remove orphaned jslib folders
2022-06-29 20:08:49 +02:00
github-actions[bot] 0d36c94068
Bumped browser version to 2022.6.0 (#3003)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-29 11:22:11 -05:00
Matt Gibson 399b8c2b34
PS-813 Add memory storage to state service (#2892)
* Use abstract methods and generics in StorageService

* Prepend `Abstract` to abstract classes

* Create session browser storage service

* Use memory storage service for state memory

* Inject memory storage service

* Maintain filename extensions to help ide formatting

* Preserve state if it's still in memory

* Use jslib's memory storage service

* linter

* Create prototypes on stored objects

* standardize package scripts

* Add type safety to `withPrototype` decorators

* webpack notify manifest version

* Fix desktop

* linter

* Fix script

* Improve prototye application

* do not change prototype if it already matches desired
* fix error with object values prototype application

* Handle null state

* Apply prototypes to browser-specific state

* Add angular language server to recommended extensions

* Improve browser state service tests

* Start testing state Service

* Fix abstract returns

* Move test setup files to not be picked up by default glob matchers

* Add key generation service

* Add low-dependency encrypt service

* Back crypto service with encrypt service.

We'll want to work items that don't require state over to encrypt service

* Add new storage service and tests

* Properly init more stored values

* Fix reload issues when state service is recovering state from session storage

Co-authored-by: Thomas Avery <Thomas-Avery@users.noreply.github.com>
Co-authored-by: Justin Baur <admin@justinbaur.com>

* Simplify encrypt service

* Do not log mac failures for local-backed session storage

* `content` changed to `main` in #2245

* Fix CLI

* Remove loggin

* PR feedback

* Merge remote-tracking branch 'origin/master' into add-memory-storage-to-state-service

* Fix desktop

* Fix decrypt method signature

* Minify if not development

* Key is required

Co-authored-by: Thomas Avery <Thomas-Avery@users.noreply.github.com>
Co-authored-by: Justin Baur <admin@justinbaur.com>
2022-06-27 12:38:12 -05:00
Gbubemi Smith 37e46dab48
[PS-968] regression bug fix on custom timeout switch for the browser (#2969)
* regression bug fix on custom timeout switch for the browser

* regression bug fix on custom timeout switch for the browser

* locale key fix

* suggestion fixes
2022-06-24 23:19:55 +01:00
Brandon Maharaj af8f83980f
fix: changed param (#2964) 2022-06-24 12:46:16 -04:00
github-actions[bot] 96a280916a
Autosync the updated translations (#2967)
Co-authored-by: github-actions <>
2022-06-24 13:12:03 +02:00
Addison Beck e00fe8edae
[fix] Unsubscribe from activeAccount in AppComponent (#2960) 2022-06-23 09:38:12 -04:00
Addison Beck 57b8144013
[refactor] Introduce ThemingService (#2943)
* [refactor] Introduce ThemingService

* [refactor] Implement ThemingService for web

* [refactor] Implement ThemingService on browser

* [refactor] Implement ThemingService for desktop

* [refactor] Remove deprecated platformUtils.service theme methods

* [fix] Move ThemingService from libs/common to libs/angular

* [fix] Simplify ThemeBuilder's constructor

* [fix] Dont notify subscribers of null values from theme$

* [fix] Always notify PaymentComponent of theme changes
2022-06-23 07:36:05 -04:00
Andreas Coroiu fd69e163ff
[PS-683] Update negative copy (#2912)
* feat(browser): Update auto biometrics copy

* refactor(common): remove TotpService.isAutoCopyEnabled and use state directly

The TotpService was just taking the value from StateService and forwarding it, making it depend on state service.
All services that depended on the TotpService.isAutoCopyEnable flag also depended on StateService.
This therefore simplifies things by using StateService directly.

* feat(browser): update auto totp copy

* feat(browser): update add login notification copy

* feat(browser): update change password notification copy

* feat(browser): update context menu copy

* feat(browser): update show cards current tab copy

* feat(browser): update show identities current tab copy

* feat(browser): update enable favicon copy

* feat(browser): update badge counter copy

* feat(browser): update auto-fill copy

* feat(desktop): update auto biometrics prompt copy

* feat(desktop): update favicon copy

* feat(desktop): adjust copy

* feat(web): update favicons copy

* feat(web): adjust copy

* feat(web): update preference settings to sentence case

* feat(browser): update settings and options page to sentence case

* feat(desktop): update settings to sentence case

* feat(web): update copy

* feat(desktop): update copy
2022-06-23 09:53:42 +02:00
Oscar Hinton 19caa7bfe0
Simplify our gitignore files (#2925) 2022-06-17 15:33:51 +02:00
github-actions[bot] bc15e3e120
Autosync the updated translations (#2921)
Co-authored-by: github-actions <>
2022-06-17 06:38:13 +02:00
Oscar Hinton bc639688e8
Use NPM workspace (#2874) 2022-06-14 17:10:53 +02:00
Matt Gibson c4ff8f99dc
Multi root workspace tweaks (#2858)
* Ignore jest for workspaces without tests (for now)

* Add jest as recommended extension

* Set eslint and prettier file paths

We can't do this on a multi-folder workspace level because the
path depths are not identical between folders

* fix tsconfig extends for

* Simplify bitwarden-licensed web tsconfig

This tsconfig isn't needed to build, since we do that through webpack
and the web client. It's only needed as hints to IDEs

* Remove unintended change

* linter
2022-06-13 21:39:36 -05:00
Thomas Rittson 3b857345bb
Update README and CONTRIBUTING to point to contributing.bitwarden.com (#2771)
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2022-06-13 17:34:07 +10:00
github-actions[bot] 2fcd385f0a
Autosync the updated translations (#2882)
Co-authored-by: github-actions <>
2022-06-10 16:11:32 +02:00
Jake Fink 75f05f669f
Feature/manifest v3 migration (#2889)
* migrate manifest to v3

* undo manifest changes for V3

* add separate manifest for v3

* use cross-env
2022-06-10 09:41:34 -04:00
Vince Grassia e1039edaeb
Fix extName for the 'fil' locale (#2865) 2022-06-08 14:00:31 -04:00
github-actions[bot] 76098a33a7
Autosync the updated translations (#2854)
Co-authored-by: github-actions <>
2022-06-07 21:41:11 +02:00
github-actions[bot] 8cf9699ba0
Autosync the updated translations (#2817)
Co-authored-by: github-actions <>
2022-06-07 15:55:04 +02:00
github-actions[bot] c7cd0c2810
Bumped browser version to 2022.5.0 (#2840)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-06 08:34:36 -07:00
Oscar Hinton 5780bf85e7
Add support for migrated jslib (#2826) 2022-06-03 18:01:07 +02:00
Matt Gibson d026c99361
Fix TOTP copy action (#2774)
Fixes an issue where password copy was sometimes populated with a totp
2022-06-02 13:40:36 -05:00
Oscar Hinton 12c4a3e7f8
[EC-236] Move dependencies to root package.json (#2720) 2022-06-02 15:18:29 +02:00
github-actions[bot] dac02ed11d
Bumped browser version to 2022.05.0 (#2768)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-01 15:23:28 -04:00
CarleyDiaz-Bitwarden 8de7f522c6
Ps 575 pop out (#2705)
* Disable the ability to open infinite popouts in the browser

* fixing lint error

* Adding padding

* Updating code to use ngIf instead of show for the app-pop-out
2022-06-01 11:40:32 -04:00
Oscar Hinton 579cee3364
Migrate cli to jest (#2759)
* Migrate cli to jest

* Remove jasmine from browser

* Remove coverage from browser since it's in the root gitignore
2022-05-31 16:29:10 +02:00
Gbubemi Smith ccfcb36f1c
sync jslib master with client (#2753) 2022-05-27 19:09:01 +01:00
Thomas Rittson 6a861d4fcd
Update jslib (#2751) 2022-05-27 13:11:45 +10:00
Thomas Rittson 8519decb7c
[EC-177] Update Key Connector error handling (#2748)
* Update jslib, deps and messages.json
2022-05-26 11:16:05 +10:00
Addison Beck 06e25147cd
[fix] Reload organization filter options on sync complete (#2696)
* [fix] Reload organization filter options on sync complete

* [dep] Update jslib
2022-05-17 21:08:29 -04:00
Robyn MacCallum 58611fdd00
[SG-300] Adding an Item defaults owner to selected vault (#2697) 2022-05-17 17:03:57 -04:00
Robyn MacCallum 076b0cbf1f
[SG-286] Allow vault filter to be scrollable (#2687)
* Switch to programmatic CdkOverlay instead of directive

* lint && prettier
2022-05-16 12:32:19 -04:00
Robyn MacCallum fae7fd9378
Show folders and properly filter collections (#2688) 2022-05-16 12:18:04 -04:00
Robyn MacCallum b11e13007c
Fix small browser filter bugs (#2684) 2022-05-13 13:55:11 -04:00
Addison Beck d8dbb15d24
[fix] Organization switcher not loading on initial login (#2681) 2022-05-13 12:34:26 -04:00
Kyle Spearrin 4f0e5a8592
remove hostname from simplelogin. update jslib (#2680)
* remove hostname from simplelogin. update jslib

* remove root jslib
2022-05-13 12:24:50 -04:00
Thomas Rittson 2a11b2c534
Update jslib (#2677) 2022-05-11 12:10:04 +10:00
Oscar Hinton 894903cc02
[PS-569] Fix sends having the inverse condition for disabled (#2675) 2022-05-10 23:02:25 +02:00
Vince Grassia c260464f96
Fix Crowdin Pull workflow (#2667) 2022-05-10 10:20:32 -04:00
Oscar Hinton 699199d033
Fix browser build failing (#2670) 2022-05-10 12:25:46 +02:00
Oscar Hinton ec723fd057
[EC-194] Migrate browser to jest (#2646)
* Move browser to jest

* Remove karma from package.json

* Remove karma from eslintignore
2022-05-10 10:25:35 +02:00
Oscar Hinton c402adeec5
[EC-193] Remove the symlink scripts (#2644) 2022-05-09 18:09:02 +02:00
Vince Grassia 0e1aacc7f2
Fix Crowdin Push for Build Workflows (#2665) 2022-05-09 09:53:48 -04:00
Robyn MacCallum 8c12ba20cb
[Feature] End User Vault Refresh (#2545)
* Initial org filter work

* update jslib

* Move filter to below cipher length check

* don't show vault filter in personal or org folder

* Use family icon for families org

* jslib and auth guard updates

* lint fixes

* rename GroupingsComponent to VaultFilterComponent

* fix no folder showing all items

* Add checks for PersonalOwnership policy

* update css class names

* lint fixes

* cleanup

* Some final cleanup

* import order lint fix

* remove unused import

* Use smaller icon for chevron

* Update src/popup/vault/organization-filter.component.ts

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>

* Update src/popup/vault/organization-filter.component.ts

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>

* fix lint error

* remove extra localizations

* rename orgFilter -> vaultSelect

* Rename orgFilterService to VaultSelectService

* lint fixes

* combine vault select service with vault filter service

* Use base vault filter service methods

* Use VaultFilter model and other small fixes

* lint fixes

* Final restructuring pass

* Update jslib and remove extra function

* Remove extra imports

* remove space

* Remove vaultFilterService from background services

* Update jslib to latest on feature branch

* merge fix

* update jslib

* [feat] Implement EUVR for desktop

Should contain only https://github.com/bitwarden/desktop/pull/1487, with merge resolutions and style fixes

* [fix] Delete unused GroupingsComponentTemplate

* [dep] Update jslib

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>
2022-05-09 08:19:18 -04:00
Patrick H. Lauke fd434dfed8
Remove underline from focused buttons/controls (#2651) 2022-05-09 10:56:17 +02:00
Daniel James Smith 3db2848cac
Fix lint issues (#2656) 2022-05-07 22:30:57 +02:00
Patrick H. Lauke a4a6f12120
[PS-557] Browser: Accessibility - change send list controls to buttons, make them keyboard-operable, improve screen reader experience (#2540)
* Change send list controls to buttons

make them keyboard focusable/operable

* Fix width/display of sends

* Make `.row-btn.disabled` also apply to natively `disabled` buttons without need for class

* Change accessible name for send group to use the send's name, not generic "Edit item" title
2022-05-07 19:51:37 +02:00
Patrick H. Lauke 5e0f8bd870
Fix vertical alignment of expandable header chevron (#2652) 2022-05-07 19:42:20 +02:00
Patrick H. Lauke 5bd681a6dd
Add `aria-pressed` to URI toggles, remove `appBlurClick` (#2654) 2022-05-07 17:53:45 +02:00
Daniel James Smith 107ba56fbc
Crowdin-Pull: Fix paths in browsers crowdin.yml (#2641) 2022-05-06 23:05:59 +02:00
Kyle Spearrin 5e731fb328
add appApiAction to username generation (#2549) 2022-05-06 09:07:30 -04:00
Oscar Hinton 912f3b0d46
Rename repo to clients (#2548) 2022-05-05 16:54:48 +02:00
Patrick H. Lauke 5434d7cbbd
Minor: correct markdown for image/alt (#2539) 2022-05-04 13:45:09 +02:00
Oscar Hinton c1cc5a0814
[EC-183] Move eslint and prettier to project root (#2536) 2022-05-03 21:45:37 +02:00
Oscar Hinton 04ab35f69b
[EC-183] Bump jslib to match the expected version (#2534) 2022-05-03 20:25:18 +02:00
Oscar Hinton 3aa7570020
[EC-183] Mono Repository - Readme (#2532)
* Update GH issue templates, contributing and readme
2022-05-03 19:47:56 +02:00
Oscar Hinton 7fe51f83da
[EC-183] Mono Repository - Browser (#2531) 2022-05-03 19:38:55 +02:00