Commit Graph

38 Commits

Author SHA1 Message Date
Thomas Rittson 306aef73d4
Increase error checking on imported Login items (#369)
* Increase error checking on imported Login items

* Check encKey when importing encrypted JSON

* Fix style, use GUID as random string for test

* Revert "Increase error checking on imported Login items"

This reverts commit 17294527863cc53b84ed218f94ffbc21f4e96260.

* fix linting

* Fix tests
2021-05-13 10:58:59 +10:00
Daniel James Smith 1eb40a4891
Add support to import from Nordpass(.csv) (#360)
* Add support for parsing .csv files from Nordpass

* Remove whitespace before extracting CardExpiration

* Add curlybraces to one-liner if's as requested

* NordPassImporter: Process more complex names
2021-04-29 06:51:35 -04:00
Daniel James Smith e298ecfee3
Add import of totp from Lastpass (#361)
* Add import of totp from Lastpass

* Fixed import as request during review
2021-04-28 16:50:37 -04:00
Oscar Hinton aca098645a
Bump dependencies (#350)
* Bump dependencies
2021-04-22 21:17:14 +02:00
Matt Gibson 3a1087456f
Rename CipherString and CipherArrayBuffer to Enc (#352) 2021-04-20 19:16:19 -05:00
Matt Gibson 0a0cdaa7fd
Fix cipher upload (#346)
* Upload correct data array

* Require BufferArray Encryption for upload to server

The CipherArrayBuffer tiny type is only created by CryptoService
and required by all upload methods

* Add test for attachment upload encryption
2021-04-14 10:47:10 -05:00
Tomasz Zdybał 827674847f
Skip FirefoxAccounts during Firefox CSV Import (#323)
* Skip FirefoxAccounts during Firefox CSV Import

Firefox exports 'chrome://FirefoxAccounts' if Firefox Accouts are used
in browser. It's quite hacky - password field in CSV is actually a JSON
encoded data, not a password.
Because it's not a useful record, it should be skipped during import.

* Fix indentation

* Move test Firefox test data to files, fix linter errors
2021-04-12 12:08:56 -05:00
Daniel James Smith c7ac645eb7
Fixes linting error introduced with PR #307 (#309) 2021-03-17 17:14:10 -04:00
Paul Sieben a36f1c25d8
Enhance SafeInCloud import (#307)
* don't import deleted cards

* keep favourite status while importing from saveInCloud

* import all passwords from saveInCloud

* add test data
2021-03-16 15:06:12 -05:00
Matt Gibson 2730e04a05
Match tslint rules (#264) 2021-02-08 14:11:44 -06:00
Matt Gibson 58f40b0085
Fix glob processing in npm. Ban single param parens (#257) 2021-02-04 09:49:23 -06:00
Matt Gibson 1420082348
Do not export trashed items (#241)
* Do not export trashed items

* Test Item exporting

Does not test organization export. Export's use of apiService is not
very testable. We will either need a testApiService or to refactor
apiService to make mocking easier.

* Linter fixes
2020-12-30 15:08:02 -06:00
Matt Gibson 2c414ce27a
Use log service for console messages (#221)
* Use logService for console messages

* Implement a base ConsoleLog service

Use this class as a default for other services that would like to output
to console. This service is overriden in CLI and Desktop to use CLI's
consoleLogService and electronLogService, respectively.

* Use browser-process-hrtime for timing

* test LogService implementations

* Ignore default import of hrtime

* Clean up imports. Require ConsoleLog injection

Co-authored-by: Matt Gibson <mdgibson@Matts-MBP.lan>
2020-12-11 10:44:57 -06:00
Matt Gibson 72bf18f369
Fix 1password importer (#222)
* Change cipher type based on csv type header

* Test identity and credit card import

* Do not use node 'fs' module

Karma is being used for automated tests so node modules are not available

* WIP: mac and windows 1password importer split

Need to improve windows field identification to limit secret data
exposure and improve user experience

* Hide fields with likely secret values

Co-authored-by: Matt Gibson <mdgibson@Matts-MBP.lan>
2020-12-08 11:29:57 -06:00
Kyle Spearrin dcbd09e736
encrypted import for bitwarden json (#220) 2020-12-04 21:05:11 -05:00
Matt Gibson 6fb0646481
Fix 1password importer (#217)
* Fix import of 1password csv

* 1password is using '\' as a quote escape character.

* 1password's csv headers are sometimes capitalized. We want to identify
them case insensitively

* Change cipher type based on csv type header

* Translate 1password data to correct fields

* Test identity and credit card import

* linter fixes

* Do not use node 'fs' module

Karma is being used for automated tests so node modules are not available

Co-authored-by: Matt Gibson <mdgibson@Matts-MBP.lan>
2020-12-04 12:29:31 -06:00
Chad Scharf 5e0a2d1d99
remove old Edge browser hacks (#168)
* remove old Edge browser hacks

* Remove final edge hacks

* Update constructor parameters

* Update search-ciphers.pipe.ts

Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
2020-09-15 10:23:21 -04:00
mtgto d6c9acdf6f
Add noImplicitAny to tsc compiler options (#86) 2020-03-11 09:00:14 -04:00
Kyle Spearrin 76f60dd99e fix lastpass importer tests 2020-02-06 15:28:17 -05:00
Reese eecd774b13
fix lastpass import credit card expiration (#65)
* Fix import of expiration date from LastPass

Signed-off-by: Felipe Santos <felipecassiors@gmail.com>

* handle empty cc exp from lastpass, add test

* check for month/year null/whitespace

* check for empty expiration from lp import

Co-authored-by: Felipe Santos <felipecassiors@gmail.com>
2020-02-06 11:24:18 -05:00
jgfaust c91ab626c2 The domain of data URLs should be null. (#59) 2020-01-25 07:52:51 -05:00
Kyle Spearrin a0a1142f1f Revert "dont sequentialize in throttle spec"
This reverts commit 8edc99dfd1.
2019-04-19 19:46:48 -04:00
Kyle Spearrin 8edc99dfd1 dont sequentialize in throttle spec 2019-04-19 17:41:33 -04:00
Kyle Spearrin f39bdc4269 fix lint issues 2019-03-27 14:46:34 -04:00
Kyle Spearrin 58c34b896c sort and limit password history parsing 2019-03-25 09:10:33 -04:00
Robert Wachs 8ed27eeeec 1password 1pif: import password history (#33)
* 1password 1pif import password history

* 1password 1pif importer: process windows password history

* linter fix
2019-03-24 10:50:49 -04:00
Kyle Spearrin df429fe178 country is now upper 2019-03-23 22:49:22 -04:00
Robert Wachs 2bd47a19df 1password 1pif importer: create identity records (#34)
* 1password 1pif importer: create identity records

* importer: do not store empty strings

replace them with null instead
2019-03-23 22:21:43 -04:00
Kyle Spearrin c17e8b458c use single quote 2019-03-23 12:31:52 -04:00
Robert Wachs f874ec253d 1password 1pif importer: create hidden fields (#32)
* allow base importer to receive custom field type

* 1password importer uses hidden field type

for custom fields marked as 'concealed'

* 1password 1pif importer specs

* remove 'focus' from specs

* change field type logic into simple one liner
2019-03-23 12:27:50 -04:00
Kyle Spearrin 93244b5c90 use jsdom for DOMParser 2019-02-07 16:55:49 -05:00
Fred Cox db37a831e4 Throttle calls to HIBP api (#25)
Randomly failing to check by passwords, I'm pretty sure its because ~2000 connections are made at the same time.
2019-02-02 10:17:44 -05:00
Fred Cox e7f4dccfc3 Clear sequentialize cache when empty to remove chance of memory leaks (#26) 2019-02-02 09:23:16 -05:00
Kyle Spearrin ad97afc590 move getDomain to jslib Utils 2018-10-13 22:21:54 -04:00
Kyle Spearrin d07ee4c01b fix sequentialize tests 2018-07-23 15:32:22 -04:00
Fred Cox 04014a8e78 Add sequentialize to prevent parralel loading of cipher keys (#7)
* Add sequentialize to prevent parralel loading of cipher keys

Massively improves start up performance of extensions

* Add tests for sequentialize

* Fix sequentialize as it was caching calls for all instances together

* Add sequentialize to the functions that have internal caches

* Adding sequentialize to getOrgKeys makes big performance difference

* Update cipher.service.ts

* Update collection.service.ts

* Update folder.service.ts
2018-07-23 14:23:30 -04:00
Kyle Spearrin 87ac298af9 web crypto testing. more test browsers 2018-05-07 11:43:14 -04:00
Kyle Spearrin 0fa9fc58eb refactor utils service to utils 2018-04-23 13:03:47 -04:00