Commit Graph

16724 Commits

Author SHA1 Message Date
Chandra Mauli Sharma ea2f95e226
fix: Add new item should set item type (bitwarden#10994) (#11049)
Co-authored-by: cd-bitwarden <106776772+cd-bitwarden@users.noreply.github.com>
2024-11-12 14:37:44 -05:00
Jason Ng 9ec6f45803
[PM-8682] Add Flags for New Device Verification Notice (#11968) 2024-11-12 12:56:25 -05:00
SHASHI KUMAR KASTURI aa04d84c11
[PM-14627] Import TOTP with ZohoVault CSV importer (#11912)
* totp secret is assigned to cipher object in zohovalut-csv-importer to populate when importing keys from zoho vault fixes #11872 closes #11872

* fixed issue#11872

* assigned full totp url to cipher object and also implemented unit tests for zohovault importer

* Add test to when no data is passed to the importer

* Fix import of folders

- Replace "Chambername" with "Folder Name"
- Add tests for importing folders and collections

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-11-12 18:47:25 +01:00
Jason Ng 40f2e15cec
[PM-13895] Autofocus on Vault Search Browser (#11888)
* use appAutoFocus directive for browser vault v2 search
2024-11-12 10:38:48 -05:00
Daniel James Smith ac0e008e3c
[PM-8506] Create importer for csv-export from Netwrix Password Secure (#9446)
* Create an importer for csv-export from Netwrix Password Secure

* Wire the new importer into the clients

* Add instructions to export from Netwrix Password Secure

* Mark method as private

* Remove line which disables linting

* Add docs to importer

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-12 16:07:42 +01:00
renovate[bot] cab1156d63
[deps] Platform: Update Rust crate thiserror to v1.0.69 (#11944)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 15:17:00 +01:00
renovate[bot] 5592d640a8
[deps] Autofill: Update tldts to v6.1.60 (#11939)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 17:08:50 -05:00
Matt Bishop 5755d4b3a8
Use correct event and branch targets for some workflow steps (#11961) 2024-11-11 16:38:03 -05:00
renovate[bot] 47c7a657b7
[deps]: Update uuid to v11.0.3 (#11948)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 16:37:31 -05:00
Shane Melton 96c9e3f92f
[PM-14418] Add security-tasks feature flag (#11962) 2024-11-11 16:07:30 -05:00
✨ Audrey ✨ ba82a31851
[PM-14001] do not store last value when it is 0 (#11964) 2024-11-11 15:43:50 -05:00
Brandon ed3ec8ef39
[PM-11332] Prevent dead object error in Firefox due to timing issue (#10720)
* Prevent dead object error from race condition when closing the popup in Firefox

* Add await to async call to resolve timing issue

* Remove comment
2024-11-11 11:56:14 -08:00
Lorenz Brun 6d89c0f157
fido2-utils: fix BufferSource conversions (#11784)
The original implementation of bufferSourceToUint8Array was incorrect as
it did not consider that TypedArray instances represent a view of the
underlying ArrayBuffer which does not necessarily cover the entire
backing ArrayBuffer. This resulted in the output of this function
containing data which would not be logically contained in the input.

This was partially fixed by #8787 for the common case of the input
already being an Uint8Array, but it was still broken for any other
TypedArrays. But #8222 introduced another copy of the original broken
code, breaking the Uint8Array case again.

Fix this once and hopefully for the last time with a correct
implementation of bufferSourceToUint8Array and using that in the
appropriate places instead of open-coding it. In addition there are now
tests which exercise most edge cases with regards to ArrayBuffer and
TypedArrays.
2024-11-11 14:54:36 -05:00
✨ Audrey ✨ a5294bed3d
[PM-12338] fix length hint on passphrase num words field (#11963) 2024-11-11 14:23:02 -05:00
Nick Krantz e87cc5896b
delete ciphers as an admin when they're unassigned (#11930) 2024-11-11 12:46:51 -06:00
Matt Bishop 80c71c191b
Check run earlier during setup (#11958) 2024-11-11 13:19:33 -05:00
aj-bw 4963b28b82
PM-14810/ssh-not-all-caps-on-web-vault-item-type (#11957) 2024-11-11 11:35:59 -05:00
Alec Rippberger f0901b0b98
Redirect to signup page if email verification flag is enabled (#11910) 2024-11-11 16:16:58 +00:00
cyprain-okeke f593269133
[PM-8161] Payment optional trial MVP (#10872)
* Initial comment

* Add changes for the create org with payment method

* Add the secrets manager trail flow

* Add the banners

* Add changes for the Disabled Org

* Add banner to payment method page

* Refactoring changes

* Resolve the bug on tha payment method

* Resolve lint error

* Resolve Pr comments

* resolve the lint issue

* Resolve the lint wrong file issue

* Rename object properly

* Resolve pr comments from sm team

* Resolve the pr comments from sm team

* Fix the failing test

* Resolve some issue with vault

* Resolve the comments from sm team

* Resolve some pr comments from vault team

* Resolve pr comments from auth team

* Exported ValidOrgParams enum

* Removed unnecessary interpolation

* Corrected bit-banner id for trial

* Resolve pr comments from auth team

* Resolve pr comments from auth team

* Removed unnecessary method

* Made OrganizationCreateRequest a subtype of OrganizationNoPaymentMethodCreateRequest

* Resolve review changes from sm

* Resolve review changes from dm

* Resolve the pr comments from billing

* move the free-trial to core

* Move free-trial change to right file

* Revert changes on the free trial  page

* Resolve the comment on protected trial page

* Resolve the comment on protected trial page

* Revert the next async change

* resolve pr comment fro vault team

* resolve the default message comments

* remove unused method

* resolve email sending issue

* Fix the pop issue on payment method

* Fix some console errors

* Fix the pop refresh page

* move the trial services to billing folder

* resolve pr comments

* Resolve the import issues

* Move the observable up

* Resolve blank payment method for trialing org

* Changes to  disable icon is removed onsubmit

* Remove unused references

* add a missing a period at the end of it

* resolve the reload issue

* Resolve the disable icon issue

* Fix the admin access bug

* Resolve the lint issue

* Fix the message incorrect format

* Formatting fixed

* Resolve the access issue of other users role
2024-11-11 17:05:37 +01:00
✨ Audrey ✨ 888b9e346c
fix length allowing negative values on Chrome extension (#11926) 2024-11-11 16:48:32 +01:00
renovate[bot] 19e786f820
[deps] Platform: Update Rust crate tokio-util to v0.7.12 (#11946)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 14:14:06 +01:00
renovate[bot] 2f4a8d1e0b
[deps] Platform: Update webpack to v5.96.1 (#11319)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 14:08:24 +01:00
Daniel García 597296cdb8
Fix electron-log test (#11955) 2024-11-11 12:51:13 +01:00
renovate[bot] 25f00513c0
[deps] Platform: Update Rust crate libc to v0.2.162 (#11731)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 12:39:34 +01:00
renovate[bot] 33e3b28ee8
[deps] Platform: Update electron-log to v5.2.2 (#10207)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 12:19:03 +01:00
Rui Tomé 19046aa033
[PM-10326] Hide 'remove' option for organization managed members (#11874)
* Hide 'remove' option for organization managed members

* Refactor member component to conditionally show remove and delete buttons based on account deprovisioning feature flag

* Refactor member dialog component to conditionally show remove and delete buttons based on account deprovisioning feature flag

* Refactor member dialog and members components to simplify conditional rendering of remove and delete buttons based on account deprovisioning feature flag
2024-11-11 10:51:13 +00:00
Jonas Hendrickx 2bbe4d2cba
[PM-13470] Allow creating clients for multi-org providers (#11890) 2024-11-11 07:57:09 +01:00
Shane Melton e91741b146
[PM-13892] Update item more options component to react to changes to the cipher input (#11914) 2024-11-08 11:43:33 -05:00
renovate[bot] 72e7e295ba
[deps] AC: Update html-loader to v5.1.0 (#10573)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-08 15:25:45 +00:00
renovate[bot] b342fe3cca
[deps] AC: Update core-js to v3.39.0 (#10571)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-08 15:21:22 +00:00
renovate[bot] a98cfb1ae2
[deps] AC: Update postcss to v8.4.47 (#10007)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-08 15:03:42 +00:00
github-actions[bot] 0a9dbe17e3
Autosync the updated translations (#11917)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 11:25:03 +00:00
Rui Tomé 1f0c1f1b44
[PM-10318] Add organization user deletion and leaving events to EventService (#11554) 2024-11-08 11:23:24 +00:00
Bernd Schoolmann 081fe83d83
PM-10393 SSH keys (#10825)
* [PM-10395] Add new item type ssh key (#10360)

* Implement ssh-key cipher type

* Fix linting

* Fix edit and view components for ssh-keys on desktop

* Fix tests

* Remove ssh key type references

* Remove add ssh key option

* Fix typo

* Add tests

* [PM-10399] Add ssh key import export for bitwarden json (#10529)

* Add ssh key import export for bitwarden json

* Remove key type from ssh key export

* [PM-10406] Add privatekey publickey and fingerprint to both add-edit and view co… (#11046)

* Add privatekey publickey and fingerprint to both add-edit and view components

* Remove wrong a11y title

* Fix testid

* [PM-10098] SSH Agent & SSH Key creation for Bitwarden Desktop (#10293)

* Add ssh agent, generator & import

* Move ssh agent code to bitwarden-russh crate

* Remove generator component

* Cleanup

* Cleanup

* Remove left over sshGenerator reference

* Cleanup

* Add documentation to sshkeyimportstatus

* Fix outdated variable name

* Update apps/desktop/src/platform/preload.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Rename renderersshagent

* Rename MainSshAgentService

* Improve clarity of 'id' variables being used

* Improve clarity of 'id' variables being used

* Update apps/desktop/src/vault/app/vault/add-edit.component.html

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix outdated cipher/messageid names

* Rename SSH to Ssh

* Make agent syncing more reactive

* Move constants to top of class

* Make sshkey cipher filtering clearer

* Add stricter equality check on ssh key unlock

* Fix build and messages

* Fix incorrect featureflag name

* Replace anonymous async function with switchmap pipe

* Fix build

* Update apps/desktop/desktop_native/napi/src/lib.rs

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Revert incorrectly renamed 'Ssh' usages to SSH

* Run cargo fmt

* Clean up ssh agent sock path logic

* Cleanup and split to platform specific files

* Small cleanup

* Pull out generator and importer into core

* Rename renderersshagentservice to sshagentservice

* Rename cipheruuid to cipher_id

* Drop ssh dependencies from napi crate

* Clean up windows build

* Small cleanup

* Small cleanup

* Cleanup

* Add rxjs pipeline for agent services

* [PM-12555] Pkcs8 sshkey import & general ssh key import tests (#11048)

* Add pkcs8 import and tests

* Add key type unsupported error

* Remove unsupported formats

* Remove code for unsupported formats

* Fix encrypted pkcs8 import

* Add ed25519 pkcs8 unencrypted test file

* SSH agent rxjs tweaks (#11148)

* feat: rewrite sshagent.signrequest as purely observable

* feat: fail the request when unlock times out

* chore: clean up, add some clarifying comments

* chore: remove unused dependency

* fix: result `undefined` crashing in NAPI -> Rust

* Allow concurrent SSH requests in rust

* Remove unwraps

* Cleanup and add init service init call

* Fix windows

* Fix timeout behavior on locked vault

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix libc dependency being duplicated

* fix SSH casing (#11840)

* Move ssh agent behind feature flag (#11841)

* Move ssh agent behind feature flag

* Add separate flag for ssh agent

* [PM-14215] fix unsupported key type error message (#11788)

* Fix error message for import of unsupported ssh keys

* Use triple equals in add-edit component for ssh keys

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: aj-bw <81774843+aj-bw@users.noreply.github.com>
2024-11-08 11:01:31 +01:00
renovate[bot] 2c914def29
[deps] Platform: Update macOS/iOS bindings (#11793)
* [deps] Platform: Update macOS/iOS bindings

* fix: update security-framework to support core-foundation 0.10.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2024-11-08 10:02:31 +01:00
Jordan Aasen d69642e7a0
[PM-14468] - add feature flag for critical apps (#11871)
* rename acess intelligence to risk insights

* keep branch name

* replace all instances of AccessIntelligence. strip raw data + members to just the table

* revert change to feature flag name

* add feature flag for critical apps

* change flag name

* Update libs/common/src/enums/feature-flag.enum.ts

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-11-07 16:39:15 -08:00
github-actions[bot] b4428160ca
Autosync the updated translations (#11916)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 00:32:02 +00:00
github-actions[bot] d40c1bad73
Autosync the updated translations (#11915)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 00:30:18 +00:00
Daniel James Smith b23d62a280
[PM-14183] Show success toast on copy history value (#11911)
* Remove unnecessary copy icon

* Fix styling of copy success toast
- Use CopyClick directive instead of manually copying and showing the toast
- Adjust tests

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-07 15:28:32 -08:00
Victoria League e8dac0cc12
[CL-500] Add disclosure component and directive (#11865) 2024-11-07 16:54:49 -05:00
Justin Baur f206e0f817
Move Packages to Platform & KM (#11907) 2024-11-07 16:41:47 -05:00
Todd Martin f9098558a6
Update Is-Prerelease header to be integer instead of string (#11909) 2024-11-07 16:00:48 -05:00
Daniel James Smith ec92f82501
Fix wrong import of SendFormModule (#11893)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-07 15:28:40 -05:00
✨ Audrey ✨ b2811e07ce
[PM-14198] zero minimums when the character category is disabled (#11906) 2024-11-07 21:23:01 +01:00
Vince Grassia e95af8269f
Add check for trigger event (#11904) 2024-11-07 15:15:44 -05:00
Vince Grassia 771bfdaccd
Fix quotes (#11902) 2024-11-07 19:42:10 +00:00
Vince Grassia 668ede2dfb
Add event_name check to Deploy Web trigger job (#11901) 2024-11-07 14:38:05 -05:00
Brandon Treston ef0fd60676
[PM-11409] prevent managed user from leaving organization (#11895)
* add check to prevent managed  user from leaving managing org

* remove unused vaiable

* add null check
2024-11-07 14:09:56 -05:00
Matt Bishop db40f20160
Check run permissions for build artifact generation secrets usage (#11897) 2024-11-07 13:01:54 -05:00
Nick Krantz b42741f313
[PM-13839][PM-13840] Admin Console Collections (#11649)
* allow admin console to see all collections when viewing a cipher

- When "manage all" option is selected all collections should be editable

* update cipher form service to use admin endpoints

* when saving a cipher, choose to move to collections first before saving any other edits

- This handles the case where a cipher is moving from unassigned to assigned and needs to have a collection to save any other edits

* set admin flag when the original cipher has zero collections

- handling the case where the user  un-assigns themselves from a cipher

* add check for the users ability to edit items within the collection

* save cipher edit first to handle when the user unassigns themselves from the cipher

* update filter order of collections

* use cipher returned from the collections endpoint rather than re-fetching it

* fix unit tests by adding canEditItems

* re-enable collection control when orgId is present

* fetch the updated cipher from the respective service for editing a cipher
2024-11-07 10:22:35 -06:00