Upgrade Electron to version 24, node to 18 and npm to 9. Electron changed to using node 18 in 23, with node 18 using npm 9 as default.
There doesn't seem to be any breaking changes except the deprecation of Windows 7, 8.1, and Server 2012. A somewhat undocumented breaking change was that elements in the title bar are now draggable which broke the account switching selector. Resolved by adding a no-drag css rule.
- electronjs.org/blog/electron-22-0
- electronjs.org/blog/electron-23-0
- electronjs.org/blog/electron-24-0
The importers recently got extracted from libs/common. As the import functionality is currently limited to the web and cli, there is no need to build browser and desktop as there won't be any changes.
This will free up some runners for other workflows (GH actions) to get faster builds that actually impact browser and desktop.
Another benefit is faster feedback on the PR-checks for those two
* Added new workflow
* Fixed quotes.
* Added step to job.
* Added check for PR destination branch.
* Changed criteria.
* Added fork check for community PRs.
* Removed space
* Changed name.
* Updated with more filters.
* Changed to target approval for adding the label.
* Lint
* Refactored to use pull_request_target instead.
* Fixed comment
* pull_request_target isn't supported, so pull_request instead
* Added comment about target branch.
* Remove cloud web container build. Add QA ACR back in temporarily
* Move selfhost build job into the matrix
* bypassing correct image generation
* fixing linting issues
* Fix output name
* Patch DockerHub upload from server to clients
* Add script to export sha from latest.yaml to files
* Comment out for testing
* Comment out
* Fix
* Remove test comments
* Use new gh action
* Change get checksums action reference to commit hash from master
* Comment out for testing
* Change get-checksum version to branch fix-get-checksum-action
* Comment out gh release if
* Restore if in create release step
* TEst
* Remove comments
* Change path
* Remove unused script
* Add commit SHA for get checksum action
* Update .github/workflows/release-desktop.yml
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
---------
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
* Update the QA deploy workflow to deploy to multiple non-prod environments
* Fix linter issues
* Update with testing code if run with QA
* Fix bash typo
* revert name
* Fix name
* Adding some logging
* Fix environment branch typo
* Add QA configuration and renable
* Rename workflow file
* Update .github/workflows/deploy-non-prod-web.yml
Switch config logic to a more extensible one.
Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com>
* Fix a typo
* Add the original workflow in for QA for no disruptions
* Add line
---------
Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com>
* pkg ref argon2
* add argon to cli package.json
* argon2 assets
* ci matrix for cli
* simplify builds for testing
* fix env
* zip for each os
* add os prefix back to zip
* create checksums
* make sums 256
* fix shasum command
* combine some steps for unix
* LOWER_RUNNER_OS
* SHORT_RUNNER_OS
* SHORT_RUNNER_OS on dist
* upload unix assets
* restore old build files
* fix formatting
* fix zip folder structure
* fix condition on upload unix zip asset
* compute shasum like other parts of build
* change matrix os targets
* Add build command for ee
* Add config for ee
* Add build workflow for ee
* Change build pipeline for web ee
* Fix name of workflow in trigger
* Build ee image in web build workflow
* Fix name on matrix
* FIx name of the artifact
* Comment out zip extract
* Add zip extract
* All listing dir before unzip
* Add pwd
* Comment out unzipping
* Fix
* Add matrix instead of two stages
* Remove build web ee workflow
* Fix name
* Add needs QA to enforce labels
* Update .github/workflows/enforce-labels.yml
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Add tests step to build pipelines
* RUn tests for safari
* Remove tests step to build pipelines
* Run tests on root dir on pr
* Revert "Remove tests step to build pipelines"
This reverts commit 497bd86620.
* CHange name
* Remove working directory
* Add manual trigger
* Comment out cache
* Try to fix
* Revert "Try to fix"
This reverts commit 93d404b7d5.
* Disable failing test
* Updated release jobs to include fixes that Vince recommended from the mobile repo
* Updated the workflows with the fixes
that Vince recommended from mobile.
* Fix linter errors
Co-authored-by: Todd Martin <>
Co-authored-by: Michal Checinski <michal.checinski@outlook.com>
* Fix name
* Fix version reference
* Add release version bump to every job
* Fix release channel name
* Setup git branch
* Change branch name
* Fix name
* Fix download artifact
* Uncomment after testing
* Removed jslib
* Fix comments
mimartin12
renovate[bot]
Todd Martin
Oscar Hinton
Opeyemi
Michał Chęciński
Daniel James Smith
Joseph Flinn
Matt Gibson
Kyle Spearrin
Matt Bishop
Vince Grassia
Opeyemi
Michał Chęciński
sneakernuts
Alexey Zilber
Thomas Rittson