vaultwarden
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

[PM-4087] Add missing await for native-messaging.service (#6708) 

We missed an await which caused the if statement to never be true. This might have had the effect of not showing a browser integration error message when attempting to unlock should biometrics for some reason be unavailable.
This commit is contained in:
Oscar Hinton 2023-11-23 11:23:11 +01:00 committed by GitHub
parent 564bb03038
commit f2aa0ca65f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/desktop/src/services/native-messaging.service.ts
View File

@ -125,8 +125,7 @@ export class NativeMessagingService {
switch (message.command) { switch (message.command) {
case "biometricUnlock": { case "biometricUnlock": {
// eslint-disable-next-line @typescript-eslint/no-misused-promises if (!(await this.platformUtilService.supportsBiometric())) {
if (!this.platformUtilService.supportsBiometric()) {
return this.send({ command: "biometricUnlock", response: "not supported" }, appId); return this.send({ command: "biometricUnlock", response: "not supported" }, appId);
} }