[PM-1176] Hovering over the `Learn More about auto-fill` link in the … (#5300)

* [PM-1176] Hovering over the `Learn More about auto-fill` link in the browser extension does not change the cursor

* [PM-1176] Modifying how the anchor element is formatted by prettier

* [PM-1176] Adding translation methodology to the aria-label "opens in a new window" value
This commit is contained in:
Cesar Gonzalez 2023-05-04 09:17:56 -05:00 committed by GitHub
parent 18b2c60ef8
commit f06c017e42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 5 deletions

View File

@ -2202,5 +2202,8 @@
"example": "CTRL+Shift+L"
}
}
},
"opensInANewWindow": {
"message": "Opens in a new window"
}
}

View File

@ -28,7 +28,17 @@
{{ "enableAutoFillOnPageLoadDesc" | i18n }}
<b>{{ "warning" | i18n }}</b
>: {{ "experimentalFeature" | i18n }}
<a (click)="AboutAutofill()">{{ "learnMoreAboutAutofill" | i18n }}</a>
<a
href="https://bitwarden.com/help/auto-fill-browser/"
target="_blank"
rel="noopener noreferrer"
>
{{ "learnMoreAboutAutofill" | i18n }}.
<i
[attr.aria-label]="'opensInANewWindow' | i18n"
class="bwi bwi-external-link bwi-sm bwi-fw"
></i>
</a>
</div>
</div>
<div class="box">

View File

@ -63,10 +63,6 @@ export class AutofillComponent implements OnInit {
await this.stateService.setDefaultUriMatch(this.defaultUriMatch);
}
AboutAutofill() {
BrowserApi.createNewTab("https://bitwarden.com/help/auto-fill-browser/");
}
private async setAutofillKeyboardHelperText(command: string) {
if (command) {
this.autofillKeyboardHelperText = this.i18nService.t("autofillShortcutText", command);