vaultwarden
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

Remove BulkDeviceApproval feature flag (#9931)

This commit is contained in:
Thomas Rittson 2024-07-11 08:47:49 +10:00 committed by GitHub
parent dbeab65ea5
commit f03dabb6d6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bitwarden_license/bit-cli/src/admin-console/device-approval/device-approval.program.ts
View File

@ -1,7 +1,6 @@
import { program, Command } from "commander"; import { program, Command } from "commander";
import { BaseProgram } from "@bitwarden/cli/base-program"; import { BaseProgram } from "@bitwarden/cli/base-program";
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
import { ServiceContainer } from "../../service-container"; import { ServiceContainer } from "../../service-container";
@ -41,7 +40,6 @@ export class DeviceApprovalProgram extends BaseProgram {
.description("List all pending requests for an organization") .description("List all pending requests for an organization")
.requiredOption("--organizationid <organizationid>", "The organization id (required)") .requiredOption("--organizationid <organizationid>", "The organization id (required)")
.action(async (options: Options) => { .action(async (options: Options) => {
await this.exitIfFeatureFlagDisabled(FeatureFlag.BulkDeviceApproval);
await this.exitIfLocked(); await this.exitIfLocked();
const cmd = ListCommand.create(this.serviceContainer); const cmd = ListCommand.create(this.serviceContainer);
@ -56,7 +54,6 @@ export class DeviceApprovalProgram extends BaseProgram {
.requiredOption("--organizationid <organizationid>", "The organization id (required)") .requiredOption("--organizationid <organizationid>", "The organization id (required)")
.description("Approve a pending request") .description("Approve a pending request")
.action(async (id: string, options: Options) => { .action(async (id: string, options: Options) => {
await this.exitIfFeatureFlagDisabled(FeatureFlag.BulkDeviceApproval);
await this.exitIfLocked(); await this.exitIfLocked();
const cmd = ApproveCommand.create(this.serviceContainer); const cmd = ApproveCommand.create(this.serviceContainer);
@ -70,7 +67,6 @@ export class DeviceApprovalProgram extends BaseProgram {
.description("Approve all pending requests for an organization") .description("Approve all pending requests for an organization")
.requiredOption("--organizationid <organizationid>", "The organization id (required)") .requiredOption("--organizationid <organizationid>", "The organization id (required)")
.action(async (options: Options) => { .action(async (options: Options) => {
await this.exitIfFeatureFlagDisabled(FeatureFlag.BulkDeviceApproval);
await this.exitIfLocked(); await this.exitIfLocked();
const cmd = ApproveAllCommand.create(this.serviceContainer); const cmd = ApproveAllCommand.create(this.serviceContainer);
@ -85,7 +81,6 @@ export class DeviceApprovalProgram extends BaseProgram {
.requiredOption("--organizationid <organizationid>", "The organization id (required)") .requiredOption("--organizationid <organizationid>", "The organization id (required)")
.description("Deny a pending request") .description("Deny a pending request")
.action(async (id: string, options: Options) => { .action(async (id: string, options: Options) => {
await this.exitIfFeatureFlagDisabled(FeatureFlag.BulkDeviceApproval);
await this.exitIfLocked(); await this.exitIfLocked();
const cmd = DenyCommand.create(this.serviceContainer); const cmd = DenyCommand.create(this.serviceContainer);
@ -99,7 +94,6 @@ export class DeviceApprovalProgram extends BaseProgram {
.description("Deny all pending requests for an organization") .description("Deny all pending requests for an organization")
.requiredOption("--organizationid <organizationid>", "The organization id (required)") .requiredOption("--organizationid <organizationid>", "The organization id (required)")
.action(async (options: Options) => { .action(async (options: Options) => {
await this.exitIfFeatureFlagDisabled(FeatureFlag.BulkDeviceApproval);
await this.exitIfLocked(); await this.exitIfLocked();
const cmd = DenyAllCommand.create(this.serviceContainer); const cmd = DenyAllCommand.create(this.serviceContainer);

1
bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.html
View File

@ -29,7 +29,6 @@
></button> ></button>
<bit-menu #headerMenu> <bit-menu #headerMenu>
<button <button
*ngIf="bulkDeviceApprovalEnabled$ | async"
type="button" type="button"
bitMenuItem bitMenuItem
(click)="approveAllRequests()" (click)="approveAllRequests()"

4
bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts
View File

@ -8,7 +8,6 @@ import { OrganizationAuthRequestService } from "@bitwarden/bit-common/admin-cons
import { PendingAuthRequestView } from "@bitwarden/bit-common/admin-console/auth-requests/pending-auth-request.view"; import { PendingAuthRequestView } from "@bitwarden/bit-common/admin-console/auth-requests/pending-auth-request.view";
import { ApiService } from "@bitwarden/common/abstractions/api.service"; import { ApiService } from "@bitwarden/common/abstractions/api.service";
import { OrganizationUserService } from "@bitwarden/common/admin-console/abstractions/organization-user/organization-user.service"; import { OrganizationUserService } from "@bitwarden/common/admin-console/abstractions/organization-user/organization-user.service";
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service"; import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
import { CryptoService } from "@bitwarden/common/platform/abstractions/crypto.service"; import { CryptoService } from "@bitwarden/common/platform/abstractions/crypto.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
@ -43,9 +42,6 @@ export class DeviceApprovalsComponent implements OnInit, OnDestroy {
actionInProgress = false; actionInProgress = false;
protected readonly Devices = Devices; protected readonly Devices = Devices;
protected bulkDeviceApprovalEnabled$ = this.configService.getFeatureFlag$(
FeatureFlag.BulkDeviceApproval,
);
private destroy$ = new Subject<void>(); private destroy$ = new Subject<void>();
private refresh$ = new BehaviorSubject<void>(null); private refresh$ = new BehaviorSubject<void>(null);

2
libs/common/src/enums/feature-flag.enum.ts
View File

@ -16,7 +16,6 @@ export enum FeatureFlag {
ExtensionRefresh = "extension-refresh", ExtensionRefresh = "extension-refresh",
RestrictProviderAccess = "restrict-provider-access", RestrictProviderAccess = "restrict-provider-access",
UseTreeWalkerApiForPageDetailsCollection = "use-tree-walker-api-for-page-details-collection", UseTreeWalkerApiForPageDetailsCollection = "use-tree-walker-api-for-page-details-collection",
BulkDeviceApproval = "bulk-device-approval",
EmailVerification = "email-verification", EmailVerification = "email-verification",
InlineMenuFieldQualification = "inline-menu-field-qualification", InlineMenuFieldQualification = "inline-menu-field-qualification",
MemberAccessReport = "ac-2059-member-access-report", MemberAccessReport = "ac-2059-member-access-report",
@ -50,7 +49,6 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.ExtensionRefresh]: FALSE, [FeatureFlag.ExtensionRefresh]: FALSE,
[FeatureFlag.RestrictProviderAccess]: FALSE, [FeatureFlag.RestrictProviderAccess]: FALSE,
[FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE, [FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE,
[FeatureFlag.BulkDeviceApproval]: FALSE,
[FeatureFlag.EmailVerification]: FALSE, [FeatureFlag.EmailVerification]: FALSE,
[FeatureFlag.InlineMenuFieldQualification]: FALSE, [FeatureFlag.InlineMenuFieldQualification]: FALSE,
[FeatureFlag.MemberAccessReport]: FALSE, [FeatureFlag.MemberAccessReport]: FALSE,