Add login component services tests.

This commit is contained in:
Alec Rippberger 2024-10-01 21:17:03 -05:00
parent 2d5f4dfb70
commit d47ffdfe8f
No known key found for this signature in database
GPG Key ID: 9DD8DA583B28154A
3 changed files with 207 additions and 0 deletions

View File

@ -0,0 +1,39 @@
import { TestBed } from "@angular/core/testing";
import { DefaultLoginComponentService } from "@bitwarden/auth/angular";
import { flagEnabled } from "../../../platform/flags";
import { ExtensionLoginComponentService } from "./extension-login-component.service";
jest.mock("../../../platform/flags", () => ({
flagEnabled: jest.fn(),
}));
describe("ExtensionLoginComponentService", () => {
let service: ExtensionLoginComponentService;
beforeEach(() => {
TestBed.configureTestingModule({
providers: [
ExtensionLoginComponentService,
{ provide: DefaultLoginComponentService, useClass: ExtensionLoginComponentService },
],
});
service = TestBed.inject(ExtensionLoginComponentService);
});
it("creates the service", () => {
expect(service).toBeTruthy();
});
it("returns true if showPasswordless flag is enabled", () => {
(flagEnabled as jest.Mock).mockReturnValue(true);
expect(service.isLoginViaAuthRequestSupported()).toBe(true);
});
it("returns false if showPasswordless flag is disabled", () => {
(flagEnabled as jest.Mock).mockReturnValue(false);
expect(service.isLoginViaAuthRequestSupported()).toBeFalsy();
});
});

View File

@ -0,0 +1,63 @@
import { TestBed } from "@angular/core/testing";
import { MockProxy } from "jest-mock-extended";
import { DefaultLoginComponentService } from "@bitwarden/auth/angular";
import { SsoLoginServiceAbstraction } from "@bitwarden/common/auth/abstractions/sso-login.service.abstraction";
import { CryptoFunctionService } from "@bitwarden/common/platform/abstractions/crypto-function.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { ToastService } from "@bitwarden/components";
import { PasswordGenerationServiceAbstraction } from "@bitwarden/generator-legacy";
import { DesktopLoginComponentService } from "./desktop-login-component.service";
(global as any).ipc = {
platform: {
isAppImage: jest.fn(),
isSnapStore: jest.fn(),
isDev: jest.fn(),
localhostCallbackService: {
openSsoPrompt: jest.fn(),
},
},
};
describe("DesktopLoginComponentService", () => {
let service: DesktopLoginComponentService;
let i18nService: MockProxy<I18nService>;
let toastService: MockProxy<ToastService>;
let ssoLoginService: MockProxy<SsoLoginServiceAbstraction>;
let passwordGenerationService: MockProxy<PasswordGenerationServiceAbstraction>;
let cryptoFunctionService: MockProxy<CryptoFunctionService>;
beforeEach(() => {
TestBed.configureTestingModule({
providers: [
DesktopLoginComponentService,
{ provide: DefaultLoginComponentService, useClass: DesktopLoginComponentService },
{ provide: I18nService, useValue: i18nService },
{ provide: ToastService, useValue: toastService },
{ provide: SsoLoginServiceAbstraction, useValue: ssoLoginService },
{ provide: PasswordGenerationServiceAbstraction, useValue: passwordGenerationService },
{ provide: CryptoFunctionService, useValue: cryptoFunctionService },
],
});
service = TestBed.inject(DesktopLoginComponentService);
jest.spyOn(service, "launchSsoBrowserWindow").mockImplementation(async () => {});
});
it("creates the service", () => {
expect(service).toBeTruthy();
});
it("calls launchSsoBrowserWindow if isAppImage, isSnapStore, and isDev are false", async () => {
(global as any).ipc.platform.isAppImage.mockReturnValue(false);
(global as any).ipc.platform.isSnapStore.mockReturnValue(false);
(global as any).ipc.platform.isDev.mockReturnValue(false);
await service.launchSsoBrowserWindow("user@example.com", "desktop");
expect(service.launchSsoBrowserWindow).toHaveBeenCalledWith("user@example.com", "desktop");
});
});

View File

@ -0,0 +1,105 @@
import { TestBed } from "@angular/core/testing";
import { UrlTree } from "@angular/router";
import { DefaultLoginComponentService } from "@bitwarden/auth/angular";
import { PolicyApiServiceAbstraction } from "@bitwarden/common/admin-console/abstractions/policy/policy-api.service.abstraction";
import { InternalPolicyService } from "@bitwarden/common/admin-console/abstractions/policy/policy.service.abstraction";
import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
import { RouterService } from "../../../../../../../../apps/web/src/app/core";
import { flagEnabled } from "../../../../../utils/flags";
import { AcceptOrganizationInviteService } from "../../../organization-invite/accept-organization.service";
import { WebLoginComponentService } from "./web-login-component.service";
jest.mock("../../../../../utils/flags", () => ({
flagEnabled: jest.fn(),
}));
describe("WebLoginComponentService", () => {
let service: WebLoginComponentService;
beforeEach(() => {
TestBed.configureTestingModule({
providers: [
WebLoginComponentService,
{ provide: DefaultLoginComponentService, useClass: WebLoginComponentService },
{
provide: AcceptOrganizationInviteService,
useValue: {
getOrganizationInvite: jest.fn(),
},
},
{
provide: LogService,
useValue: {
error: jest.fn(),
},
},
{
provide: PolicyApiServiceAbstraction,
useValue: {
getPoliciesByToken: jest.fn(),
},
},
{ provide: InternalPolicyService, useValue: {} },
{
provide: RouterService,
useValue: {
setPreviousUrl: jest.fn(),
},
},
],
});
service = TestBed.inject(WebLoginComponentService);
});
it("creates the service", () => {
expect(service).toBeTruthy();
});
describe("isLoginViaAuthRequestSupported", () => {
it("returns true if showPasswordless flag is enabled", () => {
(flagEnabled as jest.Mock).mockReturnValue(true);
expect(service.isLoginViaAuthRequestSupported()).toBe(true);
});
it("returns false if showPasswordless flag is disabled", () => {
(flagEnabled as jest.Mock).mockReturnValue(false);
expect(service.isLoginViaAuthRequestSupported()).toBeFalsy();
});
});
it("sets the previous URL", () => {
const route = { toString: () => "test-url" } as UrlTree;
const routerServiceSpy = jest.spyOn(service.routerService, "setPreviousUrl");
service.setPreviousUrl(route);
expect(routerServiceSpy).toHaveBeenCalledWith("test-url");
});
it("returns undefined if organization invite is null", async () => {
jest
.spyOn(service.acceptOrganizationInviteService, "getOrganizationInvite")
.mockResolvedValue(null);
const result = await service.getOrgPolicies();
expect(result).toBeUndefined();
});
it("logs an error if getPoliciesByToken throws an error", async () => {
const error = new Error("Test error");
jest.spyOn(service.acceptOrganizationInviteService, "getOrganizationInvite").mockResolvedValue({
organizationId: "org-id",
token: "token",
email: "email",
organizationUserId: "org-user-id",
initOrganization: false,
orgSsoIdentifier: "sso-id",
orgUserHasExistingUser: false,
organizationName: "org-name",
});
jest.spyOn(service.policyApiService, "getPoliciesByToken").mockRejectedValue(error);
const logServiceSpy = jest.spyOn(service.logService, "error");
await service.getOrgPolicies();
expect(logServiceSpy).toHaveBeenCalledWith(error);
});
});