Update Expectations of `update` method (#7119)

* Update Expectations of `update` method

Change `update` to return current state
when `shouldUpdate` returns false.

* Delete Accidental Tests

libs/common/spec/fake-state.ts

@@ -48,7 +48,7 @@ export class FakeGlobalState<T> implements GlobalState<T> {
         ? await firstValueFrom(options.combineLatestWith.pipe(timeout(options.msTimeout)))
         : null;
     if (!options.shouldUpdate(current, combinedDependencies)) {
-      return;
+      return current;
     }
     const newState = configureState(current, combinedDependencies);
     this.stateSubject.next(newState);
@@ -77,7 +77,7 @@ export class FakeUserState<T> implements UserState<T> {
         ? await firstValueFrom(options.combineLatestWith.pipe(timeout(options.msTimeout)))
         : null;
     if (!options.shouldUpdate(current, combinedDependencies)) {
-      return;
+      return current;
     }
     const newState = configureState(current, combinedDependencies);
     this.stateSubject.next(newState);

libs/common/src/platform/state/implementations/default-active-user-state.spec.ts

@@ -301,7 +301,7 @@ describe("DefaultActiveUserState", () => {
       await awaitAsync();
 
       expect(diskStorageService.mock.save).not.toHaveBeenCalled();
-      expect(result).toBe(undefined);
+      expect(result).toBeNull();
       expect(emissions).toEqual([null]);
     });
 

libs/common/src/platform/state/implementations/default-active-user-state.ts

@@ -122,7 +122,7 @@ export class DefaultActiveUserState<T> implements ActiveUserState<T> {
         : null;
 
     if (!options.shouldUpdate(currentState, combinedDependencies)) {
-      return;
+      return currentState;
     }
 
     const newState = configureState(currentState, combinedDependencies);

libs/common/src/platform/state/implementations/default-global-state.spec.ts

@@ -145,7 +145,7 @@ describe("DefaultGlobalState", () => {
 
       expect(diskStorageService.mock.save).not.toHaveBeenCalled();
       expect(emissions).toEqual([null]); // Initial value
-      expect(result).toBeUndefined();
+      expect(result).toBeNull();
     });
 
     it("should provide the update callback with the current State", async () => {

libs/common/src/platform/state/implementations/default-global-state.ts

@@ -85,7 +85,7 @@ export class DefaultGlobalState<T> implements GlobalState<T> {
         : null;
 
     if (!options.shouldUpdate(currentState, combinedDependencies)) {
-      return;
+      return currentState;
     }
 
     const newState = configureState(currentState, combinedDependencies);

libs/common/src/platform/state/implementations/default-single-user-state.spec.ts

@@ -156,7 +156,7 @@ describe("DefaultSingleUserState", () => {
 
       expect(diskStorageService.mock.save).not.toHaveBeenCalled();
       expect(emissions).toEqual([null]); // Initial value
-      expect(result).toBeUndefined();
+      expect(result).toBeNull();
     });
 
     it("should provide the update callback with the current State", async () => {

libs/common/src/platform/state/implementations/default-single-user-state.ts

@@ -91,7 +91,7 @@ export class DefaultSingleUserState<T> implements SingleUserState<T> {
         : null;
 
     if (!options.shouldUpdate(currentState, combinedDependencies)) {
-      return;
+      return currentState;
     }
 
     const newState = configureState(currentState, combinedDependencies);