[PM-4357] remove disableClose on BrowserSyncVerificationDialog and AwaitDesktopDialog (#6730)

* remove disableClose on BrowserSyncVerificationDialogComponent

* remove disableClose from AwaitDesktopDialogComponent

apps/browser/src/popup/settings/await-desktop-dialog.component.html

@@ -4,7 +4,7 @@
     {{ "awaitDesktopDesc" | i18n }}
   </span>
   <ng-container bitDialogFooter>
-    <button bitButton type="button" buttonType="secondary" [bitDialogClose]="true">
+    <button bitButton type="button" buttonType="secondary" [bitDialogClose]="false">
       {{ "close" | i18n }}
     </button>
   </ng-container>

apps/browser/src/popup/settings/await-desktop-dialog.component.ts

@@ -10,8 +10,6 @@ import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components
 })
 export class AwaitDesktopDialogComponent {
   static open(dialogService: DialogService) {
-    return dialogService.open<boolean>(AwaitDesktopDialogComponent, {
-      disableClose: true,
-    });
+    return dialogService.open<boolean>(AwaitDesktopDialogComponent);
   }
 }

apps/browser/src/popup/settings/settings.component.ts

@@ -370,7 +370,7 @@ export class SettingsComponent implements OnInit {
 
       await Promise.race([
         awaitDesktopDialogClosed.then(async (result) => {
-          if (result) {
+          if (result !== true) {
             this.form.controls.biometric.setValue(false);
             await this.stateService.setBiometricAwaitingAcceptance(null);
           }
@@ -402,7 +402,7 @@ export class SettingsComponent implements OnInit {
             });
           })
           .finally(() => {
-            awaitDesktopDialogRef.close(false);
+            awaitDesktopDialogRef.close(true);
           }),
       ]);
     } else {

apps/desktop/src/app/components/browser-sync-verification-dialog.component.ts

@@ -19,7 +19,6 @@ export class BrowserSyncVerificationDialogComponent {
   static open(dialogService: DialogService, data: BrowserSyncVerificationDialogParams) {
     return dialogService.open(BrowserSyncVerificationDialogComponent, {
       data,
-      disableClose: true,
     });
   }
 }