[PM-13177] Fix Unassigned cipher collection assignment in AC (#11419)
* [PM-13177] Add saveCollectionsWithServerAdmin to CipherService * [PM-13177] Introduce isSingleCipherAdmin flag to AssignCollections component
This commit is contained in:
parent
87cb45c520
commit
bdf91e24c6
|
@ -1249,6 +1249,8 @@ export class VaultComponent implements OnInit, OnDestroy {
|
||||||
organizationId: this.organization?.id as OrganizationId,
|
organizationId: this.organization?.id as OrganizationId,
|
||||||
availableCollections,
|
availableCollections,
|
||||||
activeCollection: this.activeFilter?.selectedCollectionNode?.node,
|
activeCollection: this.activeFilter?.selectedCollectionNode?.node,
|
||||||
|
isSingleCipherAdmin:
|
||||||
|
items.length === 1 && (this.organization?.canEditAllCiphers || items[0].isUnassigned),
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
@ -113,6 +113,13 @@ export abstract class CipherService implements UserKeyRotationDataProvider<Ciphe
|
||||||
* @returns A promise that resolves when the collections have been saved
|
* @returns A promise that resolves when the collections have been saved
|
||||||
*/
|
*/
|
||||||
saveCollectionsWithServer: (cipher: Cipher) => Promise<Cipher>;
|
saveCollectionsWithServer: (cipher: Cipher) => Promise<Cipher>;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Save the collections for a cipher with the server as an admin.
|
||||||
|
* Used for Unassigned ciphers or when the user only has admin access to the cipher (not assigned normally).
|
||||||
|
* @param cipher
|
||||||
|
*/
|
||||||
|
saveCollectionsWithServerAdmin: (cipher: Cipher) => Promise<void>;
|
||||||
/**
|
/**
|
||||||
* Bulk update collections for many ciphers with the server
|
* Bulk update collections for many ciphers with the server
|
||||||
* @param orgId
|
* @param orgId
|
||||||
|
|
|
@ -858,6 +858,11 @@ export class CipherService implements CipherServiceAbstraction {
|
||||||
return new Cipher(updated[cipher.id as CipherId], cipher.localData);
|
return new Cipher(updated[cipher.id as CipherId], cipher.localData);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async saveCollectionsWithServerAdmin(cipher: Cipher): Promise<void> {
|
||||||
|
const request = new CipherCollectionsRequest(cipher.collectionIds);
|
||||||
|
await this.apiService.putCipherCollectionsAdmin(cipher.id, request);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Bulk update collections for many ciphers with the server
|
* Bulk update collections for many ciphers with the server
|
||||||
* @param orgId
|
* @param orgId
|
||||||
|
|
|
@ -64,6 +64,15 @@ export interface CollectionAssignmentParams {
|
||||||
* removed from the ciphers upon submission.
|
* removed from the ciphers upon submission.
|
||||||
*/
|
*/
|
||||||
activeCollection?: CollectionView;
|
activeCollection?: CollectionView;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Flag indicating if the user is performing the action as an admin on a SINGLE cipher. When true,
|
||||||
|
* the `/admin` endpoint will be used to update the cipher's collections. Required when updating
|
||||||
|
* ciphers an Admin does not normally have access to or for Unassigned ciphers.
|
||||||
|
*
|
||||||
|
* The bulk method already handles admin actions internally.
|
||||||
|
*/
|
||||||
|
isSingleCipherAdmin?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export enum CollectionAssignmentResult {
|
export enum CollectionAssignmentResult {
|
||||||
|
@ -463,6 +472,10 @@ export class AssignCollectionsComponent implements OnInit, OnDestroy, AfterViewI
|
||||||
const { collections } = this.formGroup.getRawValue();
|
const { collections } = this.formGroup.getRawValue();
|
||||||
cipherView.collectionIds = collections.map((i) => i.id as CollectionId);
|
cipherView.collectionIds = collections.map((i) => i.id as CollectionId);
|
||||||
const cipher = await this.cipherService.encrypt(cipherView, this.activeUserId);
|
const cipher = await this.cipherService.encrypt(cipherView, this.activeUserId);
|
||||||
|
if (this.params.isSingleCipherAdmin) {
|
||||||
|
await this.cipherService.saveCollectionsWithServerAdmin(cipher);
|
||||||
|
} else {
|
||||||
await this.cipherService.saveCollectionsWithServer(cipher);
|
await this.cipherService.saveCollectionsWithServer(cipher);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
Loading…
Reference in New Issue