From 9588148e48517aa46c5a0f4c05d69cbcb4609960 Mon Sep 17 00:00:00 2001
From: rr-bw <102181210+rr-bw@users.noreply.github.com>
Date: Tue, 10 Sep 2024 14:22:51 -0700
Subject: [PATCH] remove toast error on invalid form for Browser/Desktop

---
 .../src/angular/login/login.component.html    |  2 +-
 .../auth/src/angular/login/login.component.ts | 24 +++++++++++++------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/libs/auth/src/angular/login/login.component.html b/libs/auth/src/angular/login/login.component.html
index b99750769e..092706d18a 100644
--- a/libs/auth/src/angular/login/login.component.html
+++ b/libs/auth/src/angular/login/login.component.html
@@ -12,7 +12,7 @@
   -->
 <form
   [ngClass]="{ 'tw-hidden': clientType !== ClientType.Web }"
-  [bitSubmit]="submit.bind(null, false)"
+  [bitSubmit]="submit"
   [formGroup]="formGroup"
 >
   <!-------------------------
diff --git a/libs/auth/src/angular/login/login.component.ts b/libs/auth/src/angular/login/login.component.ts
index 89ba46a5d9..061604ce26 100644
--- a/libs/auth/src/angular/login/login.component.ts
+++ b/libs/auth/src/angular/login/login.component.ts
@@ -142,20 +142,30 @@ export class LoginComponentV2 implements OnInit, OnDestroy {
     this.destroy$.complete();
   }
 
-  submit = async (showToast = true): Promise<void> => {
+  submit = async (): Promise<void> => {
     const data = this.formGroup.value;
 
     await this.setupCaptcha();
 
+    /**
+     * TODO-rr-bw: Verify the following
+     *
+     * In the original base login component there is a comment in the submit() method that says:
+     * "desktop, browser; This should be removed once all clients use reactive forms"
+     *
+     * Since we are now using reactive forms for all clients. I removed the Browser/Desktop specific
+     * toast error message.
+     *
+     * I also removed the `showToast` parameter from the submit() method entirely because my
+     * understanding is that now all errors will be visually handled by the reactive form via
+     * this.formGroup.markAllAsTouched()
+     *
+     * Therefore below I am simply checking if the form is invalid and returning if so.
+     */
     this.formGroup.markAllAsTouched();
-
-    // Web specific (start)
-    if (this.formGroup.invalid && !showToast) {
+    if (this.formGroup.invalid) {
       return;
     }
-    // Web specific (end)
-
-    // TODO-rr-bw: handle toast here for Browser/Desktop? See base LoginComponent -> submit()
 
     const credentials = new PasswordLoginCredentials(
       data.email,