From 914d88770df197317fabd384ba8de5b3a2a482f5 Mon Sep 17 00:00:00 2001
From: Shashank S <entreprise+github@knhash.in>
Date: Wed, 7 Jul 2021 17:09:03 +0530
Subject: [PATCH] Use radio buttons for password generator type instead of
 dropdown (#1894)

* fix: radio instead of dropdown

* fix: revert changes, use from upstream

* chore: remove unnecessary label

* chore: undo unnecessary formatting

* chore: undo unnecessary formatting

* feat: update jslib version

* chore: add label, remove unnec. intlz.

* Remove unnecessary name attribute

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
---
 jslib                                             |  2 +-
 .../generator/password-generator.component.html   | 15 +++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/jslib b/jslib
index 9ee31ad2fb..aff5ad1faa 160000
--- a/jslib
+++ b/jslib
@@ -1 +1 @@
-Subproject commit 9ee31ad2fb950497a7c88c5073e23bf3bddf18c7
+Subproject commit aff5ad1faabc4c680a6ff4e68b3abc301a50e9b4
diff --git a/src/popup/generator/password-generator.component.html b/src/popup/generator/password-generator.component.html
index c3dc240ee3..bb5f255231 100644
--- a/src/popup/generator/password-generator.component.html
+++ b/src/popup/generator/password-generator.component.html
@@ -38,12 +38,15 @@
             {{'options' | i18n}}
         </div>
         <div class="box-content">
-            <div class="box-content-row" appBoxRow>
-                <label for="type" class="sr-only">{{'type' | i18n}}</label>
-                <select id="type" [(ngModel)]="options.type" (change)="saveOptions()">
-                    <option value="password">{{'password' | i18n}}</option>
-                    <option value="passphrase">{{'passphrase' | i18n}}</option>
-                </select>
+            <div class="box-content-row">
+                <label class="sr-only radio-header">{{'type' | i18n}}</label>
+                <div class="radio-group text-default" appBoxRow *ngFor="let o of passTypeOptions">
+                    <input type="radio" [(ngModel)]="options.type" name="Type_{{o.value}}" id="type_{{o.value}}"
+                        [value]="o.value" (change)="saveOptions()" [checked]="options.type === o.value">
+                    <label for="type_{{o.value}}">
+                        {{o.name}}
+                    </label>
+                </div>
             </div>
         </div>
     </div>