From 8dc7ead8535881fbe1903d55ac187eba3d08ccdc Mon Sep 17 00:00:00 2001
From: Robyn MacCallum <robyntmaccallum@gmail.com>
Date: Tue, 9 May 2023 14:03:31 -0400
Subject: [PATCH] Add more descriptive titles for web vault rows (#5404)

* Add more descriptive titles for web vault rows

* Swap example strings
---
 .../vault-cipher-row.component.html            |  2 +-
 .../vault-collection-row.component.html        |  1 +
 apps/web/src/locales/en/messages.json          | 18 ++++++++++++++++++
 3 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html b/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html
index 97b3875a47..5e9b834247 100644
--- a/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html
+++ b/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html
@@ -24,7 +24,7 @@
       [routerLink]="[]"
       [queryParams]="{ itemId: cipher.id }"
       queryParamsHandling="merge"
-      title="{{ 'editItem' | i18n }}"
+      title="{{ 'editItemWithName' | i18n : cipher.name }}"
       type="button"
     >
       {{ cipher.name }}
diff --git a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
index cc1b693ab3..43162c9366 100644
--- a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
+++ b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
@@ -21,6 +21,7 @@
     type="button"
     class="tw-w-full tw-overflow-hidden tw-text-ellipsis tw-text-start"
     linkType="secondary"
+    title="{{ 'viewCollectionWithName' | i18n : collection.name }}"
     [routerLink]="[]"
     [queryParams]="{ collectionId: collection.id }"
     queryParamsHandling="merge"
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 35bd7b3a63..2e064e4608 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -2751,6 +2751,24 @@
       }
     }
   },
+  "viewCollectionWithName": {
+    "message": "View collection - $NAME$",
+    "placeholders": {
+      "name": {
+        "content": "$1",
+        "example": "Collection1"
+      }
+    }
+  },
+  "editItemWithName": {
+    "message": "Edit item - $NAME$",
+    "placeholders": {
+      "name": {
+        "content": "$1",
+        "example": "Google Login"
+      }
+    }
+  },
   "copiedPasswordItemId": {
     "message": "Copied password for item $ID$.",
     "placeholders": {