From 80af20ef54f2644a9034499709a8943e0733c489 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Tue, 7 Aug 2018 23:46:31 -0400
Subject: [PATCH] control save button enabled for sharing modal

---
 src/app/vault/bulk-share.component.html |  2 +-
 src/app/vault/bulk-share.component.ts   | 25 +++++++++++++++++++------
 src/app/vault/share.component.html      |  2 +-
 src/app/vault/share.component.ts        | 11 +++++++++++
 src/scss/styles.scss                    |  2 +-
 5 files changed, 33 insertions(+), 9 deletions(-)

diff --git a/src/app/vault/bulk-share.component.html b/src/app/vault/bulk-share.component.html
index 70b8758cab..f6f840c2f5 100644
--- a/src/app/vault/bulk-share.component.html
+++ b/src/app/vault/bulk-share.component.html
@@ -46,7 +46,7 @@
                 </table>
             </div>
             <div class="modal-footer">
-                <button type="submit" class="btn btn-primary btn-submit" [disabled]="form.loading">
+                <button type="submit" class="btn btn-primary btn-submit manual" [disabled]="form.loading || !canSave" [ngClass]="{loading:form.loading}">
                     <i class="fa fa-spinner fa-spin" title="{{'loading' | i18n}}"></i>
                     <span>{{'save' | i18n}}</span>
                 </button>
diff --git a/src/app/vault/bulk-share.component.ts b/src/app/vault/bulk-share.component.ts
index 6402bc60df..3746960748 100644
--- a/src/app/vault/bulk-share.component.ts
+++ b/src/app/vault/bulk-share.component.ts
@@ -67,12 +67,14 @@ export class BulkShareComponent implements OnInit {
 
     async submit() {
         const checkedCollectionIds = this.collections.filter((c) => (c as any).checked).map((c) => c.id);
-        this.formPromise = this.cipherService.shareManyWithServer(this.shareableCiphers, this.organizationId,
-            checkedCollectionIds);
-        await this.formPromise;
-        this.onShared.emit();
-        this.analytics.eventTrack.next({ action: 'Bulk Shared Items' });
-        this.toasterService.popAsync('success', null, this.i18nService.t('sharedItems'));
+        try {
+            this.formPromise = this.cipherService.shareManyWithServer(this.shareableCiphers, this.organizationId,
+                checkedCollectionIds);
+            await this.formPromise;
+            this.onShared.emit();
+            this.analytics.eventTrack.next({ action: 'Bulk Shared Items' });
+            this.toasterService.popAsync('success', null, this.i18nService.t('sharedItems'));
+        } catch { }
     }
 
     check(c: CollectionView, select?: boolean) {
@@ -83,4 +85,15 @@ export class BulkShareComponent implements OnInit {
         const collections = select ? this.collections : this.writeableCollections;
         collections.forEach((c) => this.check(c, select));
     }
+
+    get canSave() {
+        if (this.shareableCiphers != null && this.shareableCiphers.length > 0 && this.collections != null) {
+            for (let i = 0; i < this.collections.length; i++) {
+                if ((this.collections[i] as any).checked) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
 }
diff --git a/src/app/vault/share.component.html b/src/app/vault/share.component.html
index cd4f5414c1..77ed067626 100644
--- a/src/app/vault/share.component.html
+++ b/src/app/vault/share.component.html
@@ -49,7 +49,7 @@
                 </table>
             </div>
             <div class="modal-footer">
-                <button type="submit" class="btn btn-primary btn-submit" [disabled]="form.loading" *ngIf="organizations && organizations.length">
+                <button type="submit" class="btn btn-primary btn-submit manual" [disabled]="form.loading || !canSave" [ngClass]="{loading:form.loading}" *ngIf="organizations && organizations.length">
                     <i class="fa fa-spinner fa-spin" title="{{'loading' | i18n}}"></i>
                     <span>{{'save' | i18n}}</span>
                 </button>
diff --git a/src/app/vault/share.component.ts b/src/app/vault/share.component.ts
index 3e393370e5..74c979589e 100644
--- a/src/app/vault/share.component.ts
+++ b/src/app/vault/share.component.ts
@@ -97,4 +97,15 @@ export class ShareComponent implements OnInit, OnDestroy {
         const collections = select ? this.collections : this.writeableCollections;
         collections.forEach((c) => this.check(c, select));
     }
+
+    get canSave() {
+        if (this.collections != null) {
+            for (let i = 0; i < this.collections.length; i++) {
+                if ((this.collections[i] as any).checked) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
 }
diff --git a/src/scss/styles.scss b/src/scss/styles.scss
index fa999d56b7..6b9de68322 100644
--- a/src/scss/styles.scss
+++ b/src/scss/styles.scss
@@ -276,7 +276,7 @@ label:not(.form-check-label):not(.btn) {
         right: 0;
     }
 
-    &:disabled {
+    &:disabled:not(.manual), &.loading {
         .fa-spinner {
             display: flex;
         }