From 79b2633d9e11ad51474bc70be908afd3da2c0ae3 Mon Sep 17 00:00:00 2001 From: Jared Snider Date: Mon, 30 Sep 2024 15:20:52 -0400 Subject: [PATCH] PM-8111 - Extension - AppRoutingModule - Home route now redirects conditionally based on unauthenticated ui refresh feature flag. --- apps/browser/src/popup/app-routing.module.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/popup/app-routing.module.ts b/apps/browser/src/popup/app-routing.module.ts index 2042d8e674..d8e91221dc 100644 --- a/apps/browser/src/popup/app-routing.module.ts +++ b/apps/browser/src/popup/app-routing.module.ts @@ -2,6 +2,7 @@ import { Injectable, NgModule } from "@angular/core"; import { ActivatedRouteSnapshot, RouteReuseStrategy, RouterModule, Routes } from "@angular/router"; import { EnvironmentSelectorComponent } from "@bitwarden/angular/auth/components/environment-selector.component"; +import { unauthUiRefreshRedirect } from "@bitwarden/angular/auth/functions/unauth-ui-refresh-redirect"; import { unauthUiRefreshSwap } from "@bitwarden/angular/auth/functions/unauth-ui-refresh-route-swap"; import { authGuard, @@ -154,8 +155,7 @@ const routes: Routes = [ { path: "home", component: HomeComponent, - // TODO-rr-bw: verify if was the correct feature-flag/redirect to use, and should it go in canActivate? - canActivate: [unauthGuardFn(unauthRouteOverrides), extensionRefreshRedirect("login")], + canActivate: [unauthGuardFn(unauthRouteOverrides), unauthUiRefreshRedirect("/login")], data: { state: "home" } satisfies RouteDataProperties, }, ...extensionRefreshSwap(Fido2V1Component, Fido2Component, {