make tab object for message sender

src/browser/browserApi.ts

@@ -44,16 +44,7 @@ class BrowserApi {
 
             const returnedTabs: any[] = [];
             tabs.forEach((tab: any) => {
-                const winIndex = safari.application.browserWindows.indexOf(tab.browserWindow);
+                returnedTabs.push(BrowserApi.makeTabObject(tab));
-                const tabIndex = tab.browserWindow.tabs.indexOf(tab);
-                returnedTabs.push({
-                    id: winIndex + '_' + tabIndex,
-                    index: tabIndex,
-                    windowId: winIndex,
-                    title: tab.title,
-                    active: tab === tab.browserWindow.activeTab,
-                    url: tab.url || 'about:blank',
-                });
             });
 
             return Promise.resolve(returnedTabs);
@@ -169,14 +160,33 @@ class BrowserApi {
         } else if (BrowserApi.isSafariApi) {
             safari.application.addEventListener('message', async (msgEvent: any) => {
                 callback(msgEvent.message, {
-                    tab: {
+                    tab: BrowserApi.makeTabObject(msgEvent.target),
-                        id: null, // TODO
-                    },
                     frameId: null,
                 }, () => { /* No responses in Safari */ });
             }, false);
         }
     }
+
+    private static makeTabObject(tab: any) {
+        if (BrowserApi.isChromeApi) {
+            return tab;
+        }
+
+        if (!tab.browserWindow) {
+            return {};
+        }
+
+        const winIndex = safari.application.browserWindows.indexOf(tab.browserWindow);
+        const tabIndex = tab.browserWindow.tabs.indexOf(tab);
+        return {
+            id: winIndex + '_' + tabIndex,
+            index: tabIndex,
+            windowId: winIndex,
+            title: tab.title,
+            active: tab === tab.browserWindow.activeTab,
+            url: tab.url || 'about:blank',
+        };
+    }
 }
 
 export { BrowserApi };