From 48f99099b2d881d47e84f8e6c9e92d11eb2e181e Mon Sep 17 00:00:00 2001
From: Oscar Hinton <Hinton@users.noreply.github.com>
Date: Wed, 8 Jan 2025 19:37:08 +0100
Subject: [PATCH] [PM-16845] Lint unowned dependencies (#12748)

* Lint unowned dependencies

* Split npm ci and run linter

* Set explicit versions for unchanged parts of the workflow ....

* Rename yao-pkg

* Add owners for sdk-internal, fuses and angular-eslint/schematics

* Assign owners for angular and storybook

* Add typescript-strict-plugin

* Add two more unowned dependencies

---------

Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
---
 .github/renovate.json    | 16 +++++++++++++---
 package.json             |  1 +
 scripts/dep-ownership.ts | 31 +++++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 scripts/dep-ownership.ts

diff --git a/.github/renovate.json b/.github/renovate.json
index 76a52136ae..776c66af68 100644
--- a/.github/renovate.json
+++ b/.github/renovate.json
@@ -104,6 +104,8 @@
       "matchPackageNames": [
         "@babel/core",
         "@babel/preset-env",
+        "@bitwarden/sdk-internal",
+        "@electron/fuses",
         "@electron/notarize",
         "@electron/rebuild",
         "@ngtools/webpack",
@@ -115,7 +117,7 @@
         "@types/node",
         "@types/node-forge",
         "@types/node-ipc",
-        "@yao-pkg",
+        "@yao-pkg/pkg",
         "babel-loader",
         "browserslist",
         "copy-webpack-plugin",
@@ -135,6 +137,7 @@
         "tsconfig-paths-webpack-plugin",
         "type-fest",
         "typescript",
+        "typescript-strict-plugin",
         "webpack",
         "webpack-cli",
         "webpack-dev-server",
@@ -151,12 +154,13 @@
         "@angular/cdk",
         "@angular/cli",
         "@angular/common",
-        "@angular/compiler",
         "@angular/compiler-cli",
+        "@angular/compiler",
         "@angular/core",
         "@angular/forms",
+        "@angular/platform-browser-dynamic",
+        "@angular/platform-browser",
         "@angular/platform",
-        "@angular/compiler",
         "@angular/router",
         "@compodoc/compodoc",
         "@ng-select/ng-select",
@@ -164,8 +168,11 @@
         "@storybook/addon-actions",
         "@storybook/addon-designs",
         "@storybook/addon-essentials",
+        "@storybook/addon-interactions",
         "@storybook/addon-links",
         "@storybook/angular",
+        "@storybook/manager-api",
+        "@storybook/theming",
         "@types/react",
         "autoprefixer",
         "bootstrap",
@@ -188,7 +195,9 @@
       "matchPackageNames": [
         "@angular-eslint/eslint-plugin",
         "@angular-eslint/eslint-plugin-template",
+        "@angular-eslint/schematics",
         "@angular-eslint/template-parser",
+        "@angular/elements",
         "@types/jest",
         "@typescript-eslint/eslint-plugin",
         "@typescript-eslint/parser",
@@ -201,6 +210,7 @@
         "eslint-plugin-storybook",
         "eslint-plugin-tailwindcss",
         "husky",
+        "jest-extended",
         "jest-junit",
         "jest-mock-extended",
         "jest-preset-angular",
diff --git a/package.json b/package.json
index 0a78d370d2..2508c543d7 100644
--- a/package.json
+++ b/package.json
@@ -23,6 +23,7 @@
     "test:watch:all": "jest --watchAll",
     "test:types": "node ./scripts/test-types.js",
     "test:locales": "tsc --project ./scripts/tsconfig.json && node ./scripts/dist/test-locales.js",
+    "lint:dep-ownership": "tsc --project ./scripts/tsconfig.json && node ./scripts/dist/dep-ownership.js",
     "docs:json": "compodoc -p ./tsconfig.json -e json -d . --disableRoutesGraph",
     "storybook": "ng run components:storybook",
     "build-storybook": "ng run components:build-storybook",
diff --git a/scripts/dep-ownership.ts b/scripts/dep-ownership.ts
new file mode 100644
index 0000000000..e574a3e9e9
--- /dev/null
+++ b/scripts/dep-ownership.ts
@@ -0,0 +1,31 @@
+/* eslint-disable no-console */
+
+/// Ensure that all dependencies in package.json have an owner in the renovate.json file.
+
+import fs from "fs";
+import path from "path";
+
+const renovateConfig = JSON.parse(
+  fs.readFileSync(path.join(__dirname, "..", "..", ".github", "renovate.json"), "utf8"),
+);
+
+const packagesWithOwners = renovateConfig.packageRules
+  .flatMap((rule: any) => rule.matchPackageNames)
+  .filter((packageName: string) => packageName != null);
+
+const packageJson = JSON.parse(
+  fs.readFileSync(path.join(__dirname, "..", "..", "package.json"), "utf8"),
+);
+const dependencies = Object.keys(packageJson.dependencies).concat(
+  Object.keys(packageJson.devDependencies),
+);
+
+const missingOwners = dependencies.filter((dep) => !packagesWithOwners.includes(dep));
+
+if (missingOwners.length > 0) {
+  console.error("Missing owners for the following dependencies:");
+  console.error(missingOwners.join("\n"));
+  process.exit(1);
+}
+
+console.log("All dependencies have owners.");