From 23b02a770ac3083502636795c6e0b910ba3e6288 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kspearrin@users.noreply.github.com>
Date: Tue, 29 Mar 2022 15:02:48 -0400
Subject: [PATCH] add username generation to generator (#1566)

* add username generation to generator

* move bottom buttons into existing containers
---
 src/app/oss-routing.module.ts                 |   2 +-
 .../password-generator-history.component.html |   2 +-
 .../tools/password-generator.component.html   | 443 ++++++++++++------
 src/app/tools/tools.component.html            |   2 +-
 src/app/vault/add-edit.component.html         |   2 +-
 src/locales/en/messages.json                  |  46 +-
 src/scss/pages.scss                           |   4 +-
 7 files changed, 338 insertions(+), 163 deletions(-)

diff --git a/src/app/oss-routing.module.ts b/src/app/oss-routing.module.ts
index 6ad7ec2b7f..df7c5e1c7f 100644
--- a/src/app/oss-routing.module.ts
+++ b/src/app/oss-routing.module.ts
@@ -240,7 +240,7 @@ const routes: Routes = [
           {
             path: "generator",
             component: PasswordGeneratorComponent,
-            data: { titleId: "passwordGenerator" },
+            data: { titleId: "generator" },
           },
           {
             path: "breach-report",
diff --git a/src/app/tools/password-generator-history.component.html b/src/app/tools/password-generator-history.component.html
index a5b35df5c3..5b9e32378a 100644
--- a/src/app/tools/password-generator-history.component.html
+++ b/src/app/tools/password-generator-history.component.html
@@ -17,7 +17,7 @@
           <li class="list-group-item d-flex" *ngFor="let h of history">
             <div class="password-row">
               <div
-                class="text-monospace password-wrapper"
+                class="text-monospace generated-wrapper"
                 [innerHTML]="h.password | colorPassword"
                 appSelectCopy
               ></div>
diff --git a/src/app/tools/password-generator.component.html b/src/app/tools/password-generator.component.html
index 343085cb9c..19291398bd 100644
--- a/src/app/tools/password-generator.component.html
+++ b/src/app/tools/password-generator.component.html
@@ -1,199 +1,330 @@
 <div class="page-header">
-  <h1>{{ "passwordGenerator" | i18n }}</h1>
+  <h1>{{ "generator" | i18n }}</h1>
 </div>
-<app-callout type="info" *ngIf="enforcedPasswordPolicyOptions?.inEffect()">
+<app-callout type="info" *ngIf="enforcedPasswordPolicyOptions?.inEffect() && type === 'password'">
   {{ "passwordGeneratorPolicyInEffect" | i18n }}
 </app-callout>
-<div class="card card-password bg-light my-4">
+<div class="card card-generated bg-light my-4">
   <div class="card-body">
-    <div class="password-wrapper" [innerHTML]="password | colorPassword" appSelectCopy></div>
+    <div
+      *ngIf="type === 'password'"
+      class="generated-wrapper"
+      [innerHTML]="password | colorPassword"
+      appSelectCopy
+    ></div>
+    <div
+      *ngIf="type === 'username'"
+      class="generated-wrapper"
+      [innerHTML]="username | colorPassword"
+      appSelectCopy
+    ></div>
   </div>
 </div>
 <div class="form-group">
-  <div class="form-check form-check-inline" *ngFor="let o of passTypeOptions">
+  <label class="d-block">{{ "whatWouldYouLikeToGenerate" | i18n }}</label>
+  <div class="form-check form-check-inline" *ngFor="let o of typeOptions">
     <input
       class="form-check-input"
       type="radio"
-      [(ngModel)]="passwordOptions.type"
+      [(ngModel)]="type"
       name="Type_{{ o.value }}"
       id="type_{{ o.value }}"
       [value]="o.value"
-      (change)="savePasswordOptions()"
-      [checked]="passwordOptions.type === o.value"
+      (change)="typeChanged()"
+      [checked]="type === o.value"
     />
     <label class="form-check-label" for="type_{{ o.value }}">
       {{ o.name }}
     </label>
   </div>
 </div>
-<ng-container *ngIf="passwordOptions.type === 'passphrase'">
-  <div class="row">
-    <div class="form-group col-4">
-      <label for="num-words">{{ "numWords" | i18n }}</label>
+<ng-container *ngIf="type === 'password'">
+  <div class="form-group">
+    <label class="d-block">{{ "passwordType" | i18n }}</label>
+    <div class="form-check form-check-inline" *ngFor="let o of passTypeOptions">
       <input
-        id="num-words"
-        class="form-control"
-        type="number"
-        min="3"
-        max="20"
-        [(ngModel)]="passwordOptions.numWords"
-        (blur)="savePasswordOptions()"
+        class="form-check-input"
+        type="radio"
+        [(ngModel)]="passwordOptions.type"
+        name="PasswordType_{{ o.value }}"
+        id="passwordType_{{ o.value }}"
+        [value]="o.value"
+        (change)="savePasswordOptions()"
+        [checked]="passwordOptions.type === o.value"
       />
+      <label class="form-check-label" for="passwordType_{{ o.value }}">
+        {{ o.name }}
+      </label>
     </div>
-    <div class="form-group col-4">
-      <label for="word-separator">{{ "wordSeparator" | i18n }}</label>
+  </div>
+  <ng-container *ngIf="passwordOptions.type === 'passphrase'">
+    <div class="row">
+      <div class="form-group col-4">
+        <label for="num-words">{{ "numWords" | i18n }}</label>
+        <input
+          id="num-words"
+          class="form-control"
+          type="number"
+          min="3"
+          max="20"
+          [(ngModel)]="passwordOptions.numWords"
+          (blur)="savePasswordOptions()"
+        />
+      </div>
+      <div class="form-group col-4">
+        <label for="word-separator">{{ "wordSeparator" | i18n }}</label>
+        <input
+          id="word-separator"
+          class="form-control"
+          type="text"
+          maxlength="1"
+          [(ngModel)]="passwordOptions.wordSeparator"
+          (blur)="savePasswordOptions()"
+        />
+      </div>
+    </div>
+    <label class="d-block">{{ "options" | i18n }}</label>
+    <div class="form-group">
+      <div class="form-check">
+        <input
+          id="capitalize"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.capitalize"
+          [disabled]="enforcedPasswordPolicyOptions?.capitalize"
+        />
+        <label for="capitalize" class="form-check-label">{{ "capitalize" | i18n }}</label>
+      </div>
+      <div class="form-check">
+        <input
+          id="include-number"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.includeNumber"
+          [disabled]="enforcedPasswordPolicyOptions?.includeNumber"
+        />
+        <label for="include-number" class="form-check-label">{{ "includeNumber" | i18n }}</label>
+      </div>
+    </div>
+  </ng-container>
+  <ng-container *ngIf="passwordOptions.type === 'password'">
+    <div class="row">
+      <div class="form-group col-4">
+        <label for="length">{{ "length" | i18n }}</label>
+        <input
+          id="length"
+          class="form-control"
+          type="number"
+          min="5"
+          max="128"
+          [(ngModel)]="passwordOptions.length"
+          (blur)="savePasswordOptions()"
+          (change)="lengthChanged()"
+        />
+      </div>
+      <div class="form-group col-4">
+        <label for="min-number">{{ "minNumbers" | i18n }}</label>
+        <input
+          id="min-number"
+          class="form-control"
+          type="number"
+          min="0"
+          max="9"
+          (blur)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.minNumber"
+          (change)="minNumberChanged()"
+        />
+      </div>
+      <div class="form-group col-4">
+        <label for="min-special">{{ "minSpecial" | i18n }}</label>
+        <input
+          id="min-special"
+          class="form-control"
+          type="number"
+          min="0"
+          max="9"
+          (blur)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.minSpecial"
+          (change)="minSpecialChanged()"
+        />
+      </div>
+    </div>
+    <label class="d-block">{{ "options" | i18n }}</label>
+    <div class="form-group">
+      <div class="form-check">
+        <input
+          id="uppercase"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.uppercase"
+          [disabled]="enforcedPasswordPolicyOptions?.useUppercase"
+        />
+        <label for="uppercase" class="form-check-label">A-Z</label>
+      </div>
+      <div class="form-check">
+        <input
+          id="lowercase"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.lowercase"
+          [disabled]="enforcedPasswordPolicyOptions?.useLowercase"
+        />
+        <label for="lowercase" class="form-check-label">a-z</label>
+      </div>
+      <div class="form-check">
+        <input
+          id="numbers"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.number"
+          [disabled]="enforcedPasswordPolicyOptions?.useNumbers"
+        />
+        <label for="numbers" class="form-check-label">0-9</label>
+      </div>
+      <div class="form-check">
+        <input
+          id="special"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="passwordOptions.special"
+          [disabled]="enforcedPasswordPolicyOptions?.useSpecial"
+        />
+        <label for="special" class="form-check-label">!@#$%^&amp;*</label>
+      </div>
+      <div class="form-check">
+        <input
+          id="ambiguous"
+          class="form-check-input"
+          type="checkbox"
+          (change)="savePasswordOptions()"
+          [(ngModel)]="avoidAmbiguous"
+        />
+        <label for="ambiguous" class="form-check-label">{{ "ambiguous" | i18n }}</label>
+      </div>
+    </div>
+  </ng-container>
+  <div class="d-flex">
+    <div>
+      <button type="button" class="btn btn-primary" (click)="regenerate()">
+        {{ "regeneratePassword" | i18n }}
+      </button>
+      <button type="button" class="btn btn-outline-secondary" (click)="copy()">
+        {{ "copyPassword" | i18n }}
+      </button>
+    </div>
+    <div class="ml-auto">
+      <button
+        type="button"
+        class="btn btn-outline-secondary"
+        (click)="history()"
+        appA11yTitle="{{ 'passwordHistory' | i18n }}"
+      >
+        <i class="bwi bwi-clock bwi-lg" aria-hidden="true"></i>
+      </button>
+    </div>
+  </div>
+</ng-container>
+<ng-container *ngIf="type === 'username'">
+  <div class="form-group">
+    <label class="d-block">{{ "usernameType" | i18n }}</label>
+    <div class="form-check" *ngFor="let o of usernameTypeOptions">
       <input
-        id="word-separator"
+        class="form-check-input"
+        type="radio"
+        [(ngModel)]="usernameOptions.type"
+        name="UsernameType_{{ o.value }}"
+        id="usernameType_{{ o.value }}"
+        [value]="o.value"
+        (change)="saveUsernameOptions()"
+        [checked]="usernameOptions.type === o.value"
+      />
+      <label class="form-check-label" for="usernameType_{{ o.value }}">
+        {{ o.name }}
+        <div class="small text-muted">{{ o.desc }}</div>
+      </label>
+    </div>
+  </div>
+  <div class="form-group" *ngIf="usernameOptions.type === 'forwarded'">
+    <div class="form-check form-check-inline" *ngFor="let o of forwardOptions">
+      <input
+        class="form-check-input"
+        type="radio"
+        [(ngModel)]="usernameOptions.forwardedService"
+        name="ForwardType_{{ o.value }}"
+        id="forwardtype_{{ o.value }}"
+        [value]="o.value"
+        (change)="saveUsernameOptions()"
+        [checked]="usernameOptions.forwardedService === o.value"
+      />
+      <label class="form-check-label" for="forwardtype_{{ o.value }}">
+        {{ o.name }}
+      </label>
+    </div>
+  </div>
+  <div class="row" *ngIf="usernameOptions.type === 'subaddress'">
+    <div class="form-group col-4">
+      <label for="subaddress-email">{{ "emailAddress" | i18n }}</label>
+      <input
+        id="subaddress-email"
         class="form-control"
         type="text"
-        maxlength="1"
-        [(ngModel)]="passwordOptions.wordSeparator"
-        (blur)="savePasswordOptions()"
+        [(ngModel)]="usernameOptions.subaddressEmail"
+        (blur)="saveUsernameOptions()"
       />
     </div>
   </div>
-  <div class="form-group">
-    <div class="form-check">
-      <input
-        id="capitalize"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.capitalize"
-        [disabled]="enforcedPasswordPolicyOptions?.capitalize"
-      />
-      <label for="capitalize" class="form-check-label">{{ "capitalize" | i18n }}</label>
-    </div>
-    <div class="form-check">
-      <input
-        id="include-number"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.includeNumber"
-        [disabled]="enforcedPasswordPolicyOptions?.includeNumber"
-      />
-      <label for="include-number" class="form-check-label">{{ "includeNumber" | i18n }}</label>
-    </div>
-  </div>
-</ng-container>
-<ng-container *ngIf="passwordOptions.type === 'password'">
-  <div class="row">
+  <div class="row" *ngIf="usernameOptions.type === 'catchall'">
     <div class="form-group col-4">
-      <label for="length">{{ "length" | i18n }}</label>
+      <label for="catchall-domain">{{ "domainName" | i18n }}</label>
       <input
-        id="length"
+        id="catchall-domain"
         class="form-control"
-        type="number"
-        min="5"
-        max="128"
-        [(ngModel)]="passwordOptions.length"
-        (blur)="savePasswordOptions()"
-        (change)="lengthChanged()"
-      />
-    </div>
-    <div class="form-group col-4">
-      <label for="min-number">{{ "minNumbers" | i18n }}</label>
-      <input
-        id="min-number"
-        class="form-control"
-        type="number"
-        min="0"
-        max="9"
-        (blur)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.minNumber"
-        (change)="minNumberChanged()"
-      />
-    </div>
-    <div class="form-group col-4">
-      <label for="min-special">{{ "minSpecial" | i18n }}</label>
-      <input
-        id="min-special"
-        class="form-control"
-        type="number"
-        min="0"
-        max="9"
-        (blur)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.minSpecial"
-        (change)="minSpecialChanged()"
+        type="text"
+        [(ngModel)]="usernameOptions.catchallDomain"
+        (blur)="saveUsernameOptions()"
       />
     </div>
   </div>
-  <div class="form-group">
-    <div class="form-check">
-      <input
-        id="uppercase"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.uppercase"
-        [disabled]="enforcedPasswordPolicyOptions?.useUppercase"
-      />
-      <label for="uppercase" class="form-check-label">A-Z</label>
+  <ng-container *ngIf="usernameOptions.type === 'word'">
+    <label class="d-block">{{ "options" | i18n }}</label>
+    <div class="row">
+      <div class="form-group">
+        <div class="form-check">
+          <input
+            id="capitalizeUsername"
+            type="checkbox"
+            (change)="saveUsernameOptions()"
+            [(ngModel)]="usernameOptions.wordCapitalize"
+          />
+          <label for="capitalizeUsername" class="form-check-label">{{ "capitalize" | i18n }}</label>
+        </div>
+        <div class="form-check">
+          <input
+            id="includeNumberUsername"
+            type="checkbox"
+            (change)="saveUsernameOptions()"
+            [(ngModel)]="usernameOptions.wordIncludeNumber"
+          />
+          <label for="includeNumberUsername" class="form-check-label">{{
+            "includeNumber" | i18n
+          }}</label>
+        </div>
+      </div>
     </div>
-    <div class="form-check">
-      <input
-        id="lowercase"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.lowercase"
-        [disabled]="enforcedPasswordPolicyOptions?.useLowercase"
-      />
-      <label for="lowercase" class="form-check-label">a-z</label>
-    </div>
-    <div class="form-check">
-      <input
-        id="numbers"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.number"
-        [disabled]="enforcedPasswordPolicyOptions?.useNumbers"
-      />
-      <label for="numbers" class="form-check-label">0-9</label>
-    </div>
-    <div class="form-check">
-      <input
-        id="special"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="passwordOptions.special"
-        [disabled]="enforcedPasswordPolicyOptions?.useSpecial"
-      />
-      <label for="special" class="form-check-label">!@#$%^&amp;*</label>
-    </div>
-    <div class="form-check">
-      <input
-        id="ambiguous"
-        class="form-check-input"
-        type="checkbox"
-        (change)="savePasswordOptions()"
-        [(ngModel)]="avoidAmbiguous"
-      />
-      <label for="ambiguous" class="form-check-label">{{ "ambiguous" | i18n }}</label>
-    </div>
-  </div>
-</ng-container>
-<div class="d-flex">
+  </ng-container>
   <div>
     <button type="button" class="btn btn-primary" (click)="regenerate()">
-      {{ "regeneratePassword" | i18n }}
+      {{ "regenerateUsername" | i18n }}
     </button>
     <button type="button" class="btn btn-outline-secondary" (click)="copy()">
-      {{ "copyPassword" | i18n }}
+      {{ "copyUsername" | i18n }}
     </button>
   </div>
-  <div class="ml-auto">
-    <button
-      type="button"
-      class="btn btn-outline-secondary"
-      (click)="history()"
-      appA11yTitle="{{ 'passwordHistory' | i18n }}"
-    >
-      <i class="bwi bwi-clock bwi-lg" aria-hidden="true"></i>
-    </button>
-  </div>
-</div>
+</ng-container>
 <ng-template #historyTemplate></ng-template>
diff --git a/src/app/tools/tools.component.html b/src/app/tools/tools.component.html
index ec0b152c84..8015ac977d 100644
--- a/src/app/tools/tools.component.html
+++ b/src/app/tools/tools.component.html
@@ -5,7 +5,7 @@
         <div class="card-header">{{ "tools" | i18n }}</div>
         <div class="list-group list-group-flush">
           <a routerLink="generator" class="list-group-item" routerLinkActive="active">
-            {{ "passwordGenerator" | i18n }}
+            {{ "generator" | i18n }}
           </a>
           <a routerLink="import" class="list-group-item" routerLinkActive="active">
             {{ "importData" | i18n }}
diff --git a/src/app/vault/add-edit.component.html b/src/app/vault/add-edit.component.html
index 1edbeffe88..14a8079bf2 100644
--- a/src/app/vault/add-edit.component.html
+++ b/src/app/vault/add-edit.component.html
@@ -769,7 +769,7 @@
             <div class="ml-3" *ngIf="viewingPasswordHistory">
               <div *ngFor="let ph of cipher.passwordHistory">
                 {{ ph.lastUsedDate | date: "short" }} -
-                <span class="password-wrapper text-monospace ml-2">{{ ph.password }}</span>
+                <span class="generated-wrapper text-monospace ml-2">{{ ph.password }}</span>
               </div>
             </div>
           </div>
diff --git a/src/locales/en/messages.json b/src/locales/en/messages.json
index 612bf822f2..03aff173d6 100644
--- a/src/locales/en/messages.json
+++ b/src/locales/en/messages.json
@@ -187,7 +187,12 @@
     "message": "Edit Folder"
   },
   "baseDomain": {
-    "message": "Base domain"
+    "message": "Base domain",
+    "description": "Domain name. Ex. website.com"
+  },
+  "domainName": {
+    "message": "Domain Name",
+    "description": "Domain name. Ex. website.com"
   },
   "host": {
     "message": "Host",
@@ -4826,5 +4831,44 @@
         "example": "My Org Name"
       }
     }
+  },
+  "generator": {
+    "message": "Generator"
+  },
+  "whatWouldYouLikeToGenerate": {
+    "message": "What would you like to generate?"
+  },
+  "passwordType": {
+    "message": "Password Type"
+  },
+  "regenerateUsername": {
+    "message": "Regenerate Username"
+  },
+  "generateUsername": {
+    "message": "Generate Username"
+  },
+  "usernameType": {
+    "message": "Username Type"
+  },
+  "plusAddressedEmail": {
+    "message": "Plus Addressed Email"
+  },
+  "plusAddressedEmailDesc": {
+    "message": "Use your email provider's sub-addressing capabilities."
+  },
+  "catchallEmail": {
+    "message": "Catch-all Email"
+  },
+  "catchallEmailDesc": {
+    "message": "Use your domain's configured catch-all inbox."
+  },
+  "random": {
+    "message": "Random"
+  },
+  "randomWord": {
+    "message": "Random Word"
+  },
+  "service": {
+    "message": "Service"
   }
 }
diff --git a/src/scss/pages.scss b/src/scss/pages.scss
index bbc7617225..979eb9785e 100644
--- a/src/scss/pages.scss
+++ b/src/scss/pages.scss
@@ -1,4 +1,4 @@
-.password-wrapper {
+.generated-wrapper {
   min-width: 0;
   white-space: pre-wrap;
   word-break: break-all;
@@ -114,7 +114,7 @@ app-password-generator {
     width: 100%;
   }
 
-  .card-password {
+  .card-generated {
     .card-body {
       @include themify($themes) {
         background: themed("foregroundColor");