From 23330598858114ab632c3560cfcbc65cc38a5da1 Mon Sep 17 00:00:00 2001 From: Shane Melton Date: Thu, 13 Jun 2024 14:11:18 -0700 Subject: [PATCH] [PM-8831] Hide trashed items from new vault popup lists (#9633) --- .../popup/services/vault-popup-list-filters.service.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts b/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts index 66e264dd6d..8242637d5d 100644 --- a/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts +++ b/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts @@ -2,10 +2,10 @@ import { Injectable } from "@angular/core"; import { takeUntilDestroyed } from "@angular/core/rxjs-interop"; import { FormBuilder } from "@angular/forms"; import { - Observable, combineLatest, distinctUntilChanged, map, + Observable, startWith, switchMap, tap, @@ -104,6 +104,11 @@ export class VaultPopupListFiltersService { map( (filters) => (ciphers: CipherView[]) => ciphers.filter((cipher) => { + // Vault popup lists never shows deleted ciphers + if (cipher.isDeleted) { + return false; + } + if (filters.cipherType !== null && cipher.type !== filters.cipherType) { return false; }