vaultwarden
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

PM-2373 - Fix hang for desktop and browser by removing await from onSuccessfulLogin() call as it was waiting for a full sync to finish before navigating to the vault which let the user see that the loginTwoFactor method had completed and the loading state of the component was "finished" even though it wasn't. Confirmed that the fix from PM-687 still works to allow an emergency contact to sign in via SSO after removing the await. (#5508)

This commit is contained in:
Jared Snider 2023-05-24 16:05:48 -04:00 committed by GitHub
parent 08aa04beab
commit 134b07f439
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/angular/src/auth/components/two-factor.component.ts
View File

@ -202,7 +202,9 @@ export class TwoFactorComponent extends CaptchaProtectedComponent implements OnI
} }
if (this.onSuccessfulLogin != null) { if (this.onSuccessfulLogin != null) {
this.loginService.clearValues(); this.loginService.clearValues();
await this.onSuccessfulLogin(); // Note: awaiting this will currently cause a hang on desktop & browser as they will wait for a full sync to complete
// before nagivating to the success route.
this.onSuccessfulLogin();
} }
if (response.resetMasterPassword) { if (response.resetMasterPassword) {
this.successRoute = "set-password"; this.successRoute = "set-password";