From 0a39d631b01e580ae20b3dceda0173e7efc7104d Mon Sep 17 00:00:00 2001 From: Joseph Flinn Date: Wed, 12 May 2021 15:41:34 -0700 Subject: [PATCH] removing testing code and adding test to release pipeline just in case --- .github/workflows/release.yml | 19 +++++++++++++++++++ src/_locales/en/messages.json | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9ce04db9d4..76c309b3b4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -90,6 +90,25 @@ jobs: npm run dist npm run test + - name: Testing locale lengths + run: | + errors=0 + echo "Testing locales extName lengths" + echo "All must be 40 or less for Safari" + echo "=================================" + for file in $(ls src/_locales/); + do + test_string=$(cat src/_locales/$file/messages.json | jq .extName.message | tr -d '"') + if [[ ${#test_string} -gt 40 ]]; then + echo $file: ${#test_string} + errors=1 + fi + done + + if [[ $errors -eq 1 ]]; then + exit 1 + fi + - name: gulp run: gulp ci diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json index bcd7f81fee..3b5121d7f5 100644 --- a/src/_locales/en/messages.json +++ b/src/_locales/en/messages.json @@ -3,7 +3,7 @@ "message": "Bitwarden" }, "extName": { - "message": "Bitwarden - Free Password Manager (longer than 40 characters for a test)", + "message": "Bitwarden - Free Password Manager", "description": "Extension name, MUST be less than 40 characters (Safari restriction)" }, "extDesc": {