vaultwarden
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

remove analytics settings

This commit is contained in:
Kyle Spearrin 2019-01-15 11:05:45 -05:00
parent 96b8750ff5
commit 071074632a
4 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jslib

@ -1 +1 @@
Subproject commit 2e9ce1571514e2b4ae9ed61a1368b2db03a0ca5d Subproject commit f4c4f2802637f775c3bfba2ef4109350bc842b8f

10
src/app/accounts/settings.component.html
View File

@ -62,16 +62,6 @@
</div> </div>
<small class="help-block">{{'enableCloseToTrayDesc' | i18n}}</small> <small class="help-block">{{'enableCloseToTrayDesc' | i18n}}</small>
</div> </div>
<div class="form-group">
<div class="checkbox">
<label for="disableGa">
<input id="disableGa" type="checkbox" name="DisableAnalytics"
[(ngModel)]="disableGa" (change)="saveGa()">
{{'disableGa' | i18n}}
</label>
</div>
<small class="help-block">{{'gaDesc' | i18n}}</small>
</div>
<div class="form-group"> <div class="form-group">
<label for="theme">{{'theme' | i18n}}</label> <label for="theme">{{'theme' | i18n}}</label>
<select id="theme" name="Theme" [(ngModel)]="theme" (change)="saveTheme()"> <select id="theme" name="Theme" [(ngModel)]="theme" (change)="saveTheme()">

15
src/app/accounts/settings.component.ts
View File

@ -27,7 +27,6 @@ import { Utils } from 'jslib/misc/utils';
}) })
export class SettingsComponent implements OnInit { export class SettingsComponent implements OnInit {
lockOption: number = null; lockOption: number = null;
disableGa: boolean = false;
disableFavicons: boolean = false; disableFavicons: boolean = false;
enableMinToTray: boolean = false; enableMinToTray: boolean = false;
enableCloseToTray: boolean = false; enableCloseToTray: boolean = false;
@ -83,26 +82,12 @@ export class SettingsComponent implements OnInit {
this.enableTray = await this.storageService.get<boolean>(ElectronConstants.enableTrayKey); this.enableTray = await this.storageService.get<boolean>(ElectronConstants.enableTrayKey);
this.locale = await this.storageService.get<string>(ConstantsService.localeKey); this.locale = await this.storageService.get<string>(ConstantsService.localeKey);
this.theme = await this.storageService.get<string>(ConstantsService.themeKey); this.theme = await this.storageService.get<string>(ConstantsService.themeKey);
const disableGa = await this.storageService.get<boolean>(ConstantsService.disableGaKey);
const disableGaByDefault = this.platformUtilsService.isMacAppStore();
this.disableGa = disableGa || (disableGa == null && disableGaByDefault);
} }
async saveLockOption() { async saveLockOption() {
await this.lockService.setLockOption(this.lockOption != null ? this.lockOption : null); await this.lockService.setLockOption(this.lockOption != null ? this.lockOption : null);
} }
async saveGa() {
if (this.disableGa) {
this.callAnalytics('Analytics', !this.disableGa);
}
await this.storageService.save(ConstantsService.disableGaKey, this.disableGa);
if (!this.disableGa) {
this.callAnalytics('Analytics', !this.disableGa);
}
}
async saveFavicons() { async saveFavicons() {
await this.storageService.save(ConstantsService.disableFaviconKey, this.disableFavicons); await this.storageService.save(ConstantsService.disableFaviconKey, this.disableFavicons);
await this.stateService.save(ConstantsService.disableFaviconKey, this.disableFavicons); await this.stateService.save(ConstantsService.disableFaviconKey, this.disableFavicons);

6
src/locales/en/messages.json
View File

@ -797,12 +797,6 @@
"security": { "security": {
"message": "Security" "message": "Security"
}, },
"disableGa": {
"message": "Disable Analytics"
},
"gaDesc": {
"message": "We use analytics to better learn how the application is being used so that we can make it better. All data collection is completely anonymous."
},
"disableFavicon": { "disableFavicon": {
"message": "Disable Website Icons" "message": "Disable Website Icons"
}, },