cryptographically secure RNG for password generator
This commit is contained in:
parent
8f1a8e3ce9
commit
fc1b825f46
|
@ -4,13 +4,13 @@ using System.Linq;
|
||||||
using System.Text;
|
using System.Text;
|
||||||
using Bit.App.Abstractions;
|
using Bit.App.Abstractions;
|
||||||
using Plugin.Settings.Abstractions;
|
using Plugin.Settings.Abstractions;
|
||||||
|
using PCLCrypto;
|
||||||
|
|
||||||
namespace Bit.App.Services
|
namespace Bit.App.Services
|
||||||
{
|
{
|
||||||
public class PasswordGenerationService : IPasswordGenerationService
|
public class PasswordGenerationService : IPasswordGenerationService
|
||||||
{
|
{
|
||||||
private readonly ISettings _settings;
|
private readonly ISettings _settings;
|
||||||
private Random _random = new Random();
|
|
||||||
|
|
||||||
public PasswordGenerationService(ISettings settings)
|
public PasswordGenerationService(ISettings settings)
|
||||||
{
|
{
|
||||||
|
@ -104,7 +104,7 @@ namespace Bit.App.Services
|
||||||
}
|
}
|
||||||
|
|
||||||
// Shuffle
|
// Shuffle
|
||||||
var positions = positionsBuilder.ToString().ToCharArray().OrderBy(a => _random.Next()).ToArray();
|
var positions = positionsBuilder.ToString().ToCharArray().OrderBy(a => Next(int.MaxValue)).ToArray();
|
||||||
|
|
||||||
// Build out other character sets
|
// Build out other character sets
|
||||||
var allCharSet = string.Empty;
|
var allCharSet = string.Empty;
|
||||||
|
@ -168,11 +168,21 @@ namespace Bit.App.Services
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
var randomCharIndex = _random.Next(0, positionChars.Length - 1);
|
var randomCharIndex = Next(positionChars.Length - 1);
|
||||||
password.Append(positionChars[randomCharIndex]);
|
password.Append(positionChars[randomCharIndex]);
|
||||||
}
|
}
|
||||||
|
|
||||||
return password.ToString();
|
return password.ToString();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private int Next(int maxValue)
|
||||||
|
{
|
||||||
|
if(maxValue == 0)
|
||||||
|
{
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (int)(WinRTCrypto.CryptographicBuffer.GenerateRandomNumber() % maxValue);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue