From 9a0388cafd439aba1b7459f35ce004c705c86428 Mon Sep 17 00:00:00 2001
From: Tom Stellard <tom@stellard.net>
Date: Wed, 17 Mar 2021 07:31:27 -0700
Subject: [PATCH] Refactor stat_update_league_players()

---
 src/stat.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/stat.c b/src/stat.c
index 585416f7..6d51873d 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -94,10 +94,11 @@ stat_update_league_players(League *league)
     gint maxlen = const_int("int_stat_players_len");
     Stat new_stat;
 
-    for(i=0;i<league->teams->len;i++)
-	for(j=0;j<g_array_index(league->teams, Team, i).players->len;j++)
+    for(i=0;i<league->teams->len;i++) {
+        Team *team = &g_array_index(league->teams, Team, i);
+	for(j=0;j<team->players->len;j++)
 	{
-	    pl = &g_array_index(g_array_index(league->teams, Team, i).players, Player, j);
+	    pl = &g_array_index(team->players, Player, j);
 	    if(pl->pos != PLAYER_POS_GOALIE)
 		g_ptr_array_add(players_sorted[0], pl);
 	    else if(player_games_goals_get(pl, pl->team->clid, PLAYER_VALUE_GAMES) >=
@@ -105,6 +106,7 @@ stat_update_league_players(League *league)
 		    (gfloat)team_get_table_value(pl->team, TABLE_PLAYED))
 		g_ptr_array_add(players_sorted[1], pl);
 	}
+    }
 
     g_ptr_array_sort_with_data(players_sorted[0], player_compare_func, 
 			       GINT_TO_POINTER(PLAYER_COMPARE_ATTRIBUTE_LEAGUE_GOALS));