rixty/bygfoot
1
1
Fork 0
mirror of https://github.com/tstellar/bygfoot.git synced 2025-01-24 21:01:12 +01:00
Code Issues Projects Releases Wiki Activity

Avoid infinite loop in job_pick_team_from_country()

Browse Source 
This function was looping forever if all the national teams were added
to the job list.
This commit is contained in:
Tom Stellard 2021-02-19 08:37:03 -08:00 committed by Tom Stellard
parent fdc15fdf8a
commit 4ad92b9884
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/job.c
View File

@ -50,6 +50,7 @@ job_update(Bygfoot *bygfoot)
gint i; gint i;
gint new_offers, int_offers; gint new_offers, int_offers;
gint national_teams = 0;
for(i=jobs->len - 1; i >= 0; i--) for(i=jobs->len - 1; i >= 0; i--)
{ {
@ -62,8 +63,19 @@ job_update(Bygfoot *bygfoot)
if(week % const_int("int_job_update_interval") != 2) if(week % const_int("int_job_update_interval") != 2)
return; return;
for (i = 0; i < country.leagues->len; i++) {
national_teams += g_array_index(country.leagues, League, i).teams->len;
}
/* Limit the total number of jobs to the number of national teams.
* Otherwise, we risk hitting an infinite loop in
* job_pick_team_from_country();
*/
new_offers = math_rndi(const_int("int_job_new_offers_lower"), new_offers = math_rndi(const_int("int_job_new_offers_lower"),
const_int("int_job_new_offers_upper")); const_int("int_job_new_offers_upper"));
new_offers = MIN(new_offers, national_teams - jobs->len);
int_offers = (users->len == 1) ? int_offers = (users->len == 1) ?
(gint)rint((gfloat)new_offers * (gint)rint((gfloat)new_offers *
const_float("float_job_international_perc")) : 0; const_float("float_job_international_perc")) : 0;