From fc8553a140728e11dc0698a128c5a8001f85a09e Mon Sep 17 00:00:00 2001
From: Cohee <titan0599@gmail.com>
Date: Wed, 28 Jun 2023 20:35:25 +0300
Subject: [PATCH] Remove embedded lorebook when unselecting it in UI

---
 public/index.html |  4 ++--
 public/script.js  | 21 +++++++++++++++++++--
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/public/index.html b/public/index.html
index 3dba3d24d..293119948 100644
--- a/public/index.html
+++ b/public/index.html
@@ -2493,10 +2493,10 @@
                                                 <select id="char-management-dropdown">
                                                     <option value="default" disabled selected>More...</option>
                                                     <option id="set_character_world">
-                                                        <i class="fa-solid fa-globe"></i> Link to World Info
+                                                        Link to World Info
                                                     </option>
                                                     <option id="import_character_info">
-                                                        <i class="fa-solid fa-file-import"></i> Import Card Lore
+                                                        Import Card Lore
                                                     </option>
                                                     <option id="set_chat_scenario">
                                                         Scenario Override
diff --git a/public/script.js b/public/script.js
index ac93f5ae0..737ea416a 100644
--- a/public/script.js
+++ b/public/script.js
@@ -5521,11 +5521,12 @@ function openCharacterWorldPopup() {
         return;
     }
 
-    function onSelectCharacterWorld() {
+    async function onSelectCharacterWorld() {
         const value = $('.character_world_info_selector').find('option:selected').val();
         const worldIndex = value !== '' ? Number(value) : NaN;
         const name = !isNaN(worldIndex) ? world_names[worldIndex] : '';
 
+        const previousValue = $('#character_world').val();
         $('#character_world').val(name);
 
         console.debug('Character world selected:', name);
@@ -5533,7 +5534,23 @@ function openCharacterWorldPopup() {
         if (menu_type == 'create') {
             create_save.world = name;
         } else {
-            createOrEditCharacter();
+            if (previousValue && !name) {
+                try {
+                    // Dirty hack to remove embedded lorebook from character JSON data.
+                    const data = JSON.parse($('#character_json_data').val());
+
+                    if (data?.data?.character_book) {
+                        data.data.character_book = undefined;
+                    }
+
+                    $('#character_json_data').val(JSON.stringify(data));
+                    toastr.info('Embedded lorebook will be removed from this character.');
+                } catch {
+                    console.error('Failed to parse character JSON data.');
+                }
+            }
+
+            await createOrEditCharacter();
         }
 
         setWorldInfoButtonClass(undefined, !!value);