diff --git a/public/script.js b/public/script.js index 198e44c78..6de80e06e 100644 --- a/public/script.js +++ b/public/script.js @@ -5436,6 +5436,10 @@ export async function renameCharacter(name = null, { silent = false, renameChats toastr.warning('No character name provided.', 'Rename Character'); return false; } + if (this_chid === undefined) { + toastr.warning('No character selected.', 'Rename Character'); + return false; + } const oldAvatar = characters[this_chid].avatar; const newValue = name || await callPopup('

New name:

', 'input', characters[this_chid].name); diff --git a/public/scripts/slash-commands.js b/public/scripts/slash-commands.js index c910a20bf..a1ba74f33 100644 --- a/public/scripts/slash-commands.js +++ b/public/scripts/slash-commands.js @@ -328,7 +328,7 @@ SlashCommandParser.addCommandObject(SlashCommand.fromProps({ name: 'rename-char', /** @param {{silent: string, renameChats: string}} options @param {string} name */ callback: async ({ silent = 'true', renameChats = null }, name) => { - const renamed = await renameCharacter(name, { silent: silent === 'true', renameChats: renameChats !== null ? renameChats === 'true' : null }); + const renamed = await renameCharacter(name, { silent: isTrueBoolean(silent), renameChats: renameChats !== null ? isTrueBoolean(renameChats) : null }); return String(renamed); }, returns: 'true/false - Whether the rename was successful', @@ -337,7 +337,7 @@ SlashCommandParser.addCommandObject(SlashCommand.fromProps({ 'silent', 'Hide any blocking popups. (if false, the name is optional. If not supplied, a popup asking for it will appear)', [ARGUMENT_TYPE.BOOLEAN], false, false, 'true' ), new SlashCommandNamedArgument( - 'renameChats', 'Rename char in all previous chats', [ARGUMENT_TYPE.BOOLEAN], false, false, '' + 'chats', 'Rename char in all previous chats', [ARGUMENT_TYPE.BOOLEAN], false, false, '' ), ], unnamedArgumentList: [