rixty
/
SillyTavern
mirror of https://github.com/SillyTavern/SillyTavern.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cache compiled Handlebars templates 

Since we already have a template cache, it makes sense to store the
templates in it *after* compiling them, to avoid the overhead of
re-compiling them every time we call renderTemplate.

I've also changed the cache from an object to a Map--it's more
semantically correct, and avoids weird edge cases like a template named
"hasOwnProperty" or some other function that exists as an object
property.
This commit is contained in:
valadaptive 2023-12-09 21:29:36 -05:00
parent a8224c16de
commit c48bc8a76e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
public/script.js
View File

@ -526,14 +526,17 @@ function getUrlSync(url, cache = true) {
}).responseText; }).responseText;
} }
const templateCache = {}; const templateCache = new Map();
export function renderTemplate(templateId, templateData = {}, sanitize = true, localize = true, fullPath = false) { export function renderTemplate(templateId, templateData = {}, sanitize = true, localize = true, fullPath = false) {
try { try {
const pathToTemplate = fullPath ? templateId : `/scripts/templates/${templateId}.html`; const pathToTemplate = fullPath ? templateId : `/scripts/templates/${templateId}.html`;
const templateContent = (pathToTemplate in templateCache) ? templateCache[pathToTemplate] : getUrlSync(pathToTemplate); let template = templateCache.get(pathToTemplate);
templateCache[pathToTemplate] = templateContent; if (!template) {
const template = Handlebars.compile(templateContent); const templateContent = getUrlSync(pathToTemplate);
template = Handlebars.compile(templateContent);
templateCache.set(pathToTemplate, template);
}
let result = template(templateData); let result = template(templateData);
if (sanitize) { if (sanitize) {