From b143b3c8208c83264e70fc2337fd0cce6378ef76 Mon Sep 17 00:00:00 2001 From: Cohee <18619528+Cohee1207@users.noreply.github.com> Date: Sun, 17 Nov 2024 20:10:51 +0200 Subject: [PATCH] Fix type errors --- public/scripts/logprobs.js | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/public/scripts/logprobs.js b/public/scripts/logprobs.js index 9bde4f660..fa7ff0d15 100644 --- a/public/scripts/logprobs.js +++ b/public/scripts/logprobs.js @@ -24,6 +24,10 @@ const REROLL_BUTTON = $('#logprobsReroll'); * @typedef {[string, number]} Candidate - (token, logprob) */ +/** + * @typedef {(Node|JQuery|JQuery)[]} NodeArray - Array of DOM nodes + */ + /** * Logprob data for a single message * @typedef {Object} MessageLogprobData @@ -200,15 +204,15 @@ function renderTopLogprobs() { container.addClass('selected'); } - const tokenText = $('').text(`${toVisibleWhitespace(token)}`); - const percentText = $('').text(`${(probability * 100).toFixed(2)}%`); + const tokenText = $('').text(`${toVisibleWhitespace(token.toString())}`); + const percentText = $('').text(`${(+probability * 100).toFixed(2)}%`); container.append(tokenText, percentText); if (log) { container.attr('title', `logarithm: ${log}`); } addKeyboardProps(container); if (token !== '') { - container.on('click', () => onAlternativeClicked(state.selectedTokenLogprobs, token)); + container.on('click', () => onAlternativeClicked(state.selectedTokenLogprobs, token.toString())); } else { container.prop('disabled', true); } @@ -228,7 +232,7 @@ function renderTopLogprobs() { * User clicks on a token in the token output view. It updates the selected token state * and re-renders the top logprobs view, or deselects the token if it was already selected. * @param {TokenLogprobs} logprobs - logprob data for the selected token - * @param {Element} span - target span node that was clicked + * @param {Node|JQuery} span - target span node that was clicked */ function onSelectedTokenChanged(logprobs, span) { $('.logprobs_output_token.selected').removeClass('selected'); @@ -399,11 +403,11 @@ function toVisibleWhitespace(input) { * after the span node if its token begins or ends with whitespace in order to * allow text to wrap despite whitespace characters being replaced with a dot. * @param {string} text - token text being evaluated for whitespace - * @param {Element} span - target span node to be wrapped - * @returns {Node[]} - array of nodes to be appended to the parent element + * @param {Node|JQuery} span - target span node to be wrapped + * @returns {NodeArray} - array of nodes to be appended to the parent element */ function withVirtualWhitespace(text, span) { - /** @type {Node[]} */ + /** @type {NodeArray} */ const result = [span]; if (text.match(/^\s/)) { result.unshift(document.createTextNode('\u200b')); @@ -522,7 +526,7 @@ function convertTokenIdLogprobsToText(input) { // Submit token IDs to tokenizer to get token text, then build ID->text map // noinspection JSCheckFunctionSignatures - mutates input in-place - const { chunks } = decodeTextTokens(tokenizerId, tokenIds); + const { chunks } = decodeTextTokens(tokenizerId, tokenIds.map(parseInt)); const tokenIdText = new Map(tokenIds.map((id, i) => [id, chunks[i]])); // Fixup logprobs data with token text