rixty
/
SillyTavern
mirror of https://github.com/SillyTavern/SillyTavern.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make v2 spec read logspam slightly actionable 

The existing logspam doesn't even tell the user what char is failing, which means it's
just going to emit every startup, forever, grinding at the poor user's soul, never
letting them know *which* of their 352 cards is causing the spam... day after day after
day.  Until one day, the poor beleaguered user will emit the world's ugliest PR to at
least find the broken card in an attempt kill it.

Ask me how I know.
This commit is contained in:
majick 2023-10-14 17:41:23 -10:00
parent d0637750e7
commit a9ebd2f80e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server.js
View File

@ -858,7 +858,7 @@ function unsetFavFlag(char) {
function readFromV2(char) { function readFromV2(char) {
if (_.isUndefined(char.data)) { if (_.isUndefined(char.data)) {
console.warn('Spec v2 data missing'); console.warn('Char ${char['name']} has Spec v2 data missing');
return char; return char;
} }
@ -893,12 +893,12 @@ function readFromV2(char) {
//console.debug(`Spec v2 extension data missing for field: ${charField}, using default value: ${defaultValue}`); //console.debug(`Spec v2 extension data missing for field: ${charField}, using default value: ${defaultValue}`);
char[charField] = defaultValue; char[charField] = defaultValue;
} else { } else {
console.debug(`Spec v2 data missing for unknown field: ${charField}`); console.debug(`Char ${char['name']} has Spec v2 data missing for unknown field: ${charField}`);
return; return;
} }
} }
if (!_.isUndefined(char[charField]) && !_.isUndefined(v2Value) && String(char[charField]) !== String(v2Value)) { if (!_.isUndefined(char[charField]) && !_.isUndefined(v2Value) && String(char[charField]) !== String(v2Value)) {
console.debug(`Spec v2 data mismatch with Spec v1 for field: ${charField}`, char[charField], v2Value); console.debug(`Char ${char['name']} has Spec v2 data mismatch with Spec v1 for field: ${charField}`, char[charField], v2Value);
} }
char[charField] = v2Value; char[charField] = v2Value;
}); });