From 9c3e8c935b7a7002294dabfdd84b7905455f55f7 Mon Sep 17 00:00:00 2001
From: KevinSun <paver.mails+github@gmail.com>
Date: Fri, 21 Feb 2025 23:49:15 +0800
Subject: [PATCH] refactor(Middleware): only mount accessLogger when listen is
 enabled

---
 server.js                      | 4 +++-
 src/middleware/accessLogger.js | 5 ++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/server.js b/server.js
index 16c300bba..5228c34b9 100644
--- a/server.js
+++ b/server.js
@@ -344,7 +344,9 @@ app.use(CORS);
 if (listen && basicAuthMode) app.use(basicAuthMiddleware);
 
 app.use(whitelistMiddleware(enableWhitelist));
-app.use(accessLoggerMiddleware(listen));
+if (listen) {
+    app.use(accessLoggerMiddleware());
+}
 
 if (enableCorsProxy) {
     app.use(bodyParser.json({
diff --git a/src/middleware/accessLogger.js b/src/middleware/accessLogger.js
index a392e5595..26a2b49aa 100644
--- a/src/middleware/accessLogger.js
+++ b/src/middleware/accessLogger.js
@@ -28,15 +28,14 @@ export function migrateAccessLog() {
 
 /**
  * Creates middleware for logging access and new connections
- * @param {boolean} listen If listen mode is enabled via config or command line
  * @returns {import('express').RequestHandler}
  */
-export default function accessLoggerMiddleware(listen) {
+export default function accessLoggerMiddleware() {
     return function (req, res, next) {
         const clientIp = getRealIpFromHeader(req);
         const userAgent = req.headers['user-agent'];
 
-        if (listen && !knownIPs.has(clientIp)) {
+        if (!knownIPs.has(clientIp)) {
             // Log new connection
             console.info(color.yellow(`New connection from ${clientIp}; User Agent: ${userAgent}\n`));
             knownIPs.add(clientIp);