From 9b24397f5af97f0bbc9c8b8f543d92481027ec54 Mon Sep 17 00:00:00 2001
From: Wolfsblvt <wolfsblvt@gmx.de>
Date: Tue, 2 Apr 2024 00:42:13 +0200
Subject: [PATCH 1/2] Unify {{pick}} and {{random}} regex

- Allow all four possible syntax forms, just to make this easier: {{random::one::two}}, {{random:one::two}}, {{random::one,two}} and {{random:one,two}}
---
 public/scripts/macros.js | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/public/scripts/macros.js b/public/scripts/macros.js
index cd40f0245..fcda91cf6 100644
--- a/public/scripts/macros.js
+++ b/public/scripts/macros.js
@@ -185,8 +185,7 @@ function getTimeSinceLastMessage() {
 }
 
 function randomReplace(input, emptyListPlaceholder = '') {
-    const randomPatternNew = /{{random\s?::\s?([^}]+)}}/gi;
-    const randomPatternOld = /{{random\s?:\s?([^}]+)}}/gi;
+    const randomPatternNew = /{{random\s?::?\s?([^}]+)}}/gi;
 
     input = input.replace(randomPatternNew, (match, listString) => {
         //split on double colons instead of commas to allow for commas inside random items
@@ -202,20 +201,11 @@ function randomReplace(input, emptyListPlaceholder = '') {
         //trim() at the end to allow for empty random values
         return list[randomIndex].trim();
     });
-    input = input.replace(randomPatternOld, (match, listString) => {
-        const list = listString.split(',').map(item => item.trim()).filter(item => item.length > 0);
-        if (list.length === 0) {
-            return emptyListPlaceholder;
-        }
-        const rng = new Math.seedrandom('added entropy.', { entropy: true });
-        const randomIndex = Math.floor(rng() * list.length);
-        return list[randomIndex];
-    });
     return input;
 }
 
 function pickReplace(input, rawContent, emptyListPlaceholder = '') {
-    const pickPattern = /{{pick\s?::\s?([^}]+)}}/gi;
+    const pickPattern = /{{pick\s?::?\s?([^}]+)}}/gi;
     const chatIdHash = getStringHash(getCurrentChatId());
     const rawContentHash = getStringHash(rawContent);
 

From 3632631997f7107032d78803dc3f1f873b914300 Mon Sep 17 00:00:00 2001
From: Wolfsblvt <wolfsblvt@gmx.de>
Date: Tue, 2 Apr 2024 01:02:02 +0200
Subject: [PATCH 2/2] random and pick allow empty items and trim correctly

---
 public/scripts/macros.js | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/public/scripts/macros.js b/public/scripts/macros.js
index fcda91cf6..504b05596 100644
--- a/public/scripts/macros.js
+++ b/public/scripts/macros.js
@@ -185,45 +185,46 @@ function getTimeSinceLastMessage() {
 }
 
 function randomReplace(input, emptyListPlaceholder = '') {
-    const randomPatternNew = /{{random\s?::?\s?([^}]+)}}/gi;
+    const randomPattern = /{{random\s?::?([^}]+)}}/gi;
 
-    input = input.replace(randomPatternNew, (match, listString) => {
-        //split on double colons instead of commas to allow for commas inside random items
+    input = input.replace(randomPattern, (match, listString) => {
+        // Split on either double colons or comma. If comma is the separator, we are also trimming all items.
         const list = listString.includes('::')
-            ? listString.split('::').filter(item => item.length > 0)
-            : listString.split(',').map(item => item.trim()).filter(item => item.length > 0);
+            ? listString.split('::')
+            : listString.split(',').map(item => item.trim());
 
         if (list.length === 0) {
             return emptyListPlaceholder;
         }
         const rng = new Math.seedrandom('added entropy.', { entropy: true });
         const randomIndex = Math.floor(rng() * list.length);
-        //trim() at the end to allow for empty random values
-        return list[randomIndex].trim();
+        return list[randomIndex];
     });
     return input;
 }
 
 function pickReplace(input, rawContent, emptyListPlaceholder = '') {
-    const pickPattern = /{{pick\s?::?\s?([^}]+)}}/gi;
+    const pickPattern = /{{pick\s?::?([^}]+)}}/gi;
     const chatIdHash = getStringHash(getCurrentChatId());
     const rawContentHash = getStringHash(rawContent);
 
     return input.replace(pickPattern, (match, listString, offset) => {
+        // Split on either double colons or comma. If comma is the separator, we are also trimming all items.
         const list = listString.includes('::')
-            ? listString.split('::').filter(item => item.length > 0)
-            : listString.split(',').map(item => item.trim()).filter(item => item.length > 0);
+            ? listString.split('::')
+            : listString.split(',').map(item => item.trim());
 
         if (list.length === 0) {
             return emptyListPlaceholder;
         }
 
+        // We build a hash seed based on: unique chat file, raw content, and the placement inside this content
+        // This allows us to get unique but repeatable picks in nearly all cases
         const combinedSeedString = `${chatIdHash}-${rawContentHash}-${offset}`;
         const finalSeed = getStringHash(combinedSeedString);
         const rng = new Math.seedrandom(finalSeed);
-
         const randomIndex = Math.floor(rng() * list.length);
-        return list[randomIndex].trim();
+        return list[randomIndex];
     });
 }