rixty/SillyTavern
1
0
Fork 0
mirror of https://github.com/SillyTavern/SillyTavern.git synced 2025-06-05 21:59:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make hidden reasoning blocks not toggleable

Browse Source
This commit is contained in:
Wolfsblvt
2025-02-12 22:38:26 +01:00
parent 25a2582d15
commit 93f3334ad0
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
public/scripts/reasoning.js
View File

@ -153,7 +153,7 @@ export class ReasoningHandler {
// Cached DOM elements for reasoning // Cached DOM elements for reasoning
/** @type {HTMLElement} Main message DOM element `.mes` */ /** @type {HTMLElement} Main message DOM element `.mes` */
this.messageDom = null; this.messageDom = null;
/** @type {HTMLElement} Reasoning details DOM element `.mes_reasoning_details` */ /** @type {HTMLDetailsElement} Reasoning details DOM element `.mes_reasoning_details` */
this.messageReasoningDetailsDom = null; this.messageReasoningDetailsDom = null;
/** @type {HTMLElement} Reasoning content DOM element `.mes_reasoning` */ /** @type {HTMLElement} Reasoning content DOM element `.mes_reasoning` */
this.messageReasoningContentDom = null; this.messageReasoningContentDom = null;
@ -336,6 +336,11 @@ export class ReasoningHandler {
const button = this.messageDom.querySelector('.mes_edit_add_reasoning'); const button = this.messageDom.querySelector('.mes_edit_add_reasoning');
button.title = this.state === ReasoningState.Hidden ? t`Hidden reasoning - Add reasoning block` : t`Add reasoning block`; button.title = this.state === ReasoningState.Hidden ? t`Hidden reasoning - Add reasoning block` : t`Add reasoning block`;
// Make sure that hidden reasoning headers are collapsed by default, to not show a useless edit button
if (this.state === ReasoningState.Hidden) {
this.messageReasoningDetailsDom.open = false;
}
// Update the reasoning duration in the UI // Update the reasoning duration in the UI
this.#updateReasoningTimeUI(); this.#updateReasoningTimeUI();
} }
@ -628,7 +633,14 @@ function setReasoningEventHandlers() {
} }
}); });
$(document).on('click', '.mes_reasoning_header', function () { $(document).on('click', '.mes_reasoning_header', function (e) {
const details = $(this).closest('.mes_reasoning_details');
// Along with the CSS rules to mark blocks not toggle-able when they are empty, prevent them from actually being toggled, or being edited
if (details.find('.mes_reasoning').is(':empty')) {
e.preventDefault();
return;
}
// If we are in message edit mode and reasoning area is closed, a click opens and edits it // If we are in message edit mode and reasoning area is closed, a click opens and edits it
const mes = $(this).closest('.mes'); const mes = $(this).closest('.mes');
const mesEditArea = mes.find('#curEditTextarea'); const mesEditArea = mes.find('#curEditTextarea');

4
public/style.css
View File

@ -398,6 +398,10 @@ input[type='checkbox']:focus-visible {
align-items: baseline; align-items: baseline;
} }
.mes:has(.mes_reasoning:empty) .mes_reasoning_header {
cursor: default;
}
/* TWIMC: Remove with custom CSS to show the icon */ /* TWIMC: Remove with custom CSS to show the icon */
.mes_reasoning_header > .icon-svg { .mes_reasoning_header > .icon-svg {
display: none; display: none;