Regex: fix multiple script bug

Multiple scripts were not running due to improper variable assingment.
For efficiency's sake, do not do a string comparison before returning
and instead do another variable assignment in the parent function.

Doing this reduces the length of regex hooks in the parent calls,
but also removes the need for unnecessary O(n) complexity of comparing
two string variables.

If there are errors, it would be advisable to add string comparison
and revert back to the old logic in parent function calls.

Signed-off-by: kingbri <bdashore3@proton.me>

public/script.js

@@ -1137,10 +1137,7 @@ function messageFormatting(mes, ch_name, isSystem, isUser) {
         mes = mes.replaceAll(substituteParams(power_user.user_prompt_bias), "");
     }
 
-    const regexResult = getRegexedString(mes, regex_placement.MD_DISPLAY);
+    mes = getRegexedString(mes, regex_placement.MD_DISPLAY);
-    if (regexResult) {
-        mes = regexResult;
-    }
 
     if (power_user.auto_fix_generated_markdown) {
         mes = fixMarkdown(mes);
@@ -2956,10 +2953,7 @@ export function replaceBiasMarkup(str) {
 }
 
 export async function sendMessageAsUser(textareaText, messageBias) {
-    const regexResult = getRegexedString(textareaText, regex_placement.USER_INPUT);
+    textareaText = getRegexedString(textareaText, regex_placement.USER_INPUT);
-    if (regexResult) {
-        textareaText = regexResult;
-    }
 
     chat[chat.length] = {};
     chat[chat.length - 1]['name'] = name1;
@@ -3551,10 +3545,7 @@ function cleanUpMessage(getMessage, isImpersonate, displayIncompleteSentences =
     }
 
     // Regex uses vars, so add before formatting
-    const regexResult = getRegexedString(getMessage, isImpersonate ? regex_placement.USER_INPUT : regex_placement.AI_OUTPUT);
+    getMessage = getRegexedString(getMessage, isImpersonate ? regex_placement.USER_INPUT : regex_placement.AI_OUTPUT);
-    if (regexResult) {
-        getMessage = regexResult;
-    }
 
     if (!displayIncompleteSentences && power_user.trim_sentences) {
         getMessage = end_trim_to_sentence(getMessage, power_user.include_newline);
@@ -4985,16 +4976,13 @@ function updateMessage(div) {
         regexPlacement = regex_placement.SYSTEM;
     }
 
-    const regexResult = getRegexedString(
+    text = getRegexedString(
         text,
         regexPlacement,
         {
             characterOverride: regexPlacement === regex_placement.SENDAS ? mes.name : undefined
         }
     );
-    if (regexResult) {
-        text = regexResult;
-    }
 
     if (power_user.trim_spaces) {
         text = text.trim();
@@ -6113,10 +6101,7 @@ async function createOrEditCharacter(e) {
                     ) {
                         // MARK - kingbri: Regex on character greeting message
                         // May need to be placed somewhere else
-                        const regexResult = getRegexedString(this_ch_mes, regex_placement.AI_OUTPUT);
+                        this_ch_mes = getRegexedString(this_ch_mes, regex_placement.AI_OUTPUT);
-                        if (regexResult) {
-                            this_ch_mes = regexResult;
-                        }
 
                         clearChat();
                         chat.length = 0;

public/scripts/extensions/regex/engine.js

@@ -39,14 +39,14 @@ function regexFromString(input) {
 
 // Parent function to fetch a regexed version of a raw string
 function getRegexedString(rawString, placement, { characterOverride } = {}) {
+    let finalString = rawString;
     if (extension_settings.disabledExtensions.includes("regex") || !rawString || placement === undefined) {
-        return;
+        return finalString;
     }
 
-    let finalString;
     extension_settings.regex.forEach((script) => {
         if (script.placement.includes(placement)) {
-            finalString = runRegexScript(script, rawString, { characterOverride });
+            finalString = runRegexScript(script, finalString, { characterOverride });
         }
     });
 
@@ -55,17 +55,17 @@ function getRegexedString(rawString, placement, { characterOverride } = {}) {
 
 // Runs the provided regex script on the given string
 function runRegexScript(regexScript, rawString, { characterOverride } = {}) {
+    let newString = rawString;
     if (!regexScript || !!(regexScript.disabled) || !regexScript?.findRegex || !rawString) {
-        return;
+        return newString;
     }
 
     let match;
-    let newString;
     const findRegex = regexFromString(regexScript.substituteRegex ? substituteParams(regexScript.findRegex) : regexScript.findRegex);
 
     // The user skill issued. Return with nothing.
     if (!findRegex) {
-        return;
+        return newString;
     }
 
     while ((match = findRegex.exec(rawString)) !== null) {

public/scripts/slash-commands.js

@@ -226,10 +226,7 @@ async function sendMessageAs(_, text) {
 
     const name = parts.shift().trim();
     let mesText = parts.join('\n').trim();
-    const regexResult = getRegexedString(mesText, regex_placement.SENDAS, { characterOverride: name });
+    mesText = getRegexedString(mesText, regex_placement.SENDAS, { characterOverride: name });
-    if (regexResult) {
-        mesText = regexResult;
-    }
 
     // Messages that do nothing but set bias will be hidden from the context
     const bias = extractMessageBias(mesText);
@@ -273,10 +270,7 @@ async function sendNarratorMessage(_, text) {
         return;
     }
 
-    const regexResult = getRegexedString(text, regex_placement.SYSTEM);
+    text = getRegexedString(text, regex_placement.SYSTEM);
-    if (regexResult) {
-        text = regexResult;
-    }
 
     const name = chat_metadata[NARRATOR_NAME_KEY] || NARRATOR_NAME_DEFAULT;
     // Messages that do nothing but set bias will be hidden from the context