Refactor chid/grid attributes to data attributes

- We don't believe in imaginary HTML attributes that we make up, right?
This commit is contained in:
Wolfsblvt
2025-01-24 21:12:49 +01:00
parent a611a3ac59
commit 7c9b347116
7 changed files with 34 additions and 26 deletions

View File

@@ -677,7 +677,7 @@ export function getGroupBlock(group) {
const template = $('#group_list_template .group_select').clone();
template.data('id', group.id);
template.attr('grid', group.id);
template.attr('data-grid', group.id);
template.find('.ch_name').text(group.name).attr('title', `[Group] ${group.name}`);
template.find('.group_fav_icon').css('display', 'none');
template.addClass(group.fav ? 'is_fav' : '');
@@ -1364,7 +1364,7 @@ function getGroupCharacterBlock(character) {
template.data('id', character.avatar);
template.find('.avatar img').attr({ 'src': avatar, 'title': character.avatar });
template.find('.ch_name').text(character.name);
template.attr('chid', characters.indexOf(character));
template.attr('data-chid', characters.indexOf(character));
template.find('.ch_fav').val(isFav);
template.toggleClass('is_fav', isFav);
@@ -1641,7 +1641,7 @@ async function onGroupActionClick(event) {
}
if (action === 'speak') {
const chid = Number(member.attr('chid'));
const chid = Number(member.attr('data-chid'));
if (Number.isInteger(chid)) {
Generate('normal', { force_chid: chid });
}
@@ -1693,7 +1693,7 @@ function openCharacterDefinition(characterSelect) {
return;
}
const chid = characterSelect.attr('chid');
const chid = characterSelect.attr('data-chid');
if (chid === null || chid === undefined) {
return;
@@ -2011,7 +2011,7 @@ jQuery(() => {
}
$(document).on('click', '.group_select', function () {
const groupId = $(this).attr('chid') || $(this).attr('grid') || $(this).data('id');
const groupId = $(this).attr('data-chid') || $(this).attr('data-grid');
openGroupById(groupId);
});
$('#rm_group_filter').on('input', filterGroupMembers);